Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028447Retail ModulesDiscounts and Promotionspublic2014-12-18 09:532015-01-09 15:22
Reporteramayavicente 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028447: It is not possible disable a discount using the ending date
DescriptionIt is not possible disable a discount using the ending date
Steps To Reproduce-In the backend, for an active discount that is shown in the POS Terminal, enter an ending date < current date.
-Login in the POS Terminal, the discount is still shown although ending date < current date.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0028015RR15Q1 closed migueldejuana Use/take into account the active flag for all master data when doing incremental refresh 
depends on defect 0027896RR15Q1 closed migueldejuana Discretionary discounts are not disabled when you disable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-18 09:53amayavicenteNew Issue
2014-12-18 09:53amayavicenteAssigned To => marvintm
2014-12-18 09:53amayavicenteTriggers an Emergency Pack => No
2014-12-18 14:06amayavicenteNote Added: 0072697
2015-01-08 17:19migueldejuanaRelationship addeddepends on 0028015
2015-01-08 17:57migueldejuanaRelationship addeddepends on 0027896
2015-01-08 17:57migueldejuanaReview Assigned To => marvintm
2015-01-08 17:57migueldejuanaOBNetwork customer => No
2015-01-08 17:57migueldejuanaAssigned Tomarvintm => migueldejuana
2015-01-08 17:57migueldejuanaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7407#r7407
2015-01-09 13:56hgbotCheckin
2015-01-09 13:56hgbotNote Added: 0073396
2015-01-09 13:56hgbotStatusnew => resolved
2015-01-09 13:56hgbotResolutionopen => fixed
2015-01-09 13:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/53e7ec015d2fcce3ac20a677a9b8c88a389071e4 [^]
2015-01-09 15:22marvintmStatusresolved => closed

Notes
(0072697)
amayavicente   
2014-12-18 14:06   
If the following issue is fixed https://issues.openbravo.com/view.php?id=27896: [^]
-For a discount with ending date = blank, if the user deactivate it in the backend, with a incremental refresh, the discount will not be shown in the POS Terminal.
-For a discount with ending date < current date, if the user deactivate it in the backend, the discount will be shown in the pos terminal til a fully refresh will be done.

For this reason, if a user enters an ending date < current date at the same time that he deactivate the discount, user will have the impression that the active option doesn't work.
(0073396)
hgbot   
2015-01-09 13:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 53e7ec015d2fcce3ac20a677a9b8c88a389071e4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jan 08 17:55:46 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/53e7ec015d2fcce3ac20a677a9b8c88a389071e4 [^]

Fixed issue 0028447: It is not possible disable a discount using the ending date
Remove the filter from the model and apply it in the discounts selector in the UI

---
M src/org/openbravo/retail/posterminal/master/Discount.java
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
---