Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0028438Openbravo ERPA. Platformpublic2014-12-17 16:152015-02-23 05:11
ngarcia 
alostale 
highminoralways
closedfixed 
5
 
3.0PR15Q23.0PR15Q2 
AugustoMauch
Core
No
0028438: Property fields cannot be included in validations
Property fields cannot be included in validations
As system admin role:

 * In Windows Tabs and Field open Currency > Currency Conversion tab definition
 * Add a new field:
    -name: Currency Code
    -property: currency.iSOCode
 * Create a new Validation Setup:
    -name: currency conversion
    -code: c_currency.iso_code != '@_propertyField_currencycode_ISO_Code@'
 * Edit C_Conversion_Rate.C_Currency_ID_To column adding the created validation


 * Open Currency Window
 * Select any record
 * Create new Conversion Rate
    -> check To Currency combo has no values: it should show all defined currencies but the one selected in the header
No tags attached.
related to defect 0025701 closed AugustoMauch FIC response causes an error when open in edit view payment details tab 
related to defect 0025630 closed AugustoMauch Reference list not retrieved correctly if there exists a property field in the window with a particular name 
related to defect 0028977 closed caristu NPE if property field can not reach the complete path 
related to defect 0036163 closed alostale val rule referring non-existent col fails if there's a property field with same name 
Issue History
2014-12-17 16:15ngarciaNew Issue
2014-12-17 16:15ngarciaAssigned To => AugustoMauch
2014-12-17 16:15ngarciaModules => Core
2014-12-17 16:15ngarciaResolution time => 1393369200
2014-12-17 16:15ngarciaTriggers an Emergency Pack => No
2014-12-17 16:16ngarciaIssue Monitored: networkb
2014-12-17 18:23alostaleRelationship addedrelated to 0025630
2014-12-18 11:13alostaleResolution time1393369200 => 1424905200
2015-01-13 18:56ngarciaTarget Version => 3.0PR15Q2
2015-01-30 10:02alostaleRelationship addedrelated to 0025701
2015-01-30 11:05alostaleNote Added: 0073935
2015-01-30 11:05alostaleAssigned ToAugustoMauch => jonalegriaesarte
2015-01-30 11:05alostaleStatusnew => feedback
2015-02-02 13:31jonalegriaesarteAssigned Tojonalegriaesarte => ngarcia
2015-02-16 16:44ngarciaNote Added: 0074518
2015-02-16 16:44ngarciaAssigned Tongarcia => alostale
2015-02-16 16:44ngarciaStatusfeedback => new
2015-02-16 17:49alostaleStatusnew => scheduled
2015-02-16 17:49alostalefix_in_branch => pi
2015-02-18 10:43alostaleRelationship addedrelated to 0028977
2015-02-18 13:50alostalefix_in_branchpi =>
2015-02-18 13:50alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7703#r7703
2015-02-18 13:58alostaleNote Added: 0074597
2015-02-18 14:01alostaleReview Assigned To => AugustoMauch
2015-02-18 14:01hgbotCheckin
2015-02-18 14:01hgbotNote Added: 0074599
2015-02-18 14:01hgbotStatusscheduled => resolved
2015-02-18 14:01hgbotResolutionopen => fixed
2015-02-18 14:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0fb59d223c5d0b27974f065fb8da0e79e657c4d1 [^]
2015-02-18 17:24AugustoMauchNote Added: 0074614
2015-02-18 17:24AugustoMauchStatusresolved => closed
2015-02-18 17:24AugustoMauchFixed in Version => 3.0PR15Q2
2015-02-23 05:11hudsonbotCheckin
2015-02-23 05:11hudsonbotNote Added: 0074783
2017-06-01 13:29alostaleRelationship addedrelated to 0036163

Notes
(0073935)
alostale   
2015-01-30 11:05   
Steps to reproduce has nothing to do with description: @DocumentNo@ is not a property field in Financial Account > Transaction tab not even an existent field.

Please provide better description/steps to reproduce.
(0074518)
ngarcia   
2015-02-16 16:44   
Although Payment No. was a property field in Financial Account - Transactions tab, new steps to reproduce are provided as DocumentNo columns are managed in a different way:

As system admin role:
Create a new field in the Sales Invoice - Header tab
Add the following value in the Property field:
   businessPartner.priceList.name
Check the column assigned is Name
Edit the Price List isSOTrx validation code (assigned to M_PriceList_ID column). Add the following clause
   and M_PriceList.name = @Name@

As group admin role:
   Create a new record in the Sales Invoice window
   Check the following error message is shown in the log
      Error. The columns M_PriceList_ID have validations which form a cycle.
(0074597)
alostale   
2015-02-18 13:58   
New syntax to refer them in validation rules has been defined: http://wiki.openbravo.com/wiki/How_to_use_property_fields#Using_in_validation_rules [^]
(0074599)
hgbot   
2015-02-18 14:01   
Repository: erp/devel/pi
Changeset: 0fb59d223c5d0b27974f065fb8da0e79e657c4d1
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Feb 18 14:00:33 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0fb59d223c5d0b27974f065fb8da0e79e657c4d1 [^]

fixed bug 28438: Property fields cannot be included in validations

  A new syntax has been defined to use property fields within validation rules.

  More information on how to use it:
   http://wiki.openbravo.com/wiki/How_to_use_property_fields#Using_in_validation_rules [^]

---
M src/org/openbravo/erpCommon/utility/Utility.java
---
(0074614)
AugustoMauch   
2015-02-18 17:24   
Code reviewed and verified in pi@b5ce661abc2d
(0074783)
hudsonbot   
2015-02-23 05:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6856352d7235 [^]
Maturity status: Test