Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028428Retail ModulesWeb POSpublic2014-12-16 22:222015-06-10 20:12
Reportermtaal 
Assigned Toaaroncalero 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q3Fixed in VersionRR15Q3 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028428: Improve master data loading of WebPOS
DescriptionSee here:
http://wiki.openbravo.com/wiki/Projects:Retail_Master_Data_Synchronization [^]
Steps To ReproduceSee above link.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to backport 0027431 closed Retail Sometimes the business partner is empty when the WebPOS loads 
related to feature request 0029468 closed aaroncalero [UX] Report the stage and status instead of the 'loading' image of the loading process 
blocks design defect 0027800 new guilleaer Implement pagination for picking lists with big amount of lines 
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
causes defect 0033519 closed ranjith_qualiantech_com Masterdata loading fails when pagination is used 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-16 22:22mtaalNew Issue
2014-12-16 22:22mtaalAssigned To => mtaal
2014-12-16 22:22mtaalTriggers an Emergency Pack => No
2015-03-05 13:14dmitry_mezentsevRelationship addedblocks 0027800
2015-03-05 13:15dmitry_mezentsevTarget VersionRR15Q2 => RR15Q3
2015-04-13 12:33marvintmAssigned Tomtaal => aaroncalero
2015-05-07 10:26hgbotCheckin
2015-05-07 10:26hgbotNote Added: 0077070
2015-05-07 10:26hgbotCheckin
2015-05-07 10:26hgbotNote Added: 0077071
2015-05-07 10:27hgbotCheckin
2015-05-07 10:27hgbotNote Added: 0077072
2015-05-07 10:27hgbotStatusnew => resolved
2015-05-07 10:27hgbotResolutionopen => fixed
2015-05-07 10:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ff2762ac7701bb4820033be11ba206ac294dada9 [^]
2015-05-07 10:27hgbotCheckin
2015-05-07 10:27hgbotNote Added: 0077073
2015-05-07 10:28hgbotCheckin
2015-05-07 10:28hgbotNote Added: 0077074
2015-05-07 15:35OrekariaRelationship addedblocks 0027329
2015-05-07 16:37hgbotCheckin
2015-05-07 16:37hgbotNote Added: 0077097
2015-05-07 16:52aaroncaleroRelationship addedrelated to 0029468
2015-05-08 08:36hgbotCheckin
2015-05-08 08:36hgbotNote Added: 0077220
2015-05-08 10:44hgbotCheckin
2015-05-08 10:44hgbotNote Added: 0077223
2015-05-14 09:01hgbotCheckin
2015-05-14 09:01hgbotNote Added: 0077421
2015-05-14 09:01hgbotCheckin
2015-05-14 09:01hgbotNote Added: 0077422
2015-06-01 12:34hgbotCheckin
2015-06-01 12:34hgbotNote Added: 0077926
2015-06-01 12:34mtaalNote Added: 0077927
2015-06-01 14:13mtaalReview Assigned To => mtaal
2015-06-01 14:13mtaalNote Added: 0077946
2015-06-01 14:13mtaalStatusresolved => closed
2015-06-01 14:13mtaalFixed in Version => RR15Q3
2015-06-10 20:12OrekariaRelationship addedrelated to 0027431
2016-07-26 12:18dmitry_mezentsevRelationship addedcauses 0033519

Notes
(0077070)
hgbot   
2015-05-07 10:26   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a950157be0006f2e3f023f64d8ab1e9a9b2bb99a
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu Apr 30 09:06:20 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a950157be0006f2e3f023f64d8ab1e9a9b2bb99a [^]

Related to issue 28428: Improve master data loading

If any of the master data models fails to load, a popup will be shown forcing to reload the application.
Improved the OB.DS.Datasource and OB.DS.Request components to trigger the ready event even if the load failed.
The last full and incremental refresh timestamps are set after all the models have updated correctly.
The model checksums are set after the local tables have been created.
Created the OB.MobileApp.model.handlePropertiesLoader function to wrap the handling of properties and to provide error handling.
Removed duplicated code.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0077071)
hgbot   
2015-05-07 10:26   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 16c16becce5940181302c0ce81d9378cbb631e90
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu Apr 30 10:24:51 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/16c16becce5940181302c0ce81d9378cbb631e90 [^]

Related to issue 28428: Improve master data loading

Now the master data models will be loaded in pages of 35000 records and the requests to the server will be done incrementally until all data has been loaded. This has been done to reduce the size of the xhr response in case of high volumes of data, to reduce the size of the javascript objects in the application, and to prevent browser crashes when handling such big objects.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---
(0077072)
hgbot   
2015-05-07 10:27   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ff2762ac7701bb4820033be11ba206ac294dada9
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed May 06 16:21:06 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ff2762ac7701bb4820033be11ba206ac294dada9 [^]

Fixed issue 28428: Improve master data loading

Implemented additional features to improve the loading process:
The loading image now shows a progress bar (instead of a static image) and shows a message about the current loading step
The load of the models has been serialized to reduce server and client workload

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0077073)
hgbot   
2015-05-07 10:27   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c11c1a7c616c049daa043e2daeb7e0891d6c33ae
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu May 07 09:59:45 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c11c1a7c616c049daa043e2daeb7e0891d6c33ae [^]

Related to issue 28428: Improve master data loading

Prevent showing an error popup during the terminal properties loading process if another popup is already shown.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0077074)
hgbot   
2015-05-07 10:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 565a5d64faa40721e0b1eeec59fafa01afd48c82
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu May 07 09:51:29 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/565a5d64faa40721e0b1eeec59fafa01afd48c82 [^]

Related to issue 28428: Improve master data loading of WebPOS

Refactor the loading of properties to use the new OB.MobileApp.model.handlePropertiesLoader function
Refactor the loading of Terminal Properties and Context to force a refresh in case of error

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0077097)
hgbot   
2015-05-07 16:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fd8b40582252af86a33522606520b0ed1cad0cf1
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu May 07 16:32:12 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd8b40582252af86a33522606520b0ed1cad0cf1 [^]

Related to issue 28428: Improve master data loading

If the Terminal object fails to be loaded because of a known error (error message equals an existing message label) force a logout.
These errors are usually caused either by a configuration error (these will keep popping until fixed) or by trying to reuse a session opened in the backend within the same browser (these will be fixed upon relogging).

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0077220)
hgbot   
2015-05-08 08:36   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a55859bf5697f758ca61a70aa136aca037ca510b
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri May 08 08:34:50 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a55859bf5697f758ca61a70aa136aca037ca510b [^]

Related to issue 28428: Improve master data loading

Prevented doing OB.Dal.initCache with online models as these models are not stored in the websql database.
Updated copyright year.

---
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---
(0077223)
hgbot   
2015-05-08 10:44   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4d116566db36984734fc2f0aac5c135827b4fdaa
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri May 08 10:29:33 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4d116566db36984734fc2f0aac5c135827b4fdaa [^]

Related to issue 28428: Improve master data loading

Fixed the OB.UTIL.getNonLocalModels function to return the models from all the windows, as the same model can be registered in different windows.

---
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0077421)
hgbot   
2015-05-14 09:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9e72ba8daf0facec0a5f9cc3634790f498bb6115
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed May 13 13:06:44 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9e72ba8daf0facec0a5f9cc3634790f498bb6115 [^]

Related to issue 28428: Small style changes

Replaced the Loading <element> label with Reading <element> to avoid redundancy.
Added the text-overflow: ellipsis property to the loading messages to avoid line jumps
Fixed the style of the loading bar to prevent image inconsistencies while not in development
Force hiding the loading messages outside of the logging process

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0077422)
hgbot   
2015-05-14 09:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d511af7f1b75ceec14ddbc47dd92bd6f1b5a6731
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed May 13 13:13:39 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d511af7f1b75ceec14ddbc47dd92bd6f1b5a6731 [^]

Related to issue 28428: Improve master data loading

Improved the full data refresh process error handling to allow using the application even in case of error if:
a) A full refresh was successfully done and
b) During the current refresh no paged request has failed (to ensure that all existing models are complete)

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---
(0077926)
hgbot   
2015-06-01 12:34   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 351d0aafb4d31cf7873115c39a2f03fefefce4bb
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon Jun 01 12:30:17 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/351d0aafb4d31cf7873115c39a2f03fefefce4bb [^]

Related to issue 28428: Removed duplicated if/else code

---
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---
(0077927)
mtaal   
2015-06-01 12:34   
Tests:
- Normal flow of login and update/change of masterdata has been tested, works
- The logic has been in PI for one month, all testcases pass and it has been used by many people in the past month
- I tested the flow with a low limit/page size, logic worked fine and retrieved updated information in pages
- I tested the flow by forcing an error on the server. Worked fine, if the data was already loaded the application could still be used. If the data was not yet loaded an error popup was shown correctly.
(0077946)
mtaal   
2015-06-01 14:13   
Reviewed and tested