Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0028426Openbravo ERP07. Sales managementpublic2014-12-16 18:262016-02-02 09:38
ngarcia 
umartirena 
immediatemajoralways
closedfixed 
5
 
3.0PR15Q2 
Sandrahuguet
Core
Production - Confirmed Stable
2012-03-26
https://code.openbravo.com/erp/devel/pi/rev/cb5cc787ce23462f96bff2aa4780993597440bbb [^]
No
0028426: Cannot add a product to a commission if it doesn't have a sales price defined
Cannot add a product to a commission if it doesn't have a sales price defined
As group admin role:
   Create a product
   Add a purchase price to it
   Create a record in the Commission window
   Try to select the product in the Invoiced Product field and check it is not there.It should appear
   Add a sales price to it
   Check the product could be selected now
No tags attached.
caused by defect 00200893.0MP10 closed jecharri It is possible select a purchase price list in the product selector of sales invoice 
related to defect 0031396 scheduled markmm82 Wrong product selector is defined for Invoice Product field of Commission window 
Issue History
2014-12-16 18:26ngarciaNew Issue
2014-12-16 18:26ngarciaAssigned To => AtulOpenbravo
2014-12-16 18:26ngarciaModules => Core
2014-12-16 18:26ngarciaResolution time => 1421622000
2014-12-16 18:26ngarciaTriggers an Emergency Pack => No
2014-12-16 18:27ngarciaRelationship addedcaused by 0020168
2014-12-16 18:31ngarciaIssue Monitored: networkb
2015-01-05 10:33ngarciaRegression level => Production - Confirmed Stable
2015-01-05 10:33ngarciaRegression introduced in release => 3.0MP11
2015-01-05 10:36ngarciaRegression introduced in release3.0MP11 =>
2015-01-22 03:03AtulOpenbravoStatusnew => scheduled
2015-01-22 03:03AtulOpenbravofix_in_branch => pi
2015-01-22 13:09AtulOpenbravoReview Assigned To => Sandrahuguet
2015-01-22 13:09AtulOpenbravoRegression date => 2012-03-26
2015-01-22 13:09AtulOpenbravoRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/cb5cc787ce23462f96bff2aa4780993597440bbb [^]
2015-01-22 13:09AtulOpenbravoNote Added: 0073720
2015-01-22 13:09AtulOpenbravofix_in_branchpi =>
2015-01-22 13:09AtulOpenbravoRelationship addedcaused by 0020089
2015-01-22 13:10AtulOpenbravoRelationship deletedcaused by 0020168
2015-01-28 19:17hgbotCheckin
2015-01-28 19:17hgbotNote Added: 0073874
2015-01-28 19:17hgbotStatusscheduled => resolved
2015-01-28 19:17hgbotResolutionopen => fixed
2015-01-28 19:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2ab32dc8dcea7381253e9fb94f66f8e5560b2e11 [^]
2015-01-29 11:27SandrahuguetNote Added: 0073889
2015-01-29 11:27SandrahuguetStatusresolved => closed
2015-01-29 11:27SandrahuguetFixed in Version => 3.0PR15Q2
2015-02-04 20:34hudsonbotCheckin
2015-02-04 20:34hudsonbotNote Added: 0074193
2015-02-11 09:16SandrahuguetAssigned ToAtulOpenbravo => umartirena
2015-11-06 15:12ngarciaRelationship addedrelated to 0031396
2016-02-02 09:38hgbotCheckin
2016-02-02 09:38hgbotNote Added: 0083821

Notes
(0073720)
AtulOpenbravo   
2015-01-22 13:09   
Test Plan
- Login as Group Admin role
- Create a product.
- Add a purchase price to it
- Create a record in the Commission window
- Try to select the product in the Invoiced Product field and check it appears.
(0073874)
hgbot   
2015-01-28 19:17   
Repository: erp/devel/pi
Changeset: 2ab32dc8dcea7381253e9fb94f66f8e5560b2e11
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Jan 28 09:31:53 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2ab32dc8dcea7381253e9fb94f66f8e5560b2e11 [^]

Fixes bug 28426: A product without sales price can be added to a commision

Filter expression of Product Selector has been changed for Commission window, to not to filter by Sales flag, displaying in this way Purchase and Sales Products.

---
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---
(0073889)
Sandrahuguet   
2015-01-29 11:27   
Code review + testing OK
(0074193)
hudsonbot   
2015-02-04 20:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test
(0083821)
hgbot   
2016-02-02 09:38   
Repository: tools/automation/int
Changeset: 3fcc617d349718bb85607ea05d48eb98b62b0f9b
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Oct 07 10:24:45 2015 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/3fcc617d349718bb85607ea05d48eb98b62b0f9b [^]

Related to issue 28426: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/modules/client/application/navigationbarcomponents/gui/Menu.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/PRO_Regressions/PRO_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/PRO_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/SAL_Regressions/SAL_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/SAL_Regressions/build.xml
A src-test/com/openbravo/test/integration/erp/gui/sales/setup/CommissionTab.java
A src-test/com/openbravo/test/integration/erp/gui/sales/setup/CommissionWindow.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/PRO_Regressions/PRORegression28426.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/SAL_Regressions/SALRegression28426.java
A src-test/com/openbravo/test/integration/erp/testscripts/sales/setup/Commission.java
A src-test/com/openbravo/test/integration/erp/testscripts/sales/setup/CommissionClassicScript.java
A src-test/com/openbravo/test/integration/erp/testscripts/sales/setup/CommissionScript.java
---