Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028423Openbravo ERP04. Warehouse managementpublic2014-12-16 15:202014-12-19 11:29
Reporterumartirena 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028423: API Break on Cost Adjustments Project (try-api 985)
DescriptionAPI Break due to the following data has been removed from Application Dictionary:
 * Report and Process: "Validate Costing Rule"
 * AD Implementation Mapping: "org.openbravo.costing.CostingRuleProcess" classname

This process has been re-implemented in the Cost Adjustments project, and it has been defined in "Process Definition" window, in order to use all new capabilities that this processes offer. The name of the new process is also "Validate Costing Rule".

The risk of this change is low.
Steps To ReproduceLook at: https://ci.openbravo.com/job/try-api/996/consoleFull [^]

[checkAPI] 11955 ERROR -
 [checkAPI]
 [checkAPI] 11957 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 11958 ERROR - Errors in API data validation
 [checkAPI] 11959 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 11960 ERROR - Removed row from table AD_MODEL_OBJECT - ID: 6E4B444F00A742AD86F4C8E013884933
 [checkAPI] 11961 ERROR - Removed row from table AD_PROCESS - ID: A269DCA4DE114E438695B66E166999B4
 [checkAPI] 11962 ERROR -
 [checkAPI]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028289 closed umartirena [Costing] No cost calculated in case costing rule does not have a starting date nor a fix backdated from date 
related to defect 0029127 closed alostale PR14Q3 -> PR14Q4 update can fail activating FKs 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-16 15:20umartirenaNew Issue
2014-12-16 15:20umartirenaAssigned To => dmiguelez
2014-12-16 15:20umartirenaOBNetwork customer => No
2014-12-16 15:20umartirenaModules => Core
2014-12-16 15:20umartirenaTriggers an Emergency Pack => No
2014-12-17 10:17dmitry_mezentsevNote Added: 0072597
2014-12-17 10:25umartirenaNote Added: 0072601
2014-12-17 10:48dmitry_mezentsevRelationship addedrelated to 0028289
2014-12-17 11:26dmitry_mezentsevNote Added: 0072613
2014-12-17 11:26dmitry_mezentsevAssigned Todmiguelez => umartirena
2014-12-17 13:36umartirenaNote Edited: 0072601bug_revision_view_page.php?bugnote_id=0072601#r7283
2014-12-17 20:17umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7287#r7287
2014-12-17 20:25hgbotCheckin
2014-12-17 20:25hgbotNote Added: 0072676
2014-12-17 20:25hgbotStatusnew => resolved
2014-12-17 20:25hgbotResolutionopen => fixed
2014-12-17 20:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/ffe4c941c96f81433469575ee7ff629445827567 [^]
2014-12-19 11:29SandrahuguetReview Assigned To => Sandrahuguet
2014-12-19 11:29SandrahuguetNote Added: 0072726
2014-12-19 11:29SandrahuguetStatusresolved => closed
2015-03-05 13:14alostaleRelationship addedrelated to 0029127

Notes
(0072597)
dmitry_mezentsev   
2014-12-17 10:17   
Unai,

Could you explain a bit "The risk of this change is low.".
Thanks.
(0072601)
umartirena   
2014-12-17 10:25   
(edited on: 2014-12-17 13:36)
Dmitry,

I mean that the risk of the API Change is low because the process that is executed behind is still the same, so if somebody is using it in its own module, it should be OK. The new process definition (because process definition implements different class) just calls the old one.
(0072613)
dmitry_mezentsev   
2014-12-17 11:26   
Approved.
(0072676)
hgbot   
2014-12-17 20:25   
Repository: erp/devel/api-checks
Changeset: ffe4c941c96f81433469575ee7ff629445827567
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Dec 17 20:24:08 2014 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/ffe4c941c96f81433469575ee7ff629445827567 [^]

Fixes Issue 28423: API Break on Cost Adjustments Project (try-api 985)

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_PROCESS.xml
---
(0072726)
Sandrahuguet   
2014-12-19 11:29   
Verified