Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028406Openbravo ERPA. Platformpublic2014-12-12 14:202014-12-30 23:27
Reporteraferraz 
Assigned Toaferraz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target VersionFixed in Version3.0PR15Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028406: RescheduleProcess class should be able to get requestId from request parameters
DescriptionIn order to be able to execute a process request from a JUnit test, RescheduleProcess java class should be able to get requestId from request parameters if session value is empty.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042044 closed caristu Duplicated code in ScheduleProcess and RescheduleProcess 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-12 14:20aferrazNew Issue
2014-12-12 14:20aferrazAssigned To => aferraz
2014-12-12 14:20aferrazModules => Core
2014-12-12 14:20aferrazTriggers an Emergency Pack => No
2014-12-15 10:01hgbotCheckin
2014-12-15 10:01hgbotNote Added: 0072493
2014-12-15 10:01hgbotStatusnew => resolved
2014-12-15 10:01hgbotResolutionopen => fixed
2014-12-15 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b2a6c840d54416e4f15fe8a4a5439ca2cf2b7ebe [^]
2014-12-15 10:29aferrazAssigned Toaferraz => alostale
2014-12-17 08:46alostaleAssigned Toalostale => aferraz
2014-12-17 08:47alostaleReview Assigned To => alostale
2014-12-17 09:14hgbotCheckin
2014-12-17 09:14hgbotNote Added: 0072595
2014-12-23 10:22alostaleNote Added: 0072792
2014-12-23 10:22alostaleStatusresolved => closed
2014-12-23 10:22alostaleFixed in Version => 3.0PR15Q1
2014-12-30 23:27hudsonbotCheckin
2014-12-30 23:27hudsonbotNote Added: 0073216
2014-12-30 23:27hudsonbotCheckin
2014-12-30 23:27hudsonbotNote Added: 0073227
2019-10-16 17:59caristuRelationship addedrelated to 0042044

Notes
(0072493)
hgbot   
2014-12-15 10:01   
Repository: erp/devel/pi
Changeset: b2a6c840d54416e4f15fe8a4a5439ca2cf2b7ebe
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Dec 12 14:35:09 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b2a6c840d54416e4f15fe8a4a5439ca2cf2b7ebe [^]

Fixes bug 28406: RescheduleProcess should get requestId from request parameters

In order to be able to execute a process request from a JUnit test, RescheduleProcess java class should be able to get requestId from request parameters if session value is empty.

---
M src/org/openbravo/erpCommon/ad_process/RescheduleProcess.java
---
(0072595)
hgbot   
2014-12-17 09:14   
Repository: erp/devel/pi
Changeset: 7876814d68571b9de44faa079c2151c0efd7fb41
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Dec 17 09:13:27 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7876814d68571b9de44faa079c2151c0efd7fb41 [^]

Related to bug 28406: RescheduleProcess should get requestId from parameters

Added brackets to the if sentence

---
M src/org/openbravo/erpCommon/ad_process/RescheduleProcess.java
---
(0072792)
alostale   
2014-12-23 10:22   
code reviewed: even requestId.isEmpty() is used, there's no NPE risk as vars.getSessionValue doesn't return null but "" for empty values
(0073216)
hudsonbot   
2014-12-30 23:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073227)
hudsonbot   
2014-12-30 23:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test