Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028403Retail ModulesQuotationspublic2014-12-12 12:592014-12-18 17:54
Reportermalsasua 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028403: receipt craeted from quotation is not synced when the quotation has been modified in other terminal
Descriptionwhen a receipt is created from quotation, and at the same time, the quotation has been reactivated and confirmed at the same time in other terminal, the receipt is not synced and he is added to window Errors while importing POS data
Steps To Reproduce. login in terminal VBS-1
 . create quotation
 . add line qty 1
 . confirm it -> "under evaluation" is displayed
 . close it
 . load the previous quotation

. at the same time, open a new navigator (other session) with the terminal VBS1001
 . load the previous quotation
 . reactivate -> draft is displayed
 . add one unit to the line (total qty 2)
 . confirm it -> "under evaluation" is displayed

. return to the initial navigator (session with terminal VBS-1)
 . create sales order from quotation
 . pay it
 
go to backend:
 in the "errors while importing data" window a new record has been created with the previous sales order.
Error:
java.lang.NullPointerException
    at org.openbravo.retail.posterminal.OrderLoader.associateOrderToQuotation(OrderLoader.java:374)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:225)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:117)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:87)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:51)
    at org.openbravo.mobile.core.process.JSONProcessSimple.exec(JSONProcessSimple.java:34)
    at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:39)
    at org.openbravo.mobile.core.process.MobileService.execClassName(MobileService.java:154)
    at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:77)
    at org.openbravo.mobile.core.process.MobileService.doPost(MobileService.java:48)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:449)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:88)
    at org.openbravo.mobile.core.process.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:51)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:291)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859)
    at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:602)
    at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
    at java.lang.Thread.run(Thread.java:701)

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-12 12:59malsasuaNew Issue
2014-12-12 12:59malsasuaAssigned To => marvintm
2014-12-12 12:59malsasuaTriggers an Emergency Pack => No
2014-12-12 13:02hgbotCheckin
2014-12-12 13:02hgbotNote Added: 0072450
2014-12-12 13:02hgbotStatusnew => resolved
2014-12-12 13:02hgbotResolutionopen => fixed
2014-12-12 13:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0982799fb0c10efbde901128aa4000243567231d [^]
2014-12-18 17:54marvintmReview Assigned To => marvintm
2014-12-18 17:54marvintmStatusresolved => closed
2014-12-18 17:54marvintmFixed in Version => RR15Q1

Notes
(0072450)
hgbot   
2014-12-12 13:02   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0982799fb0c10efbde901128aa4000243567231d
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Fri Dec 12 13:02:39 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0982799fb0c10efbde901128aa4000243567231d [^]

fixed issue 28403: added try/catch when the function associateOrderToQuotation is called: the quotation could have been deleted

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---