Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028399Retail ModulesQuotationspublic2014-12-12 12:132014-12-18 15:50
Reportermalsasua 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028399: quotations are not synced when a quotation is modified in two terminals at the same time
Descriptionwhen a quotation is modified at the same time in two terminals, when in the second terminal, the quotation is confirmed, this quotation is not synced and one record is added to window "Errors while importing POS data"
Steps To Reproduce. in webpos:
 . login to VBS-1
 . create a quotation Q1
 . add one line with qty 1
 . confirm it -> "under evaluation" is displayed
 . close it
 . load the previous quotation
 . reactivate

. open a new navigator (with other session) and not close the previous session
 . login to VBS1001 terminal
 . load the previous quotation
 . reactivate it -> "Draft status" is displayed
 . add one unit to line 1 (total qty 2)
 . confirm it -> "under evaluation" is displayed
(it is synced ok)

. in the previous session of navigator
 . add two units to line 1 (total qty 3)
 . confirm it -> "under evaluation" is displayed
(it is not synced)

. go to backend
 . in the window "Errors while to import data" is displayed one record with the previous quotation with this error:

java.lang.NullPointerException
    at org.openbravo.dal.service.OBDal.remove(OBDal.java:270)
    at org.openbravo.retail.posterminal.OrderLoader.deleteOldDocument(OrderLoader.java:390)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:162)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:117)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:87)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:51)
    at org.openbravo.mobile.core.process.JSONProcessSimple.exec(JSONProcessSimple.java:34)
    at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:39)
    at org.openbravo.mobile.core.process.MobileService.execClassName(MobileService.java:154)
    at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:77)
    at org.openbravo.mobile.core.process.MobileService.doPost(MobileService.java:48)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:449)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:88)
    at org.openbravo.mobile.core.process.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:51)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:291)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859)
    at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:602)
    at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
    at java.lang.Thread.run(Thread.java:701)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-12 12:13malsasuaNew Issue
2014-12-12 12:13malsasuaAssigned To => marvintm
2014-12-12 12:13malsasuaOBNetwork customer => No
2014-12-12 12:13malsasuaTriggers an Emergency Pack => No
2014-12-12 12:18hgbotCheckin
2014-12-12 12:18hgbotNote Added: 0072448
2014-12-12 12:18hgbotStatusnew => resolved
2014-12-12 12:18hgbotResolutionopen => fixed
2014-12-12 12:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0090ae127a6ca6992527e5b848592453a2ed8d01 [^]
2014-12-18 15:50marvintmReview Assigned To => marvintm
2014-12-18 15:50marvintmStatusresolved => closed
2014-12-18 15:50marvintmFixed in Version => RR15Q1

Notes
(0072448)
hgbot   
2014-12-12 12:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0090ae127a6ca6992527e5b848592453a2ed8d01
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Fri Dec 12 12:17:56 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0090ae127a6ca6992527e5b848592453a2ed8d01 [^]

fixed issue 28399: added try/catch to function to delete old quotations to avoid duplicated quotations when a quotation is reactivated

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---