Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028362Openbravo ERP07. Sales managementpublic2014-12-09 10:032014-12-30 23:27
Reporteralostale 
Assigned ToSandrahuguet 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-06-19
Regression introduced in release3.0MP13
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/09a2cab4bfac [^]
Triggers an Emergency PackYes
Summary0028362: c_invoice_post creates unnecesary contention on m_pricelist and c_doctype
Descriptionc_invoice_post procedure unnecessarily locks m_pricelist and c_doctype tables (with a select for update).

This, potentially, causes a big contention.

See description for 0028360
Steps To ReproduceSee 0028360
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0028360 closed Sandrahuguet c_order_post creates unnecesary contention on m_pricelist 
related to defect 0028365 new Triage Omni OMS c_invoice post locks some master tables 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-09 10:03alostaleNew Issue
2014-12-09 10:03alostaleAssigned To => Sandrahuguet
2014-12-09 10:03alostaleModules => Core
2014-12-09 10:03alostaleRegression level => Production - Confirmed Stable
2014-12-09 10:03alostaleTriggers an Emergency Pack => No
2014-12-09 10:04alostaleRegression date => 2012-06-19
2014-12-09 10:04alostaleRegression introduced in release => 3.0MP13
2014-12-09 10:04alostaleTriggers an Emergency PackNo => Yes
2014-12-09 10:04alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/09a2cab4bfac [^]
2014-12-09 10:05alostaleRelationship addedrelated to 0028360
2014-12-09 10:05alostaleTag Attached: Performance
2014-12-09 10:05alostaleIssue Monitored: alostale
2014-12-09 12:39alostaleRelationship addedrelated to 0028365
2014-12-10 10:24SandrahuguetNote Added: 0072378
2014-12-10 10:30hgbotCheckin
2014-12-10 10:30hgbotNote Added: 0072380
2014-12-10 10:30hgbotStatusnew => resolved
2014-12-10 10:30hgbotResolutionopen => fixed
2014-12-10 10:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a73f9b345a421d0a76f498bc1c722b15825daefc [^]
2014-12-10 13:58umartirenaReview Assigned To => umartirena
2014-12-10 13:58umartirenaNote Added: 0072398
2014-12-10 13:58umartirenaStatusresolved => closed
2014-12-10 13:58umartirenaFixed in Version => pi
2014-12-30 23:27hudsonbotCheckin
2014-12-30 23:27hudsonbotNote Added: 0073202

Notes
(0072378)
Sandrahuguet   
2014-12-10 10:24   
Test Plan:
-Create a new Sales Invoice with lines (check its price list)
-In a pg client (psql) run:
  begin
    select c_invoice_post(null, (select c_order_id from c_invoice order by created desc limit 1));
- Create new Sales Invoice with same price list
(0072380)
hgbot   
2014-12-10 10:30   
Repository: erp/devel/pi
Changeset: a73f9b345a421d0a76f498bc1c722b15825daefc
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Dec 09 18:59:11 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a73f9b345a421d0a76f498bc1c722b15825daefc [^]

Fixed bug 28362 c_invoice_post creates unnecesary contentions

Avoiding the join with m_pricelist and c_doctype contentions are solved

---
M src-db/database/model/functions/C_INVOICE_POST.xml
---
(0072398)
umartirena   
2014-12-10 13:58   
Code Review + Testing OK
(0073202)
hudsonbot   
2014-12-30 23:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test