Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028328Retail ModulesCash uppublic2014-12-01 14:142014-12-09 15:48
Reportermalsasua 
Assigned Tomalsasua 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-11-21
Regression introduced in releaseRR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0aa9ef48b337 [^]
Triggers an Emergency PackNo
Summary0028328: quotation amount is aggregated to the Gross sales section, in the cashup report
DescriptionIn the cashup report printed in WEB POS, the quotation amount is summed to the total gross sales
Steps To Reproduce. do quotation
 . add line Avalenche
 . total quotation: 150.5
 . click in total amount-> "under evaluation" is displayed
 . close quotation

. do cashup
 . in report:
   . total Gross Amount: 150.5 is displayed, but 0 should be displayed
Proposed Solutionin the line
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/4583a01d6acb/web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js#l60 [^]

should be checked if it is a quotation or not
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Selection_179.png (127,251) 2014-12-08 09:18
https://issues.openbravo.com/file_download.php?file_id=7578&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-12-01 14:14malsasuaNew Issue
2014-12-01 14:14malsasuaAssigned To => marvintm
2014-12-01 14:14malsasuaTriggers an Emergency Pack => No
2014-12-02 10:01malsasuaRegression level => Production - Confirmed Stable
2014-12-02 10:01malsasuaRegression date => 2013-11-21
2014-12-02 10:01malsasuaRegression introduced in release => RR14Q2
2014-12-02 10:01malsasuaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0aa9ef48b337 [^]
2014-12-02 10:01malsasuaProposed Solution updated
2014-12-02 10:26malsasuaSummaryquotation amount is sum to Gross sales in cashup report => quotation amount is aggregated to the Gross sales section, in the cashup report
2014-12-02 10:26malsasuaDescription Updatedbug_revision_view_page.php?rev_id=7198#r7198
2014-12-02 11:59hgbotCheckin
2014-12-02 11:59hgbotNote Added: 0072229
2014-12-02 12:00hgbotStatusnew => resolved
2014-12-02 12:00hgbotResolutionopen => fixed
2014-12-02 12:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1684b7cc74ec4920f567381eeefaba027fb337be [^]
2014-12-08 09:18mtaalFile Added: Selection_179.png
2014-12-08 09:19mtaalAssigned Tomarvintm => malsasua
2014-12-08 09:19mtaalNote Added: 0072323
2014-12-08 09:19mtaalStatusresolved => new
2014-12-08 09:19mtaalResolutionfixed => open
2014-12-09 11:17hgbotCheckin
2014-12-09 11:17hgbotNote Added: 0072342
2014-12-09 11:17hgbotStatusnew => resolved
2014-12-09 11:17hgbotResolutionopen => fixed
2014-12-09 11:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1684b7cc74ec4920f567381eeefaba027fb337be [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dd8ba7ad23f104918af8338b79f8f3f9d8aa7c05 [^]
2014-12-09 15:48mtaalReview Assigned To => mtaal
2014-12-09 15:48mtaalNote Added: 0072364
2014-12-09 15:48mtaalStatusresolved => closed
2014-12-09 15:48mtaalFixed in Version => RR15Q1

Notes
(0072229)
hgbot   
2014-12-02 11:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1684b7cc74ec4920f567381eeefaba027fb337be
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue Dec 02 11:59:33 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1684b7cc74ec4920f567381eeefaba027fb337be [^]

fixed issue 28328: with quotations, the amount is not added to grossSales

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0072323)
mtaal   
2014-12-08 09:19   
Reviewing, but found this:
Sales figure is correct but tax is still shown on the cashup report, see screenshot
(0072342)
hgbot   
2014-12-09 11:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dd8ba7ad23f104918af8338b79f8f3f9d8aa7c05
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue Dec 09 11:16:26 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dd8ba7ad23f104918af8338b79f8f3f9d8aa7c05 [^]

fixed issue 28328: taxes quotations are not summed to tax section

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0072364)
mtaal   
2014-12-09 15:48   
Reviewed and re-tested