Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028322Retail ModulesWeb POSpublic2014-11-28 16:492015-07-22 10:27
Reporterjecharri 
Assigned Toaaroncalero 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q1Fixed in VersionRR15Q3 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket32636
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028322: Not possible to pay a layaway using credit
DescriptionNot possible to pay a layaway using credit
Steps To Reproduce-Configure terminal and business partner to be able to pay using credit
-Create a layaway
-Open layaway and press in total to pay

Verify that credit option does no appear
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0023877 closed adrianromero Not able to pay using credit option for an Layaway order 
related to defect 0029636 closed Retail "Use Credit" button appears in a "To be laid away" receipt 
related to defect 0028963 closed adrianromero [RR15Q1.1] Use Credit button wrongly appears at webpos, when the user selects Layaway this receipt option 
blocks feature request 0029530RR16Q1 closed Retail QA: RR15Q3: Add tests for Mobile applications 
Attached Filespng Selection_032.png (247,009) 2014-12-17 18:51
https://issues.openbravo.com/file_download.php?file_id=7613&type=bug
png

png Selection_031.png (469,643) 2014-12-17 18:51
https://issues.openbravo.com/file_download.php?file_id=7614&type=bug
png Selection_036.png (143,739) 2014-12-17 20:48
https://issues.openbravo.com/file_download.php?file_id=7617&type=bug
png

png Selection_035.png (125,895) 2014-12-17 20:48
https://issues.openbravo.com/file_download.php?file_id=7618&type=bug
png

? UseCreditIsNotProcessed (179,248) 2015-04-20 15:54
https://issues.openbravo.com/file_download.php?file_id=8007&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-11-28 16:49jecharriNew Issue
2014-11-28 16:49jecharriAssigned To => marvintm
2014-11-28 16:49jecharriOBNetwork customer => Yes
2014-11-28 16:49jecharriSupport ticket => 32636
2014-11-28 16:49jecharriResolution time => 1391814000
2014-11-28 16:49jecharriTriggers an Emergency Pack => No
2014-11-30 11:26mtaalResolution time1391814000 => 1423350000
2014-11-30 11:26mtaalAssigned Tomarvintm => szapata
2014-12-16 21:09hgbotCheckin
2014-12-16 21:09hgbotNote Added: 0072578
2014-12-16 21:09hgbotStatusnew => resolved
2014-12-16 21:09hgbotResolutionopen => fixed
2014-12-16 21:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b25b34637d6313dcd0c0794b8024a575c41a3633 [^]
2014-12-17 17:00mtaalRelationship addedhas duplicate 0023877
2014-12-17 18:50mtaalNote Added: 0072670
2014-12-17 18:50mtaalStatusresolved => new
2014-12-17 18:50mtaalResolutionfixed => open
2014-12-17 18:51mtaalFile Added: Selection_032.png
2014-12-17 18:51mtaalFile Added: Selection_031.png
2014-12-17 19:32mtaalNote Deleted: 0072670
2014-12-17 20:48mtaalFile Added: Selection_036.png
2014-12-17 20:48mtaalFile Added: Selection_035.png
2014-12-17 20:50mtaalNote Added: 0072680
2014-12-17 22:06hgbotCheckin
2014-12-17 22:06hgbotNote Added: 0072683
2014-12-17 22:06hgbotStatusnew => resolved
2014-12-17 22:06hgbotResolutionopen => fixed
2014-12-17 22:06hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b25b34637d6313dcd0c0794b8024a575c41a3633 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7b4c96123e6876660491bde496ca541fda2a096d [^]
2014-12-24 01:03mtaalReview Assigned To => mtaal
2014-12-24 01:03mtaalNote Added: 0072805
2014-12-24 01:03mtaalStatusresolved => closed
2014-12-24 01:03mtaalFixed in Version => RR15Q1
2015-04-20 15:52lorenzofidalgoNote Added: 0076636
2015-04-20 15:52lorenzofidalgoStatusclosed => new
2015-04-20 15:52lorenzofidalgoResolutionfixed => open
2015-04-20 15:52lorenzofidalgoFixed in VersionRR15Q1 =>
2015-04-20 15:52lorenzofidalgoRelationship addedrelated to 0029636
2015-04-20 15:54lorenzofidalgoFile Added: UseCreditIsNotProcessed
2015-04-20 16:10OrekariaRelationship addedblocks 0029396
2015-04-20 16:10OrekariaRelationship deletedblocks 0029396
2015-04-20 16:11OrekariaRelationship addedblocks 0029530
2015-04-20 16:42lorenzofidalgoRelationship addedrelated to 0028963
2015-04-24 15:50adrianromeroAssigned Toszapata => adrianromero
2015-04-24 15:59hgbotCheckin
2015-04-24 15:59hgbotNote Added: 0076760
2015-04-24 15:59hgbotStatusnew => resolved
2015-04-24 15:59hgbotResolutionopen => fixed
2015-04-24 15:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7b4c96123e6876660491bde496ca541fda2a096d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2f4858a9484e2e46b18462e26951f62b8f4cb01f [^]
2015-05-05 18:03malsasuaNote Added: 0077029
2015-05-05 18:03malsasuaStatusresolved => new
2015-05-05 18:03malsasuaResolutionfixed => open
2015-05-05 18:04malsasuaNote Edited: 0077029bug_revision_view_page.php?bugnote_id=0077029#r8449
2015-05-19 17:27hgbotCheckin
2015-05-19 17:27hgbotNote Added: 0077582
2015-05-19 17:27hgbotStatusnew => resolved
2015-05-19 17:27hgbotResolutionopen => fixed
2015-05-19 17:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2f4858a9484e2e46b18462e26951f62b8f4cb01f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bb8812553e4a5bda241dea034987fa83fd30b697 [^]
2015-05-19 17:38aaroncaleroAssigned Toadrianromero => aaroncalero
2015-06-01 13:06migueldejuanaReview Assigned Tomtaal => migueldejuana
2015-06-01 13:06migueldejuanaNote Added: 0077930
2015-06-01 13:06migueldejuanaStatusresolved => closed
2015-06-01 13:06migueldejuanaFixed in Version => RR15Q3
2015-07-22 10:27hgbotCheckin
2015-07-22 10:27hgbotNote Added: 0079021

Notes
(0072578)
hgbot   
2014-12-16 21:09   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b25b34637d6313dcd0c0794b8024a575c41a3633
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Tue Dec 16 17:08:03 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b25b34637d6313dcd0c0794b8024a575c41a3633 [^]

Fixed issue 28322: Show use credit for layaways

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0072680)
mtaal   
2014-12-17 20:50   
Issues found during testing:
1) if there is no credit to use the layaway button is shown too low
2) use credit button is also shown when the total amount is a return amount
3) when changing business partner the logic if the credit button should be shown should be recomputed, as the new bp can or can not be credit enabled
(0072683)
hgbot   
2014-12-17 22:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7b4c96123e6876660491bde496ca541fda2a096d
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Wed Dec 17 18:05:04 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7b4c96123e6876660491bde496ca541fda2a096d [^]

Fixed issue 28322: Show use credit for layaways, replace margin solution by clear right

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0072805)
mtaal   
2014-12-24 01:03   
Reviewed and tested
(0076636)
lorenzofidalgo   
2015-04-20 15:52   
It is still not possible to pay a Layaway receipt with credit.
Using "Use Credit" button in a receipt that is marked as Layaway does not process this receipt. It seems that is processed, but it still remains in "Layaways" section and it is not processed in POS backend.
(0076760)
hgbot   
2015-04-24 15:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2f4858a9484e2e46b18462e26951f62b8f4cb01f
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Apr 24 15:55:37 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2f4858a9484e2e46b18462e26951f62b8f4cb01f [^]

Fixes issue 0028322: Not possible to pay a layaway using credit
Changed OrderLoader to process properly layways paid with credit
* Invoice must be created
* Shipment must be created

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0077029)
malsasua   
2015-05-05 18:03   
(edited on: 2015-05-05 18:04)
when a layaway is paid partially by cash, and the rest of paid is done using credit, the invoice created is wrong:
it is marked as payment completed =Y, and the total paid is incorrect:
steps:
. create new receipt
. set as layaway
. amount 301
. paid total amount as layaway
. load the layaway created in first step
. pay it:
  . cash: 50
  . the rest of amount: using credit

. go to backoffice, check the invoice created:
 . payment complete: yes -->> it should be NO
 . total paid: 301 -->> it should be 50
 . payment plan:
   . received amount: 301 -->> it should be 50
(0077582)
hgbot   
2015-05-19 17:27   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bb8812553e4a5bda241dea034987fa83fd30b697
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue May 19 16:37:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bb8812553e4a5bda241dea034987fa83fd30b697 [^]

Fixed issue 28322: Not possible to pay a layaway using credit

The invoice won't be set as fully paid if there is a credit payment associated, and the 'total paid' amount will be set considering both the gross of the ticket and the amount paid with credit.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0077930)
migueldejuana   
2015-06-01 13:06   
Tested and reviewed in a5c25afa2d03
(0079021)
hgbot   
2015-07-22 10:27   
Repository: tools/automation/pi-mobile
Changeset: cc1d505f0a3a42972d73a3c94aecab4be8dc1d48
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue May 19 17:21:05 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/cc1d505f0a3a42972d73a3c94aecab4be8dc1d48 [^]

Verifies issue 28322: Added automated tests (I & II)

---
M src-test/org/openbravo/test/mobile/common/selenium/database/WebPOSDatabaseHelper.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I28322_WrongInvoiceWhenPayingLayawayWithCreditI.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I28322_WrongInvoiceWhenPayingLayawayWithCreditII.java
---