Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028283Openbravo ERP01. General setuppublic2014-11-26 06:562015-03-09 16:15
Reporterpramakrishnan 
Assigned Toaferraz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028283: API Change Request : Change DUNS field in Organization Information to Non Mandatory
DescriptionRelated to issue 0027313, D-U-N-S number should not be mandatory, because is something that is not used in all the goberments/companies. Now we are adding (in demo data, F&B) ? character when the number is not needed, but this does not make sense. If the field is not needed, it should be empty.

Risk Analysis:
The risk is minor because by default in trigger, the value for DUNS field is set as '?'. So in case some project is still using this, it will not be affected.
Steps To ReproduceD-U-N-S number should not be mandatory, because is something that is not used in all the goberments/companies. Now we are adding (in demo data, F&B) ? character when the number is not needed, but this does not make sense. If the field is not needed, it should be empty.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00273133.0PR15Q2 closed reinaldoguerra D-U-N-S number should not be mandatory 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-26 06:56pramakrishnanNew Issue
2014-11-26 06:56pramakrishnanAssigned To => dmitry_mezentsev
2014-11-26 06:56pramakrishnanModules => Core
2014-11-26 06:56pramakrishnanTriggers an Emergency Pack => No
2014-11-26 06:57pramakrishnanRelationship addedblocks 0027313
2014-11-26 10:58dmitry_mezentsevNote Added: 0072019
2015-03-05 11:18aferrazNote Added: 0075189
2015-03-06 10:57dmitry_mezentsevNote Added: 0075234
2015-03-06 10:58dmitry_mezentsevAssigned Todmitry_mezentsev => pramakrishnan
2015-03-09 11:11hgbotCheckin
2015-03-09 11:11hgbotNote Added: 0075304
2015-03-09 11:11hgbotStatusnew => resolved
2015-03-09 11:11hgbotResolutionopen => fixed
2015-03-09 11:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/bd976701a17f073d6d324aeac2450e7dfea2d18b [^]
2015-03-09 16:13SandrahuguetAssigned Topramakrishnan => aferraz
2015-03-09 16:15SandrahuguetReview Assigned To => Sandrahuguet
2015-03-09 16:15SandrahuguetNote Added: 0075320
2015-03-09 16:15SandrahuguetStatusresolved => closed
2015-03-09 16:15SandrahuguetFixed in Version => 3.0PR15Q2

Notes
(0072019)
dmitry_mezentsev   
2014-11-26 10:58   
Pandee,

>Risk Analysis:
>The risk is minor because by default in trigger, the value for DUNS field is >set as '?'. So in case some project is still using this, it will not be >affected.

Do we need this trigger then? I mean if we make this field not mandatory why to have a trigger that creates "useless" data. Only for backward compatibility? I would prefer to check if we use this field inside Openbravo and if we do not use it - most probably others won´t or at least should rise proper warning. Could you check it out please?

Btw you are talking about DUNS field but should we do the same for Tax ID? Could you explore it inside the team please?
(0075189)
aferraz   
2015-03-05 11:18   
Trigger will be modified to avoid set '?' to DUNS field.

We have reviewed all modules from the forge and there is no risk from any one.

TaxID field change will be more risky because it is used in models of "Professional Localization pack Spain".
(0075234)
dmitry_mezentsev   
2015-03-06 10:57   
>Trigger will be modified to avoid set '?' to DUNS field.
>We have reviewed all modules from the forge and there is no risk from any one.
OK, thanks, Approved.

>TaxID field change will be more risky because it is used in models of "Professional Localization pack Spain".
I still think that it makes sense to do it but because it is a different issue I reported it for the future, https://issues.openbravo.com/view.php?id=29167 [^]
(0075304)
hgbot   
2015-03-09 11:11   
Repository: erp/devel/api-checks
Changeset: bd976701a17f073d6d324aeac2450e7dfea2d18b
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Mar 09 11:02:27 2015 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/bd976701a17f073d6d324aeac2450e7dfea2d18b [^]

Fixes issue 28283: API Change Request DUNS field in AD_ORGINFO to non mandatory

---
M model/src-db/database/model/tables/AD_ORGINFO.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0075320)
Sandrahuguet   
2015-03-09 16:15   
Verified