Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028276Openbravo ERPA. Platformpublic2014-11-25 12:382014-12-30 23:26
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028276: testADataAccessLevel should not test HQL tables, as they don't have a physical database table
DescriptionThe AccessLevelTest.testADataAccessLevel tests if the current client/org of all tables in the database is valid for the access level defined for that entity. It does so my executing a query to the database table associated with the ad_table.

ad_tables based on manual datasources or on hql queries do not have database tables associated, so this test should not consider them. This was already working properly for ad_tables based on manual datasources, but not for datasources based on HQL tables.
Steps To ReproduceThis issue was discovered when the project that replaces P&E manual datasources with HQL-based tables was pushed to Try.
- Create an ad_table based on a HQL query. It should have a client column and an organization column.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-25 12:38AugustoMauchNew Issue
2014-11-25 12:38AugustoMauchAssigned To => AugustoMauch
2014-11-25 12:38AugustoMauchModules => Core
2014-11-25 12:38AugustoMauchTriggers an Emergency Pack => No
2014-11-25 12:38AugustoMauchIssue Monitored: Sandrahuguet
2014-11-25 12:38AugustoMauchReview Assigned To => Sandrahuguet
2014-11-25 12:40hgbotCheckin
2014-11-25 12:40hgbotNote Added: 0071976
2014-11-25 12:40hgbotStatusnew => resolved
2014-11-25 12:40hgbotResolutionopen => fixed
2014-11-25 12:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7d2529edd9001939d5c4a0ba122d70e7b386ec7c [^]
2014-12-01 08:41SandrahuguetNote Added: 0072172
2014-12-01 08:41SandrahuguetStatusresolved => closed
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073137

Notes
(0071976)
hgbot   
2014-11-25 12:40   
Repository: erp/devel/pi
Changeset: 7d2529edd9001939d5c4a0ba122d70e7b386ec7c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Nov 25 12:39:46 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7d2529edd9001939d5c4a0ba122d70e7b386ec7c [^]

Fixes issue 28276: AccessLevelTest does not take into account HQL based tables

The AccessLevelTest.testADataAccessLevel tests if the current client/org of all tables in the database is valid for the access level defined for that entity. It does so my executing a query to the database table associated with the ad_table.

ad_tables based on manual datasources or on hql queries do not have database tables associated, so this test should not consider them. This was already working properly for ad_tables based on manual datasources, but not for datasources based on HQL tables.

---
M src-test/src/org/openbravo/test/security/AccessLevelTest.java
---
(0072172)
Sandrahuguet   
2014-12-01 08:41   
Verified
(0073137)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test