Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028250Retail ModulesWeb POSpublic2014-11-21 16:162015-03-20 13:06
Reporteradrianromero 
Assigned Toadrianromero 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028250: During the process of closing a receipt UI remains responsive allowing to execute actions
DescriptionIf the process to close a receipt in Web POS takes few seconds because printer is not available or there are hooks that execute asynchronous actions, the done button is disabled but other buttons in the application remains active. Then the cashier can execute other actions before actually closing the receipt and wrong data can be created or the Web POS can be in an inconsistent state.
Steps To ReproduceJust close a receipt and try to execute other actions while the "Done" button is inactive
Proposed SolutionShow the "Loading" window that blocks all UI actions while the close receipt process is in execution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0028312 closed marvintm "Loading" window is hidden before than the receipt has been send to the backend 
blocks feature request 0029377RR15Q3 closed Orekaria Stabilization: RR15Q2 related 
causes defect 0029034 closed Orekaria The loading window is being shown when the ticket is closed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-21 16:16adrianromeroNew Issue
2014-11-21 16:16adrianromeroAssigned To => adrianromero
2014-11-21 16:16adrianromeroTriggers an Emergency Pack => No
2014-11-21 16:16adrianromeroReview Assigned To => malsasua
2014-11-21 16:20hgbotCheckin
2014-11-21 16:20hgbotNote Added: 0071897
2014-11-21 16:20hgbotStatusnew => resolved
2014-11-21 16:20hgbotResolutionopen => fixed
2014-11-21 16:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d536de1438c197bbcf90e8c8902b5fd2a9153a17 [^]
2014-12-01 10:52adrianromeroNote Added: 0072177
2014-12-01 10:52adrianromeroStatusresolved => new
2014-12-01 10:52adrianromeroResolutionfixed => open
2014-12-01 10:54malsasuaRelationship addedrelated to 0028312
2014-12-01 10:55malsasuaRelationship deletedrelated to 0028312
2014-12-01 10:55malsasuaRelationship addedhas duplicate 0028312
2014-12-01 18:32malsasuaStatusnew => scheduled
2014-12-01 18:32malsasuafix_in_branch => pi
2014-12-01 18:33malsasuaNote Added: 0072216
2014-12-01 18:33malsasuaStatusscheduled => resolved
2014-12-01 18:33malsasuaFixed in Version => RR15Q1
2014-12-01 18:33malsasuaResolutionopen => fixed
2014-12-09 17:05adrianromeroReview Assigned Tomalsasua => adrianromero
2014-12-09 17:05adrianromeroNote Added: 0072365
2014-12-09 17:05adrianromeroStatusresolved => closed
2015-02-23 19:20hgbotCheckin
2015-02-23 19:20hgbotNote Added: 0074820
2015-02-26 20:19dmitry_mezentsevRelationship addedcauses 0029034
2015-03-20 13:06hgbotCheckin
2015-03-20 13:06hgbotNote Added: 0075797
2015-03-23 18:07OrekariaRelationship addedblocks 0029377

Notes
(0071897)
hgbot   
2014-11-21 16:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d536de1438c197bbcf90e8c8902b5fd2a9153a17
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Nov 21 16:20:09 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d536de1438c197bbcf90e8c8902b5fd2a9153a17 [^]

Fixes issue 0028250: During the process of closing a receipt UI remains responsive allowing to execute actions
Showing the *loading* window while the closing receipt is executing

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0072177)
adrianromero   
2014-12-01 10:52   
Not properly fixed. Loading window disappears when showing an error, for example when hardware manager is not configured. It needs to be fixed.
(0072216)
malsasua   
2014-12-01 18:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4583a01d6acb310e81f30a6e25e3b2f29f9eb2ef
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon Dec 01 18:28:35 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4583a01d6acb310e81f30a6e25e3b2f29f9eb2ef [^] [^]

fixed issue 28312: the called to deleteCurrent function now is executed without wait to the callback to print

when the even 'print' is triggered, the called to deleteCurrent is executed immediatly, no is executed in the callback
To support it, the function 'print' use the parameter 'order', before it used the main receipt

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0072365)
adrianromero   
2014-12-09 17:05   
Verified.
(0074820)
hgbot   
2015-02-23 19:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3619f5ca8495f0ec7f54969cb6fa24a994092c96
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Feb 23 18:46:40 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3619f5ca8495f0ec7f54969cb6fa24a994092c96 [^]

Fixes issue 29034, Backed out changeset: d536de1438c1 of issue 28250: Loading window is shown when the receipt is closed

The problem was that the fix found for the causing issue was trying to fix receipt inconsistences when the user was trying to create a new order just after having finished a previous one and 2 changesets were introduced
The first changeset tried a work around (blocking the UI), but the second one tried to fix the real issue

Note: If the issue tried to fix in the causing issue referred by this issue arises again, a proper fix has to be found. Blocking the UI is not an option

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0075797)
hgbot   
2015-03-20 13:06   
Repository: retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal
Changeset: 39cb0e5c68e19de0f06c1149a048a0d83ea5c9e6
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Mar 20 13:06:36 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal/rev/39cb0e5c68e19de0f06c1149a048a0d83ea5c9e6 [^]

Fixes issue 29034, Backed out changeset: d536de1438c1 of issue 28250: Loading window is shown when the receipt is closed

The problem was that the fix found for the causing issue was trying to fix receipt inconsistences when the user was trying to create a new order just after having finished a previous one and 2 changesets were introduced
The first changeset tried a work around (blocking the UI), but the second one tried to fix the real issue

Note: If the issue tried to fix in the causing issue referred by this issue arises again, a proper fix has to be found. Blocking the UI is not an option

Note: Backport to RR15Q1.2

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---