Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0028246Openbravo ERPA. Platformpublic2014-11-21 12:182014-12-30 23:26
caristu 
AugustoMauch 
urgentmajoralways
closedfixed 
5
pi 
3.0PR15Q13.0PR15Q1 
Sandrahuguet
Core
No
0028246: Grids with display logics in Process Definitions are not automatically fetched
Having a Process Definition that has a Grid type parameter with a display logic
depending on the value of another parameter.

In this scenario, the grid data is never fetched automatically. If the grid is filtered by any field then a fetch is done and the data is shown.

The grid should be automatically fetched when it is displayed.
In Description
No tags attached.
Issue History
2014-11-21 12:18caristuNew Issue
2014-11-21 12:18caristuAssigned To => AugustoMauch
2014-11-21 12:18caristuModules => Core
2014-11-21 12:18caristuTriggers an Emergency Pack => No
2014-11-21 12:18caristuIssue Monitored: networkb
2014-11-21 12:18caristuversion => pi
2014-11-21 12:18caristuTarget Version => 3.0PR15Q1
2014-11-26 10:34AugustoMauchIssue Monitored: Sandrahuguet
2014-11-26 10:35AugustoMauchIssue End Monitor: Sandrahuguet
2014-11-26 10:35AugustoMauchIssue Monitored: Sandrahuguet
2014-11-26 10:35AugustoMauchReview Assigned To => Sandrahuguet
2014-11-26 10:36hgbotCheckin
2014-11-26 10:36hgbotNote Added: 0072017
2014-11-26 10:36hgbotStatusnew => resolved
2014-11-26 10:36hgbotResolutionopen => fixed
2014-11-26 10:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/757e2d4d064c8cdd1742e4de13b9c03dd6b26ebd [^]
2014-11-26 13:51hgbotCheckin
2014-11-26 13:51hgbotNote Added: 0072031
2014-12-01 12:06SandrahuguetNote Added: 0072182
2014-12-01 12:07SandrahuguetNote Added: 0072183
2014-12-01 12:07SandrahuguetStatusresolved => closed
2014-12-01 12:07SandrahuguetFixed in Version => 3.0PR15Q1
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073143
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073146
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073147

Notes
(0072017)
hgbot   
2014-11-26 10:36   
Repository: erp/devel/pi
Changeset: 757e2d4d064c8cdd1742e4de13b9c03dd6b26ebd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Nov 26 10:34:40 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/757e2d4d064c8cdd1742e4de13b9c03dd6b26ebd [^]

Fixes issue 28246: Grid parameters are loaded even if they have display logic

The problem was that the grid parameters were only being automatically loaded when they did not have display logic. If they had display logic the user had either to programatically load the grid, or change the grid filter editor.

To fix this, now it is detected when a grid is shown for the very first time (in that case its data property will not be a ResultSet, as it has not been loaded yet), and it is loaded then.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0072031)
hgbot   
2014-11-26 13:51   
Repository: erp/devel/pi
Changeset: 0bdb0cb683ede5d19d2b53d2f5695987de9388dd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Nov 26 13:38:02 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0bdb0cb683ede5d19d2b53d2f5695987de9388dd [^]

Related with bug 28246: Filter expression not reset after clearing the filters

The following problem has been detected while doing the QA for issue 28246: If a grid parameter has a display logic and a filter expression, then when the user clears the filter the filter expression will be momentarily removed, and then reset again.

This happened because there was some code that tried to guarantee that the grid was loaded the first time that is was made visible and that had the filter expression applied, but was not checking properly that the grid was not loaded yet. This resulted in reapplying the filter expression each time the grid is redrawn.

This has been fixed by checking properly if the grid has already loaded its data (in that case its data property will be an instance of ResultSet).

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0072182)
Sandrahuguet   
2014-12-01 12:06   
Test Plan:
-Go to Preference window and create new line for 'RM Allow Orphan Line' property with value 'Y'
-Go to Return to vendor, create a new header for F&B EspaƱa and click on Pick/Edit Lines button notice that only one grid appears.
-Close the popup
-Click on Insert Orphan line button and and complete the popup fields with these data:
  Product: Agua sin Gas 1L
  Returned: 10
  Unit Price:1
-Click again in Pick/Edit Lines button and notice that Orphan Lines grid is shown and having data
(0072183)
Sandrahuguet   
2014-12-01 12:07   
Verified
(0073143)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073146)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073147)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test