Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028234Openbravo ERP04. Warehouse managementpublic2014-11-20 10:162014-12-30 23:26
Reporterpsanjuan 
Assigned ToSandrahuguet 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028234: [Costing] Costing Rule validation process should check that the organization has a currency setup
Description[Costing] Costing Rule validation process should check that the organization has a currency setup, otherwise an error is shown.
Steps To ReproduceIn QA testing client make sure that USA organization does not have a currency defined.

Realize that Client base currency is EUR.

Create a costing rule for USA organization and validate it.

Create a product. Navigate to price tab and select a price list in USD. Enter a unit/price list of 150 USD.

Go to purchase order and create a new one for a USA Vendor. Make sure that USD price list gets selected.

Go to Lines tab, select the product and enter 1 unit. Price = 150 USD.
Book the order.

Go to Goods Receipt and create a new one for USA org and USA vendor. Select the order. Complete the receipt.

Go to Process Request and run costing background process.

Go back to the Goods Receipt and post it. Realize that the product asset amount posted to the ledger is 150.00 USD.

Go to product window, search the product. Navigate to costing tab.

Realize that the cost shown there is 60.00 EUR. That is not correct.
Proposed SolutionThere is one design changes to implement:

1) Costing rule process should verify that the organization has a currency setup, otherwise an error will be show. A costing rule can not be validated until the organization has a currency.


Additional Information
TagsNo tags attached.
Relationships
related to defect 0028230 closed Sandrahuguet [Costing] Null Pointer Exception is raised when trying to post a goods receipt 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-20 10:16psanjuanNew Issue
2014-11-20 10:16psanjuanAssigned To => dmiguelez
2014-11-20 10:16psanjuanModules => Core
2014-11-20 10:16psanjuanTriggers an Emergency Pack => No
2014-11-20 10:30psanjuanAssigned Todmiguelez => Sandrahuguet
2014-11-20 10:30psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7107#r7107
2014-11-20 10:42psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7108#r7108
2014-11-20 10:42psanjuanProposed Solution updated
2014-11-20 10:49psanjuanProposed Solution updated
2014-11-20 11:10aferrazRelationship addedrelated to 0028230
2014-12-01 10:56psanjuanProposed Solution updated
2014-12-04 18:19hgbotCheckin
2014-12-04 18:19hgbotNote Added: 0072287
2014-12-04 18:19hgbotStatusnew => resolved
2014-12-04 18:19hgbotResolutionopen => fixed
2014-12-04 18:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a363c29aeee3f27d0e8338f4eba2fc7f8e97d12c [^]
2014-12-05 14:47psanjuanNote Added: 0072315
2014-12-11 15:56SandrahuguetReview Assigned To => Sandrahuguet
2014-12-11 15:56SandrahuguetNote Added: 0072428
2014-12-11 15:56SandrahuguetStatusresolved => closed
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073174

Notes
(0072287)
hgbot   
2014-12-04 18:19   
Repository: erp/devel/pi
Changeset: a363c29aeee3f27d0e8338f4eba2fc7f8e97d12c
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Dec 04 13:09:42 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a363c29aeee3f27d0e8338f4eba2fc7f8e97d12c [^]

Fixes Issue 28234: Check in Costing Rule Validation that the org has Currency.

If the organization has no currency defined, the costing process will use the currency defined in the client. This could be wrong if the currency for the transactions of this organization should be different that the currency of the client, so before validating a costing rule the organization of it should have a currency defined.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/costing/CostingRuleProcess.java
---
(0072315)
psanjuan   
2014-12-05 14:47   
Verified.
(0072428)
Sandrahuguet   
2014-12-11 15:56   
Code review done
(0073174)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test