Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028231Openbravo ERPB. User interfacepublic2014-11-19 19:172016-10-24 10:06
Reportercaristu 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR15Q2Fixed in Version3.0PR15Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028231: Focus is placed automatically on the last field under some circumnstances
DescriptionFocus is placed automatically on the last field of a tab, if this tab has the scroll bar on the right and all its fields are in read-only.
Steps To ReproduceLogin as F&B Admin
1) Go to the [Unit of Measure] tab and increase the Translation tab enough to have scrolling on the header (See attached)
2) Access on any register in form mode. Notice that the screen scrolls down automatically to the last field.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034057 closed NaroaIriarte Wrong Tabulation Order in form fields in Organization window 
related to defect 00283963.0PR15Q2 closed AugustoMauch Focus is placed automatically on the field group (if any) having all the fields in read only mode 
Attached Filespng ScrolledDown.png (51,518) 2014-11-19 19:18
https://issues.openbravo.com/file_download.php?file_id=7531&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-11-19 19:17caristuNew Issue
2014-11-19 19:17caristuAssigned To => dbaz
2014-11-19 19:17caristuFile Added: ScrolledDown.png
2014-11-19 19:17caristuModules => Core
2014-11-19 19:17caristuResolution time => 1422831600
2014-11-19 19:17caristuTriggers an Emergency Pack => No
2014-11-19 19:18caristuFile Deleted: ScrolledDown.png
2014-11-19 19:18caristuFile Added: ScrolledDown.png
2014-11-19 19:18caristuversion => pi
2014-11-19 19:18caristuTarget Version => 3.0PR15Q1
2014-11-19 19:18caristuAssigned Todbaz => AugustoMauch
2014-11-19 19:18caristuIssue Monitored: networkb
2014-11-26 11:30AugustoMauchIssue Monitored: alostale
2014-11-26 11:30AugustoMauchReview Assigned To => alostale
2014-11-26 11:39hgbotCheckin
2014-11-26 11:39hgbotNote Added: 0072024
2014-11-26 11:39hgbotStatusnew => resolved
2014-11-26 11:39hgbotResolutionopen => fixed
2014-11-26 11:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a72704b89964c9dd369c422ccefeecca16e26551 [^]
2014-12-01 13:18alostaleNote Added: 0072191
2014-12-01 13:18alostaleStatusresolved => new
2014-12-01 13:18alostaleResolutionfixed => open
2014-12-01 13:38egoitzTarget Version3.0PR15Q1 => 3.0PR15Q2
2014-12-01 18:37hgbotCheckin
2014-12-01 18:37hgbotNote Added: 0072217
2014-12-01 18:37hgbotStatusnew => resolved
2014-12-01 18:37hgbotResolutionopen => fixed
2014-12-01 18:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a72704b89964c9dd369c422ccefeecca16e26551 [^] => http://code.openbravo.com/erp/devel/pi/rev/c523abe0e8115d406c7e2515be7aef9d5209ce73 [^]
2014-12-02 07:52alostaleNote Added: 0072222
2014-12-02 07:52alostaleStatusresolved => closed
2014-12-02 07:53alostaleFixed in Version => 3.0PR15Q1
2014-12-12 09:30caristuRelationship addedrelated to 0028396
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073144
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073160
2016-10-24 10:06NaroaIriarteRelationship addedrelated to 0034057

Notes
(0072024)
hgbot   
2014-11-26 11:39   
Repository: erp/devel/pi
Changeset: a72704b89964c9dd369c422ccefeecca16e26551
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Nov 26 11:38:42 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a72704b89964c9dd369c422ccefeecca16e26551 [^]

Fixes issue 28231: Form is not scrolled if it does not have any editable fields

The problem was that when switching from grid to form view, if the form view did not have any editable fields the focus would be placed in the first Audit field, and the scroll would be moved so that the Audit field is shown in the top of the screen. This would hide all the read only fields.

To fix this, when the switchFormGridVisibility is invoked it is detected if the focused item is an Audit field, and in that case the scroll is moved to the top so that the first batch of form fields is visible.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0072191)
alostale   
2014-12-01 13:18   
Reopening:

Works fine when navigating from grid to form view. But while in form view navigating to next/prev record the scrolling still occurs.
(0072217)
hgbot   
2014-12-01 18:37   
Repository: erp/devel/pi
Changeset: c523abe0e8115d406c7e2515be7aef9d5209ce73
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Dec 01 18:32:17 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c523abe0e8115d406c7e2515be7aef9d5209ce73 [^]

Fixes issue 28231: Form is not scrolled if it does not have any editable fields

There was a problem with the previous fix: it worked when a record was opened from the grid view to the form view, but then it did not work if the user moved to the previous or next record while in form view.

To fix this, the logic that handled the original problem has been moved from OBStandardView.switchFormGridVisibility function to the OBViewForm.setFocusInForm function. The flow goes through the latter function each time a new record is loaded. In particular the form has to be scrolled down only when the record in being initializaed in the form, that's why a flag has been added to ensure that the code is only executed when the setFocusInForm function is executed from within the retrieveInitialValues function.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0072222)
alostale   
2014-12-02 07:52   
code reviewed

tested navigating from grid to form and navigating to next/prev record in form
(0073144)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073160)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test