Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028215Retail ModulesWeb POSpublic2014-11-18 17:472014-12-08 22:46
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q1Fixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028215: Logout when data is not synchronized shows javascript errors
DescriptionIf we login and immediatly go logout before all data is synchronized we get javascript error (But still do the logout)
Steps To Reproduce- Login
- Before, products,customers... are loaded. Logout
- Javascript error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0028217 new Retail Stabilization: Create a basic API for the asynchronous calls 
related to feature request 0028218 new Retail Add group management to the SynchronizationHelper 
related to defect 0028873RR15Q2 closed migueldejuana Cash up is not working properly and success message can take minutes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-18 17:47migueldejuanaNew Issue
2014-11-18 17:47migueldejuanaAssigned To => migueldejuana
2014-11-18 17:47migueldejuanaTriggers an Emergency Pack => No
2014-11-18 17:54hgbotCheckin
2014-11-18 17:54hgbotNote Added: 0071788
2014-11-18 17:54hgbotStatusnew => resolved
2014-11-18 17:54hgbotResolutionopen => fixed
2014-11-18 17:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e3be6d0531275e491894085b7612374a13927034 [^]
2014-11-18 17:54hgbotCheckin
2014-11-18 17:54hgbotNote Added: 0071789
2014-11-18 17:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e3be6d0531275e491894085b7612374a13927034 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/371e6dd3134ab631d35fd8aeaea5e2f42c6e3249 [^]
2014-11-18 17:57migueldejuanaNote Added: 0071790
2014-11-18 18:02OrekariaRelationship addedrelated to 0028217
2014-11-18 18:06OrekariaRelationship addedrelated to 0028218
2014-11-21 08:47hgbotCheckin
2014-11-21 08:47hgbotNote Added: 0071867
2014-11-21 08:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/371e6dd3134ab631d35fd8aeaea5e2f42c6e3249 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/903f553657080fe9f0f0c566cf6b1d5e3508e091 [^]
2014-11-21 13:50hgbotCheckin
2014-11-21 13:50hgbotNote Added: 0071886
2014-11-21 13:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/903f553657080fe9f0f0c566cf6b1d5e3508e091 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/72e940d743a90d8c101c2559509b8df11c0ea8b3 [^]
2014-11-25 09:11hgbotCheckin
2014-11-25 09:11hgbotNote Added: 0071959
2014-11-28 19:46dmitry_mezentsevNote Added: 0072148
2014-12-08 22:46mtaalReview Assigned To => mtaal
2014-12-08 22:46mtaalNote Added: 0072336
2014-12-08 22:46mtaalStatusresolved => closed
2014-12-08 22:46mtaalFixed in Version => RR15Q1
2015-02-12 08:43migueldejuanaRelationship addedrelated to 0028873

Notes
(0071788)
hgbot   
2014-11-18 17:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e3be6d0531275e491894085b7612374a13927034
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Nov 18 17:50:01 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e3be6d0531275e491894085b7612374a13927034 [^]

Fixed issue 0028215: Logout when data is not synchronized shows javascript errors

If data synchronization is not complete. We cannot do logout untill is completed

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/component/dialog/ob-profile.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0071789)
hgbot   
2014-11-18 17:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 371e6dd3134ab631d35fd8aeaea5e2f42c6e3249
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Nov 18 17:53:20 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/371e6dd3134ab631d35fd8aeaea5e2f42c6e3249 [^]

Fixed issue 0028215: Logout when data is not synchronized shows javascript errors

Add more restriction to the logout.

---
M web/org.openbravo.mobile.core/source/component/dialog/ob-profile.js
---
(0071790)
migueldejuana   
2014-11-18 17:57   
We should improve the way we wait to data synchronization is completed. We should use Synchronization Helper to do this task.
(0071867)
hgbot   
2014-11-21 08:47   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 903f553657080fe9f0f0c566cf6b1d5e3508e091
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Nov 21 08:46:53 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/903f553657080fe9f0f0c566cf6b1d5e3508e091 [^]

Fixed issue 0028215: Logout when data is not synchronized shows javascript errors

We define by default the flag to true because not all the mobile applications sync data

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0071886)
hgbot   
2014-11-21 13:50   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 72e940d743a90d8c101c2559509b8df11c0ea8b3
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Fri Nov 21 13:49:48 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/72e940d743a90d8c101c2559509b8df11c0ea8b3 [^]

fixed issue 28215: var dataSynchronized is set to true in callback although errorCallback is null

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0071959)
hgbot   
2014-11-25 09:11   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ef111b2b4897be7ded91a75babed1a20b8cc7f6f
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Nov 25 09:11:08 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ef111b2b4897be7ded91a75babed1a20b8cc7f6f [^]

Related to issue 28215: 'dataSynchronized' is not set to false if there is nothing to synchronize

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0072148)
dmitry_mezentsev   
2014-11-28 19:46   
Not closed for 15 days!
(0072336)
mtaal   
2014-12-08 22:46   
Reviewed and tested