Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028169Openbravo ERPA. Platformpublic2014-11-13 18:362014-12-30 23:26
Reporterjecharri 
Assigned ToNaroaIriarte 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1Fixed in Version3.0PR15Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028169: Read only logic does not work with Image reference columns
DescriptionRead only logic does not work with Image reference columns
Steps To Reproduce-Login as system
-Go to "Windows, tabs and fields"
-Select the Product windiow
-Select the Header tab
-Mark image field as read only
-Login as Admin role
-Go to product window and verify that you can delete and insert new images
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028170 closed AugustoMauch Images are not deleted when you delete from the UI 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-13 18:36jecharriNew Issue
2014-11-13 18:36jecharriAssigned To => AugustoMauch
2014-11-13 18:36jecharriWeb browser => Google Chrome
2014-11-13 18:36jecharriModules => Core
2014-11-13 18:36jecharriResolution time => 1421708400
2014-11-13 18:36jecharriTriggers an Emergency Pack => No
2014-11-13 18:38jecharriIssue cloned0028170
2014-11-13 18:38jecharriRelationship addedrelated to 0028170
2014-11-20 09:32alostaleAssigned ToAugustoMauch => inigosanchez
2014-11-20 10:15AugustoMauchAssigned Toinigosanchez => NaroaIriarte
2014-11-20 10:16AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-11-20 10:16AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7105#r7105
2014-11-24 09:42hgbotCheckin
2014-11-24 09:42hgbotNote Added: 0071918
2014-11-24 09:42hgbotStatusnew => resolved
2014-11-24 09:42hgbotResolutionopen => fixed
2014-11-24 09:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/46e4ef62c01509bf71ef74d0338704f013e9e609 [^]
2014-11-24 09:43alostaleReview Assigned To => alostale
2014-11-24 09:43alostaleNote Added: 0071919
2014-11-24 09:43alostaleStatusresolved => closed
2014-11-24 09:43alostaleFixed in Version => 3.0PR15Q1
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073126

Notes
(0071918)
hgbot   
2014-11-24 09:42   
Repository: erp/devel/pi
Changeset: 46e4ef62c01509bf71ef74d0338704f013e9e609
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Nov 24 08:56:16 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/46e4ef62c01509bf71ef74d0338704f013e9e609 [^]

Fixed issue 28169: readOnly and readOnly logic fails in images.

In image fields it did not work readOnly property nor readOnly logic. When readOnly was chosen in the image field, it was possible
to delete or upload it. When readOnly logic was active it was possible to do both things too.
The problem was in the ob-formitem-image.js.
For fixing the first problem I have changed the word "readOnly" for "disabled" in a condition, because the logic was not taken well before.
Now, when the checkbox readOnly is chosen, it is not possible to delete nor upload an image, as expected.
For fixing the second problem I have overwritten the "setDisbaled" function in this subclass. Now, when an obect is set as disabled, the delete and upload
buttons will be hidden, so, when an image is set as readOnly whit a readOnly logic condition, now those buttons are not visible.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
---
(0071919)
alostale   
2014-11-24 09:43   
code reviewed

tested:
-Field is set as read only
-Read only logic on the field
-Tab is set as read only
(0073126)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test