Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028168Retail ModulesWeb POSpublic2014-11-13 17:222014-12-03 17:25
Reporteradrianromero 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028168: When paying with a different currency the server side is calculating the amount again
DescriptionThe OrderLoader class is calculating again the original amount based on the amount when it is already done in the client side. This must be taken from the amount field, otherwise it may create rounding errors in the payment records.
Steps To ReproduceCreate a receipt in the POS and pay with a foreign currency. Verify in the server side that sometimes there is a rounding error in the payments made with the foreign currency
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028044RR15Q1 closed mario_castello Change is not properly calculated when the conversion rates are really bigs 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-13 17:22adrianromeroNew Issue
2014-11-13 17:22adrianromeroAssigned To => adrianromero
2014-11-13 17:22adrianromeroTriggers an Emergency Pack => No
2014-11-13 17:22adrianromeroRelationship addedrelated to 0028044
2014-11-13 17:28hgbotCheckin
2014-11-13 17:28hgbotNote Added: 0071641
2014-11-13 17:28hgbotStatusnew => resolved
2014-11-13 17:28hgbotResolutionopen => fixed
2014-11-13 17:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f32a26ec2c5eea42f113a9b9ed47e999327bf611 [^]
2014-11-18 09:27adrianromeroAssigned Toadrianromero => marvintm
2014-11-28 19:43dmitry_mezentsevNote Added: 0072145
2014-12-03 17:25mtaalReview Assigned To => mtaal
2014-12-03 17:25mtaalNote Added: 0072266
2014-12-03 17:25mtaalStatusresolved => closed
2014-12-03 17:25mtaalFixed in Version => RR15Q1

Notes
(0071641)
hgbot   
2014-11-13 17:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f32a26ec2c5eea42f113a9b9ed47e999327bf611
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Nov 13 17:28:22 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f32a26ec2c5eea42f113a9b9ed47e999327bf611 [^]

Fixes issue 28168: When paying with a different currency the server side is calculating the amount again
Instead of calculating the amount again we use the field *amount* that comes in the JSON payment

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0072145)
dmitry_mezentsev   
2014-11-28 19:43   
Not closed for 15 days!
(0072266)
mtaal   
2014-12-03 17:25   
Reviewed and tested