Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0028167Openbravo ERP03. Procurement managementpublic2014-11-13 10:102015-02-04 20:34
ngarcia 
fsoto82 
highminoralways
closedfixed 
5
 
3.0PR15Q2pi 
umartirena
Core
No
0028167: Error message shown when trying to create a purchase order from a requisition without a valid tax should be improved
Error message shown when trying to create a purchase order from a requisition without a valid tax should be improved
As group admin role:
   Create a Tax Category
   Create a Product, assign that Tax Category and a purchase price
   Check there is not any Tax Rate set as Default (change it to Default = 'N' in case it exists)
   Create a Requisition with that product and complete it
   Go to Requisition to Order window and process the requisition
   Check the following message is raised:
      No tax defined for line 10 to requisition number: 10000000
   Go to Manage Requisitions window and try to Create Purchase Order from it
   Check the message is the following:
      null value in column "c_tax_id" violates not-null constraint
   
No tags attached.
Issue History
2014-11-13 10:10ngarciaNew Issue
2014-11-13 10:10ngarciaAssigned To => AtulOpenbravo
2014-11-13 10:10ngarciaModules => Core
2014-11-13 10:10ngarciaResolution time => 1422313200
2014-11-13 10:10ngarciaTriggers an Emergency Pack => No
2014-11-13 10:10ngarciaIssue Monitored: networkb
2014-12-01 13:39egoitzTarget Version3.0PR15Q1 => 3.0PR15Q2
2014-12-05 16:22fsoto82Statusnew => scheduled
2014-12-05 16:22fsoto82Assigned ToAtulOpenbravo => fsoto82
2014-12-05 16:22fsoto82fix_in_branch => pi
2015-01-12 15:09fsoto82Note Added: 0073428
2015-01-15 19:23hgbotCheckin
2015-01-15 19:23hgbotNote Added: 0073555
2015-01-15 19:23hgbotStatusscheduled => resolved
2015-01-15 19:23hgbotResolutionopen => fixed
2015-01-15 19:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aa779db8fcd7ab4f2de3d1e40b92503e536d3cde [^]
2015-01-15 19:24umartirenaReview Assigned To => umartirena
2015-01-15 19:24umartirenaNote Added: 0073556
2015-01-15 19:24umartirenaStatusresolved => closed
2015-01-15 19:24umartirenaFixed in Version => pi
2015-02-04 20:34hudsonbotCheckin
2015-02-04 20:34hudsonbotNote Added: 0074150

Notes
(0073428)
fsoto82   
2015-01-12 15:09   
As group admin role:
   Create a Tax Category
   Create a Product, assign that Tax Category and a purchase price
   Check there is not any Tax Rate set as Default (change it to Default = 'N' in case it exists)
   Create a Requisition with that product and complete it
   Go to Requisition to Order window and process the requisition
   Check the following message is raised:
      No tax defined for line 10 to requisition number: 10000000
   Go to Manage Requisitions window and try to Create Purchase Order from it
   Check the message is the following: "Invalid Tax. Please define a default Tax Category."
(0073555)
hgbot   
2015-01-15 19:23   
Repository: erp/devel/pi
Changeset: aa779db8fcd7ab4f2de3d1e40b92503e536d3cde
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Jan 15 19:22:35 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aa779db8fcd7ab4f2de3d1e40b92503e536d3cde [^]

Fixed bug 28167: Improved msg for Create PO from a requisition with invalid tax

Changed M_REQUISITION_CREATEPO to chech for a existing tax, if not found, a new error message (NoTaxDefinedForRequisitionLine) is shown.

---
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0073556)
umartirena   
2015-01-15 19:24   
The issue has been fixed by Fernando.

Code Review + Testing OK
(0074150)
hudsonbot   
2015-02-04 20:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test