Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028149Openbravo ERPA. Platformpublic2014-11-12 10:152017-01-24 16:30
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028149: update.database tries to delete pg_stat_statments and pg_stat_statments_reset
Descriptionpg_stat_statments and pg_stat_statments_reset functions are tried to be deleted by update.database
Steps To Reproduce* Enable pg_stat_statments: http://wiki.openbravo.com/wiki/Finding_Perfomance_Issues#Tracking_SQL_Statements [^]
* run update.database. This appears in the logs:

     [java] 65011 WARN - SQL Command failed with: ERROR: cannot drop function pg_stat_statements_reset() because extension pg_stat_statements requires it
     [java] Hint: You can drop extension pg_stat_statements instead.
     [java] 65033 WARN - -- END
     [java] -- -----------------------------------------------------------------------
     [java] -- FUNCTION PG_STAT_STATEMENTS_RESET
     [java] -- -----------------------------------------------------------------------
     [java] DROP FUNCTION PG_STAT_STATEMENTS_RESET()
     [java] 65049 WARN - SQL Command failed with: ERROR: cannot drop function pg_stat_statements() because extension pg_stat_statements requires it
     [java] Hint: You can drop extension pg_stat_statements instead.
     [java] 65064 WARN - -- END
     [java] -- -----------------------------------------------------------------------
     [java] -- FUNCTION PG_STAT_STATEMENTS
     [java] -- -----------------------------------------------------------------------
     [java] DROP FUNCTION PG_STAT_STATEMENTS(userid OUT OID, dbid OUT OID, query OUT TEXT, calls OUT VARCHAR, total_time OUT VARCHAR, rows OUT VARCHAR, shared_blks_hit OUT VARCHAR, shared_blks_read OUT VARCHAR, shared_blks_dirtied OUT VARCHAR, shared_blks_written OUT VARCHAR, local_blks_hit OUT VARCHAR, local_blks_read OUT VARCHAR, local_blks_dirtied OUT VARCHAR, local_blks_written OUT VARCHAR, temp_blks_read OUT VARCHAR, temp_blks_written OUT VARCHAR, blk_read_time OUT VARCHAR, blk_write_time OUT VARCHAR)
     [java] 65080 WARN - SQL Command failed with: ERROR: function createorders(character varying, character varying, character varying, character varying, character varying, character varying) does not exist
     [java] 65125 WARN - -- END
Proposed SolutionThese are internal pg functions which should be skipped.
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0031685 closed AugustoMauch Allow using SQL wildcards in the dbsourmanager exclude filter 
has duplicate design defect 0029799 closed Triage Platform Base Exclude from model some postgresql tables 
related to feature request 0036089 acknowledged Triage Platform Base exclude from updates all DB objects created by extensions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-12 10:15alostaleNew Issue
2014-11-12 10:15alostaleAssigned To => inigosanchez
2014-11-12 10:15alostaleModules => Core
2014-11-12 10:15alostaleTriggers an Emergency Pack => No
2015-03-11 11:10alostalePrioritynormal => high
2015-03-11 11:10alostaleStatusnew => acknowledged
2015-03-17 14:37alostaleAssigned Toinigosanchez => platform
2015-11-11 11:37alostalePriorityhigh => normal
2016-12-15 09:12alostaleAssigned Toplatform => alostale
2016-12-15 09:13alostaleReview Assigned To => caristu
2016-12-15 09:13alostaleRelationship addedrelated to 0031685
2016-12-15 09:17hgbotCheckin
2016-12-15 09:17hgbotNote Added: 0092399
2016-12-15 09:17hgbotStatusacknowledged => resolved
2016-12-15 09:17hgbotResolutionopen => fixed
2016-12-15 09:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/85b09d433e7f9c1e5816c4c2663c31a39570c371 [^]
2016-12-15 09:18alostaleNote Added: 0092400
2016-12-16 08:38caristuNote Added: 0092430
2016-12-16 08:38caristuStatusresolved => closed
2016-12-16 08:38caristuFixed in Version => 3.0PR17Q1
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092718
2017-01-24 16:30alostaleRelationship replaceddepends on 0031685
2017-05-24 15:16alostaleRelationship addedrelated to 0036089
2023-07-17 11:08shuehnerRelationship addedhas duplicate 0029799

Notes
(0092399)
hgbot   
2016-12-15 09:17   
Repository: erp/devel/pi
Changeset: 85b09d433e7f9c1e5816c4c2663c31a39570c371
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Dec 15 09:15:56 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/85b09d433e7f9c1e5816c4c2663c31a39570c371 [^]

fixed bug 28149: PG extension functions are tried to be deleted on update DB

  Having some installed any PG extension that adds functions, they are tried to
  be deleted each time update.database is executed.

  Fixed by excluding any function named like PG_% which should be reserved for
  PG extension functions.

---
M src-db/database/model/excludeFilter.xml
---
(0092400)
alostale   
2016-12-15 09:18   
A fake module to reserve DB prefixes has been registered [1]. Currently including PG to prevent any other module to reserve it.

[1] http://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/ForgeModuleDetail/Reserved-DB-Prefixes [^]
(0092430)
caristu   
2016-12-16 08:38   
Code review + testing OK: functions whose name starts with PG_ are now excluded during update.database.
(0092718)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test