Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028134Retail ModulesWeb POSpublic2014-11-10 17:212015-02-27 13:46
Reporterjecharri 
Assigned Tomigueldejuana 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q2Fixed in VersionRR15Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028134: Remove error 401 when you do the login and it is not possible to recover a session
DescriptionRemove error 401 when you do the login and it is not possible to recover a session
Steps To Reproduce-open developer tools
-go to Web POS

Verify that you will receive the error of the image
Proposed SolutionAvoid 401 error
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Captura de pantalla 2014-11-10 a las 9.19.08.png (34,163) 2014-11-10 17:21
https://issues.openbravo.com/file_download.php?file_id=7496&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-11-10 17:21jecharriNew Issue
2014-11-10 17:21jecharriAssigned To => marvintm
2014-11-10 17:21jecharriFile Added: Captura de pantalla 2014-11-10 a las 9.19.08.png
2014-11-10 17:21jecharriResolution time => 1421708400
2014-11-10 17:21jecharriTriggers an Emergency Pack => No
2014-11-10 21:35jecharriProposed Solution updated
2014-11-11 17:47jecharriNote Added: 0071563
2014-12-08 11:48mtaalTarget VersionRR15Q1 => RR15Q2
2015-01-15 11:45mtaalNote Added: 0073513
2015-01-15 11:45mtaalStatusnew => feedback
2015-02-03 16:10marvintmStatusfeedback => scheduled
2015-02-03 16:10marvintmNote Added: 0074034
2015-02-03 16:10marvintmfix_in_branch => pi
2015-02-09 10:28hgbotCheckin
2015-02-09 10:28hgbotNote Added: 0074273
2015-02-09 10:28hgbotStatusscheduled => resolved
2015-02-09 10:28hgbotResolutionopen => fixed
2015-02-09 10:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5fcb45743bb71b5b8546461587b7eaf0f79d774a [^]
2015-02-09 10:31hgbotCheckin
2015-02-09 10:31hgbotNote Added: 0074274
2015-02-09 10:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5fcb45743bb71b5b8546461587b7eaf0f79d774a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9dcf41dc5f8173cdfa146d85f9aaad83e58513d [^]
2015-02-09 18:10migueldejuanaAssigned Tomarvintm => migueldejuana
2015-02-09 18:18hgbotCheckin
2015-02-09 18:18hgbotNote Added: 0074290
2015-02-09 18:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9dcf41dc5f8173cdfa146d85f9aaad83e58513d [^] => http://code.openbravo.com/erp/devel/pi/rev/73a05f67730fcbbd254d14c42e95659e90a88d03 [^]
2015-02-09 18:19hgbotCheckin
2015-02-09 18:19hgbotNote Added: 0074291
2015-02-09 18:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/73a05f67730fcbbd254d14c42e95659e90a88d03 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/566fe2527f92643de45c2db43b9dcb2ca71da1fe [^]
2015-02-10 19:35hudsonbotCheckin
2015-02-10 19:35hudsonbotNote Added: 0074340
2015-02-26 17:35dmitry_mezentsevNote Added: 0074982
2015-02-27 13:46marvintmReview Assigned To => marvintm
2015-02-27 13:46marvintmStatusresolved => closed
2015-02-27 13:46marvintmFixed in Version => RR15Q2

Notes
(0071563)
jecharri   
2014-11-11 17:47   
Solution of this issue should be solved modifying the request to avoid to end in error 401.
(0073513)
mtaal   
2015-01-15 11:45   
Hi Javier,
I looked at this, but 401 is a valid response to an unauthorized request.

What is the issue/problem here?

gr. Martin
(0074034)
marvintm   
2015-02-03 16:10   
This issue was created due to the fact that this request creates noise when analyzing the Web POS data via APPDynamics.

The solution is to replace the Context class by a class which is not secured, make it respond with an error in case there is no valid session for that cookie, and modify the response callback so that it reads the error and acts appropriately.
(0074273)
hgbot   
2015-02-09 10:28   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5fcb45743bb71b5b8546461587b7eaf0f79d774a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 09 10:28:15 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5fcb45743bb71b5b8546461587b7eaf0f79d774a [^]

Fixed issue 0028134: Remove error 401 when you do the login and it is not possible to recover a session

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src/org/openbravo/mobile/core/login/Context.java
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0074274)
hgbot   
2015-02-09 10:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d9dcf41dc5f8173cdfa146d85f9aaad83e58513d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 09 10:08:36 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9dcf41dc5f8173cdfa146d85f9aaad83e58513d [^]

Fixed issue 0028134: Remove error 401 when you do the login and it is not possible to recover a session

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0074290)
hgbot   
2015-02-09 18:18   
Repository: erp/devel/pi
Changeset: 73a05f67730fcbbd254d14c42e95659e90a88d03
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 09 18:17:21 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/73a05f67730fcbbd254d14c42e95659e90a88d03 [^]

Fixed issue 0028134: Remove error 401 when you do the login and it is not possible to recover a session

Override sendRedirect method in order to avoid changing the original response

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/servlet/CalloutHttpServletResponse.java
---
(0074291)
hgbot   
2015-02-09 18:19   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 566fe2527f92643de45c2db43b9dcb2ca71da1fe
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 09 18:18:54 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/566fe2527f92643de45c2db43b9dcb2ca71da1fe [^]

Fixed issue 0028134: Remove error 401 when you do the login and it is not possible to recover a session

---
M src/org/openbravo/mobile/core/login/Context.java
---
(0074340)
hudsonbot   
2015-02-10 19:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/24bb109056f1 [^]
Maturity status: Test
(0074982)
dmitry_mezentsev   
2015-02-26 17:35   
Not closed for 17 days!