Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028100Retail ModulesReturn Receiptpublic2014-11-05 18:512014-11-17 10:01
Reportersureshbabu 
Assigned ToOrekaria 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression levelQA functional test
Regression date
Regression introduced in releaseRR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12279adf5f5e [^]
Triggers an Emergency PackNo
Summary0028100: [RR14Q4] Discretionary discounts not applied in Return receipts
DescriptionDiscretionary discounts not applied in Return receipts
Steps To Reproduce1) create a receipt with any product

2) From menu option select the option "Return this receipt" and verify "To be returned" label appears in the webpos

3) Then from menu option, select "Receipt Discounts" and select discount type
 "disc_fixed_5_euro-5 EUR" and select both the options
"Override existing promotions"
"Apply to all lines"
and then click "Apply" button

4) verify discount properly applied to line items

Defect: Discount not applied to line items

Note: This feature working fine in Q2.4 but not in Q3.1 & Q4 instances.(regression)


Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028120RR14Q3.1 closed malsasua Discounts related to packs are not properly related to order lines when sharing products 
related to defect 0028164 closed migueldejuana discount is removed when exists other line negative 
Attached Filespng Discretionary discounts not applied in Return receipts..png (205,532) 2014-11-05 18:51
https://issues.openbravo.com/file_download.php?file_id=7484&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-11-05 18:51sureshbabuNew Issue
2014-11-05 18:51sureshbabuAssigned To => marvintm
2014-11-05 18:51sureshbabuFile Added: Discretionary discounts not applied in Return receipts..png
2014-11-05 18:51sureshbabuOBNetwork customer => No
2014-11-05 18:51sureshbabuRegression level => QA functional test
2014-11-05 18:51sureshbabuTriggers an Emergency Pack => No
2014-11-10 19:34hgbotCheckin
2014-11-10 19:34hgbotNote Added: 0071535
2014-11-10 19:34hgbotStatusnew => resolved
2014-11-10 19:34hgbotResolutionopen => fixed
2014-11-10 19:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9555157cc1532b9fb8992c1edda7673d7a3d9b5 [^]
2014-11-10 19:35OrekariaReview Assigned To => malsasua
2014-11-10 19:38hgbotCheckin
2014-11-10 19:38hgbotNote Added: 0071536
2014-11-11 11:20hgbotCheckin
2014-11-11 11:20hgbotNote Added: 0071550
2014-11-12 12:36hgbotCheckin
2014-11-12 12:36hgbotNote Added: 0071603
2014-11-12 12:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9555157cc1532b9fb8992c1edda7673d7a3d9b5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1f64251bb0eaa7361809845856bf586dac5b902 [^]
2014-11-14 09:10OrekariaAssigned Tomarvintm => malsasua
2014-11-14 09:10OrekariaNote Added: 0071648
2014-11-14 09:10OrekariaStatusresolved => new
2014-11-14 09:10OrekariaResolutionfixed => open
2014-11-14 09:10OrekariaRelationship addedrelated to 0028120
2014-11-14 09:11OrekariaRelationship addedrelated to 0028164
2014-11-14 10:28hgbotCheckin
2014-11-14 10:28hgbotNote Added: 0071649
2014-11-14 10:28hgbotStatusnew => resolved
2014-11-14 10:28hgbotResolutionopen => fixed
2014-11-14 10:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1f64251bb0eaa7361809845856bf586dac5b902 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cc155abbf2c8e770f29bb588ec5fdd581ac13f87 [^]
2014-11-14 11:08migueldejuanaReview Assigned Tomalsasua => migueldejuana
2014-11-14 11:08migueldejuanaNote Added: 0071652
2014-11-14 11:08migueldejuanaStatusresolved => closed
2014-11-17 09:45OrekariaAssigned Tomalsasua => Orekaria
2014-11-17 09:45OrekariaStatusclosed => new
2014-11-17 09:45OrekariaResolutionfixed => open
2014-11-17 09:53OrekariaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12279adf5f5e [^]
2014-11-17 10:00OrekariaRegression introduced in release => RR14Q3
2014-11-17 10:00OrekariaStatusnew => scheduled
2014-11-17 10:00Orekariafix_in_branch => pi
2014-11-17 10:00OrekariaStatusscheduled => resolved
2014-11-17 10:00OrekariaFixed in Version => RR15Q1
2014-11-17 10:00OrekariaResolutionopen => fixed
2014-11-17 10:01OrekariaStatusresolved => closed

Notes
(0071535)
hgbot   
2014-11-10 19:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d9555157cc1532b9fb8992c1edda7673d7a3d9b5
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Nov 10 19:34:11 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9555157cc1532b9fb8992c1edda7673d7a3d9b5 [^]

Fixes issue 28100: Promotions that do not modify line quantities are correctly applied
- surrounded method has been depackaged

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0071536)
hgbot   
2014-11-10 19:38   
Repository: tools/automation/pi-mobile
Changeset: 6d0d32d5194d51a68e490c401a0e866240265b96
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Nov 10 19:37:35 2014 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6d0d32d5194d51a68e490c401a0e866240265b96 [^]

Related to issue 28100: Added 3 tests

---
M src-test/org/openbravo/retail/standard/automation/common/javascript/IdTest.java
M src-test/org/openbravo/retail/standard/automation/suites/DiscountsAndPromotionsSuite.java
A src-test/org/openbravo/retail/standard/automation/level20/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesI.java
A src-test/org/openbravo/retail/standard/automation/level20/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesII.java
A src-test/org/openbravo/retail/standard/automation/level20/discountsandpromotions/ReceiptDiscount.java
---
(0071550)
hgbot   
2014-11-11 11:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cd779c990937aed740c89d37fa4ab4d99d20dcca
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Nov 11 11:19:32 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cd779c990937aed740c89d37fa4ab4d99d20dcca [^]

Related to issue 28100: Beautifier

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0071603)
hgbot   
2014-11-12 12:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e1f64251bb0eaa7361809845856bf586dac5b902
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Wed Nov 12 12:35:32 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1f64251bb0eaa7361809845856bf586dac5b902 [^]

fixed issue 28100:fillPromotionsWith: promotions will be applied to the lines with the same qty sign from group order to original receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0071648)
Orekaria   
2014-11-14 09:10   
Math.sign not compatible with Safari
(0071649)
hgbot   
2014-11-14 10:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cc155abbf2c8e770f29bb588ec5fdd581ac13f87
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Nov 14 09:59:25 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cc155abbf2c8e770f29bb588ec5fdd581ac13f87 [^]

Fixes issue 28100: Math.sign is a ECMAScript 6 experimental function. A method has been introduced to replicate the method

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0071652)
migueldejuana   
2014-11-14 11:08   
Tested and reviewed in 2930de98c063