Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028099Openbravo ERPA. Platformpublic2014-11-05 18:162014-12-30 23:24
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1Fixed in Version3.0PR15Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-12-16
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/a03e8e035119 [^]
Triggers an Emergency PackNo
Summary0028099: Dot separated date format is not working
DescriptionDot separated date format is not working
Steps To ReproduceChange in the Openbravo.properties file the '-' by '.' for:

dateFormat.js
dateFormat.java
dateTimeFormat.java

ant compile.complete.deploy

As group admin role:
   Open Sales Invoice window
   Select an Invoice Date through the Calendar
   Check the field remains empty
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0025574 closed dbaz Upgrade SmartClient 10.0d 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-05 18:16ngarciaNew Issue
2014-11-05 18:16ngarciaAssigned To => AugustoMauch
2014-11-05 18:16ngarciaModules => Core
2014-11-05 18:16ngarciaResolution time => 1421794800
2014-11-05 18:16ngarciaTriggers an Emergency Pack => No
2014-11-05 18:17ngarciaIssue Monitored: networkb
2014-11-06 10:38ngarciaRegression level => Production - Confirmed Stable
2014-11-06 10:38ngarciaPriorityhigh => immediate
2014-11-06 17:26AugustoMauchRegression date => 2013-12-16
2014-11-06 17:26AugustoMauchRegression introduced in release => 3.0PR14Q2
2014-11-06 17:26AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/a03e8e035119 [^]
2014-11-06 17:54AugustoMauchIssue Monitored: alostale
2014-11-06 17:54AugustoMauchReview Assigned To => alostale
2014-11-06 17:55hgbotCheckin
2014-11-06 17:55hgbotNote Added: 0071468
2014-11-06 17:55hgbotStatusnew => resolved
2014-11-06 17:55hgbotResolutionopen => fixed
2014-11-06 17:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7fe38ad774a2d0db833ef7e9f4de01ca4ec315ac [^]
2014-11-06 17:56AugustoMauchStatusresolved => new
2014-11-06 17:56AugustoMauchResolutionfixed => open
2014-11-06 17:57AugustoMauchStatusnew => scheduled
2014-11-06 17:57AugustoMauchfix_in_branch => pi
2014-11-06 17:57AugustoMauchStatusscheduled => resolved
2014-11-06 17:57AugustoMauchResolutionopen => fixed
2014-11-06 18:21AugustoMauchNote Added: 0071470
2014-11-07 08:38alostaleStatusresolved => new
2014-11-07 08:38alostaleResolutionfixed => open
2014-11-07 08:38alostaleRelationship addedcaused by 0025574
2014-11-07 08:39alostaleStatusnew => scheduled
2014-11-07 08:39alostaleStatusscheduled => resolved
2014-11-07 08:39alostaleResolutionopen => fixed
2014-11-10 08:54alostaleNote Added: 0071509
2014-11-10 08:54alostaleStatusresolved => closed
2014-11-10 08:54alostaleFixed in Version => 3.0PR15Q1
2014-12-30 23:24hudsonbotCheckin
2014-12-30 23:24hudsonbotNote Added: 0073024

Notes
(0071468)
hgbot   
2014-11-06 17:55   
Repository: erp/devel/pi
Changeset: 7fe38ad774a2d0db833ef7e9f4de01ca4ec315ac
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Nov 06 17:53:38 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7fe38ad774a2d0db833ef7e9f4de01ca4ec315ac [^]

Fixes issue 28099: '.' works as date separator

If a dot was used as date separator, the dates were shown empty in the UI. This was caused by this implementation of the isSeparator function:

  isSeparator: function (str, position) {
    return str.charAt(position) === '-' || str.charAt(position) === '\\' || str.charAt(position) === '/';
  },

The list of possible separators was hardcoded, and it did not take into the account the dot. This has been fixed by also checking the value returned by the OB.Utilities.Date.getDateSeparator function, that given a date format it returns its separator.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js
---
(0071470)
AugustoMauch   
2014-11-06 18:21   
Test case created in test link: Communit-7897:28099: Dot separated date format is not working
(0071509)
alostale   
2014-11-10 08:53   
Tested with for the following cases.


Separators: - and . for date, date-time, absolute date and absolute date-time. In form and in date filter selector:

typing 1 --> converts to 1st of current month (1-11-2014)
typing 1-12 (when having . as separator, both 1.12 and 1-12 work)--> converts to 1-12 of current year (1-12-2014)
typing 1-12-2014 (when having . as separator, both 1.12.2014 and 1-12-2014 work)--> keeps selected date (1-12-2014)
select date from calendar widget

In date filter selector:
Using popup to select from-to dates
(0073024)
hudsonbot   
2014-12-30 23:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test