Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028095Openbravo ERPA. Platformpublic2014-11-05 17:252014-12-30 23:26
Reporternaiaramartinez 
Assigned Toaaroncalero 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q1.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028095: Modularize filters in Discounts and Promotions to be able to add filters from modules
DescriptionModularize filters in Discounts and Promotions to be able to add filters from modules.
Steps To ReproduceModularize filters in Discounts and Promotions to be able to add filters from modules.
Proposed SolutionProposed Solution attached in file ModularizeDiscountsAndPromotions.diff
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff ModularizeDiscountsAndPromotions.diff (9,521) 2014-11-13 17:01
https://issues.openbravo.com/file_download.php?file_id=7509&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-11-05 17:25naiaramartinezNew Issue
2014-11-05 17:25naiaramartinezAssigned To => ioritzCia
2014-11-05 17:25naiaramartinezOBNetwork customer => No
2014-11-05 17:25naiaramartinezModules => Core
2014-11-05 17:25naiaramartinezTriggers an Emergency Pack => No
2014-11-13 15:44aaroncaleroAssigned ToioritzCia => aaroncalero
2014-11-13 17:00aaroncaleroProposed Solution updated
2014-11-13 17:01aaroncaleroFile Added: ModularizeDiscountsAndPromotions.diff
2014-11-26 12:37ioritzCiaNote Added: 0072025
2014-11-27 13:21hgbotCheckin
2014-11-27 13:21hgbotNote Added: 0072066
2014-11-27 13:21hgbotStatusnew => resolved
2014-11-27 13:21hgbotResolutionopen => fixed
2014-11-27 13:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b795dd358967c4a95eea38e2ac0f1ddae9231373 [^]
2014-12-10 18:03marvintmReview Assigned To => marvintm
2014-12-10 18:03marvintmStatusresolved => closed
2014-12-10 18:03marvintmFixed in Version => 3.0PR15Q1.1
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073151

Notes
(0072025)
ioritzCia   
2014-11-26 12:37   
Code review done by IOC
(0072066)
hgbot   
2014-11-27 13:21   
Repository: erp/devel/pi
Changeset: b795dd358967c4a95eea38e2ac0f1ddae9231373
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu Nov 27 13:18:50 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b795dd358967c4a95eea38e2ac0f1ddae9231373 [^]

Fixed issue 28095: Modularize filters in Discounts and Promotions to be able to add filters from modules

The following actions have been performed in order to allow Discounts & Promotions to be extended in the backend:
Add an extension point to the M_PROMOTIONS_CALCULATE procedure
Allow the PriceAdjustment java class to be invoked using Weld
Add a extension to PriceAdjustment to allow the extension of the Hql query used there

---
M modules/org.openbravo.base.weld/src/META-INF/beans.xml
M src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
M src-db/database/sourcedata/AD_EXTENSION_POINTS.xml
M src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
A src/org/openbravo/erpCommon/businessUtility/PriceAdjustmentHqlExtension.java
---
(0073151)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test