Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028083Retail ModulesWeb POSpublic2014-11-04 17:562014-11-20 09:30
Reporteregoitz 
Assigned Toszapata 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028083: The select of the PaidReceiptsHeader java file takes long with big amount of data.
DescriptionThe select of the PaidReceiptsHeader java file takes long with big amount of data.
Steps To ReproduceOn an environment with thousands of invoices try to find a concrete documetno.
Although not returning data the query takes long to executed.
Then the query is saved on the cache and the next times does not take long but after a while (when the query is not on the cache) it is slow again.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filestxt timings.txt (1,189) 2014-11-18 00:57
https://issues.openbravo.com/file_download.php?file_id=7517&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-11-04 17:56egoitzNew Issue
2014-11-04 17:56egoitzAssigned To => marvintm
2014-11-04 17:56egoitzResolution time => 1415142000
2014-11-04 17:56egoitzTriggers an Emergency Pack => No
2014-11-05 17:34mtaalAssigned Tomarvintm => szapata
2014-11-06 05:21hgbotCheckin
2014-11-06 05:21hgbotNote Added: 0071446
2014-11-06 05:21hgbotStatusnew => resolved
2014-11-06 05:21hgbotResolutionopen => fixed
2014-11-06 05:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/91722bf10ff4d6d4bdb7ee8fd655cfd4fbe983d6 [^]
2014-11-18 00:57mtaalFile Added: timings.txt
2014-11-18 01:07hgbotCheckin
2014-11-18 01:07hgbotNote Added: 0071735
2014-11-18 02:28szapataNote Added: 0071737
2014-11-20 09:30mtaalReview Assigned To => mtaal
2014-11-20 09:30mtaalNote Added: 0071842
2014-11-20 09:30mtaalStatusresolved => closed
2014-11-20 09:30mtaalFixed in Version => RR15Q1

Notes
(0071446)
hgbot   
2014-11-06 05:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 91722bf10ff4d6d4bdb7ee8fd655cfd4fbe983d6
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Thu Nov 06 00:57:16 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/91722bf10ff4d6d4bdb7ee8fd655cfd4fbe983d6 [^]

Fixed issue 28083: Added some indexes and removed an unnecessary sum()

---
M src-db/database/model/modifiedTables/C_ORDER.xml
M src/org/openbravo/retail/posterminal/PaidReceiptsHeader.java
A src-db/database/model/modifiedTables/C_ORDERLINE.xml
---
(0071735)
hgbot   
2014-11-18 01:07   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b5473f7c4985ffb6e8ce817fafeab86c03d74c66
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Nov 18 01:07:01 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b5473f7c4985ffb6e8ce817fafeab86c03d74c66 [^]

Related to issue 28083: The select of the PaidReceiptsHeader java file takes long with big amount of data.
Removed index on order header, seemed dangerous to have such an index, wasn't used in the header querying either.
Added order id to the orderline indexes as this corresponds to the query logic. Adapted the query logic to use
exists, seemed faster at least according to the measurements.

---
M src-db/database/model/modifiedTables/C_ORDER.xml
M src-db/database/model/modifiedTables/C_ORDERLINE.xml
M src/org/openbravo/retail/posterminal/PaidReceiptsHeader.java
---
(0071737)
szapata   
2014-11-18 02:28   
Reviewed last code from Martin.
(0071842)
mtaal   
2014-11-20 09:30   
Reviewed, small change, reviewed by original developer, tested