Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028076Openbravo ERPZ. Otherspublic2014-11-04 12:142014-12-30 23:24
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Topramakrishnan
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket31977
Regression levelProduction - QA Approved
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028076: "InitializeBPCurrency" modulescript needs to be improved
Description"InitializeBPCurrency" modulescript needs to be improved to initialize business partner's currency for partners with no default pricelist but having all previous invoices in same currency
Steps To Reproduce- In a version previous to 3.0PR14Q3
  1. create new business partner and not set any price list in its customer tab
  2. register 2 invoices in same currency
- Upgrade version to 3.0PR14Q3.2
  3. Realize that business partner currency has not been initialized
Proposed SolutionIn case business partner has not default price list configured, modulescript should review invoice's currency and in case all business partner invoices are for same currency, then initialize business partner currency
Additional Information
TagsNo tags attached.
Relationships
related to defect 00253923.0PR14Q4 closed eduardo_Argal Wrong customer balance when working with multicurrency 
causes defect 00305303.0PR15Q4 closed aferraz Performance problem in "InitializeBPCurrency" modulescript 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-04 12:14maiteNew Issue
2014-11-04 12:14maiteAssigned To => dmiguelez
2014-11-04 12:14maiteOBNetwork customer => Yes
2014-11-04 12:14maiteModules => Advanced Payables and Receivables Mngmt
2014-11-04 12:14maiteSupport ticket => 31977
2014-11-04 12:14maiteTriggers an Emergency Pack => No
2014-11-04 12:44maiteResolution time => 1417906800
2014-11-04 12:44maiteRegression level => Production - QA Approved
2014-11-04 12:45maiteRelationship addedrelated to 0025392
2014-11-04 12:45maiteIssue Monitored: networkb
2014-11-06 09:35AtulOpenbravoAssigned Todmiguelez => AtulOpenbravo
2014-11-06 09:36AtulOpenbravoStatusnew => scheduled
2014-11-06 09:36AtulOpenbravofix_in_branch => pi
2014-11-06 19:16AtulOpenbravoNote Added: 0071474
2014-11-14 19:20AtulOpenbravoReview Assigned To => pramakrishnan
2014-11-14 19:20AtulOpenbravofix_in_branchpi =>
2014-11-14 19:23hgbotCheckin
2014-11-14 19:23hgbotNote Added: 0071660
2014-11-14 19:23hgbotStatusscheduled => resolved
2014-11-14 19:23hgbotResolutionopen => fixed
2014-11-14 19:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9eba998e1eb9629d792fe407078ab2682c73eef3 [^]
2014-11-17 08:32pramakrishnanNote Added: 0071681
2014-11-17 08:32pramakrishnanStatusresolved => closed
2014-12-30 23:24hudsonbotCheckin
2014-12-30 23:24hudsonbotNote Added: 0073059
2015-08-14 13:35aferrazRelationship addedcauses 0030530

Notes
(0071474)
AtulOpenbravo   
2014-11-06 19:16   
Test Plan
- In a version previous to 3.0PR14Q3
  1. create new business partner and not set any price list in its customer tab.
  2. Create 2 invoices in same currency for the business partner
- Upgrade version to 3.0PR14Q3.2 and apply the fix for issue 28076.
  3. Check that business partner currency has been initialized with invoice currency.

Note: In case the business partner has invoices with different currencies, currency for business partner is not initialized.
(0071660)
hgbot   
2014-11-14 19:23   
Repository: erp/devel/pi
Changeset: 9eba998e1eb9629d792fe407078ab2682c73eef3
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Nov 14 14:52:54 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9eba998e1eb9629d792fe407078ab2682c73eef3 [^]

Fixes Issue 28076:InitializeBPCurrency modulescript needs to be improved

UpdateBpCurrency method update business partner currency from the invoice
if currency is null and there exists invoices in same currency. A preference
is created inorder to avoid repeatation.

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeBPCurrency.class
M src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeBPCurrencyData.class
M src-util/modulescript/build/javasqlc/src/org/openbravo/modulescript/InitializeBPCurrencyData.java
M src-util/modulescript/src/org/openbravo/modulescript/InitializeBPCurrency.java
M src-util/modulescript/src/org/openbravo/modulescript/InitializeBPCurrency_data.xsql
---
(0071681)
pramakrishnan   
2014-11-17 08:32   
Code Review + Testing - OK.
(0073059)
hudsonbot   
2014-12-30 23:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test