Openbravo Issue Tracking System - Retail Modules
View Issue Details
0028006Retail ModulesWeb POSpublic2014-10-28 14:212014-11-20 18:16
lorenzofidalgo 
marvintm 
normalmajoralways
closedfixed 
5
main 
RR14Q4RR14Q4 
marvintm
Packaging and release
2014-09-12
main
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8a47e6f0b72c07bd61ce8e3b1ce8dbf2b6c0e0b7 [^]
No
0028006: An error popup appears when you try to complete a receipt with 0.00 total amount
This error has been found in RR14Q4. This issue does NOT appear in RR14Q3.1 & RR14Q2.6.
Each time you try in POS to complete a receipt with total amount = 0.00, this receipt cannot be completed and an error popup is shown.

(I assume that you are using CMS-1 terminal)

Login to CMS-1 POS terminal as centralmountains/openbravo.
Click to BROWSE and click menu "Backpacks & Travel".
Pick 1 item of "Alpine skiing backpack 27L" and 1 item of "Baby carrier".
Now click in "Alpine skiing backpack 27L" line, click PRICE and set 110.50. (Now you will have those two diferent items with the same price).
Click "Baby carrier" line and at the right of the screen click "Return Line" button.
After that, click in total amount (0.00) to complete the receipt. And now click "Done" button.
The error popup has appeared.

---

This also happends if you choose a single unit of some product and you set its price to 0.00 and you try to complete the receipt.

---

It is also possible to reproduce that issue if you just add a product whose price is 0.
No tags attached.
caused by defect 0027492RR14Q4 closed szapata Invoices created with wrong totals at line level and also header level 
has duplicate defect 0028160 closed marvintm Is not possible to invoice a receipt having just one line with amount 0 
png total+amt=+0.png (174,021) 2014-11-12 16:27
https://issues.openbravo.com/file_download.php?file_id=7506&type=bug
png
Issue History
2014-10-28 14:21lorenzofidalgoNew Issue
2014-10-28 14:21lorenzofidalgoAssigned To => marvintm
2014-10-28 14:21lorenzofidalgoFile Added: total amt= 0.png
2014-10-28 14:21lorenzofidalgoRegression level => Packaging and release
2014-10-28 14:21lorenzofidalgoRegression introduced in release => main
2014-10-28 14:21lorenzofidalgoTriggers an Emergency Pack => No
2014-11-03 14:50hgbotCheckin
2014-11-03 14:50hgbotNote Added: 0071363
2014-11-03 15:11hgbotCheckin
2014-11-03 15:11hgbotNote Added: 0071368
2014-11-03 15:11hgbotStatusnew => resolved
2014-11-03 15:11hgbotResolutionopen => fixed
2014-11-03 15:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/374641d49bac00297f169816e2ca2aa5cac6b1e9 [^]
2014-11-04 16:37mtaalReview Assigned To => mtaal
2014-11-04 16:37mtaalNote Added: 0071402
2014-11-04 16:37mtaalStatusresolved => closed
2014-11-04 16:37mtaalFixed in Version => RR15Q1
2014-11-06 20:30dmitry_mezentsevNote Added: 0071476
2014-11-12 16:24lorenzofidalgoNote Added: 0071610
2014-11-12 16:24lorenzofidalgoStatusclosed => new
2014-11-12 16:24lorenzofidalgoResolutionfixed => open
2014-11-12 16:24lorenzofidalgoFixed in VersionRR15Q1 =>
2014-11-12 16:27lorenzofidalgoFile Deleted: total amt= 0.png
2014-11-12 16:27lorenzofidalgoFile Added: total+amt=+0.png
2014-11-12 16:27lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7041#r7041
2014-11-12 16:36lorenzofidalgoRelationship addedhas duplicate 0028160
2014-11-17 13:21mtaalRelationship addedcaused by 0027492
2014-11-17 13:22mtaalRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8a47e6f0b72c07bd61ce8e3b1ce8dbf2b6c0e0b7 [^]
2014-11-17 13:23mtaalRegression date => 2014-09-12
2014-11-17 15:09mtaalNote Added: 0071706
2014-11-17 15:29hgbotCheckin
2014-11-17 15:29hgbotNote Added: 0071708
2014-11-17 15:29hgbotStatusnew => resolved
2014-11-17 15:29hgbotResolutionopen => fixed
2014-11-17 15:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/374641d49bac00297f169816e2ca2aa5cac6b1e9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1414b4dc6113aa955a77decd4095798599fac94e [^]
2014-11-20 18:16marvintmReview Assigned Tomtaal => marvintm
2014-11-20 18:16marvintmStatusresolved => closed
2014-11-20 18:16marvintmFixed in Version => RR14Q4

Notes
(0071363)
hgbot   
2014-11-03 14:50   
Repository: tools/automation/pi-mobile
Changeset: 2b41d0831dd28de7c4fe591f68abfe12551259cd
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Nov 03 14:50:12 2014 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2b41d0831dd28de7c4fe591f68abfe12551259cd [^]

Related to issue 28006: Added test I28006_ReceiptWithReturnCanBeZero

---
M src-test/org/openbravo/retail/standard/automation/common/javascript/IdTest.java
M src-test/org/openbravo/retail/standard/automation/suites/SalesSuite.java
A src-test/org/openbravo/retail/standard/automation/level20/returns/issues/I28006_ReceiptWithReturnCanBeZero.java
---
(0071368)
hgbot   
2014-11-03 15:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 374641d49bac00297f169816e2ca2aa5cac6b1e9
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Nov 03 15:10:45 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/374641d49bac00297f169816e2ca2aa5cac6b1e9 [^]

Fixes issue 28006: The receipt integrity check does not block the sale if a line has negative amount and the total amount is zero

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0071402)
mtaal   
2014-11-04 16:37   
Tested and reviewed
(0071476)
dmitry_mezentsev   
2014-11-06 20:30   
This issue is marked as a regression but the most important field - commit that introduced it is missing.

Could you fix it please?
(0071610)
lorenzofidalgo   
2014-11-12 16:24   
The second way of reproducing this issue that appears in "Steps to reproduce" area is still reproducible.
It is also possible to reproduce that issue if you just add a product whose price is 0.
(0071706)
mtaal   
2014-11-17 15:09   
After discussion, the change/regression was intentional to not allow zero priced lines, i.e. to not allow users to set a price of zero. We still allow setting a price so a user could set a price of one cent...

In my view the functionality of setting/overriding the price is a separate topic. Also if/how to limit this price overriding is a separate discussion.

Until that topic is solved we should allow/support zero price for a product.
(0071708)
hgbot   
2014-11-17 15:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1414b4dc6113aa955a77decd4095798599fac94e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Nov 17 15:20:54 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1414b4dc6113aa955a77decd4095798599fac94e [^]

Fixes issue 28006: An error popup appears when you try to complete a receipt with 0.00 total amount
Allow orders with a total gross of zero, we allow setting a price manually so also a price of zero.
Remove previous checks which tried to find different kinds of exceptional zero gross cases. Just allow
this, if zero price is not allowed then we should not allow setting it in the first place.
Throwing an error and removing the ticket is not the solution for this.

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---