Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027988Openbravo ERP04. Warehouse managementpublic2014-10-27 14:502014-12-30 23:23
Reporterpsanjuan 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027988: Currency field at landed cost header should be removed.
DescriptionCurrency field at landed cost header should be removed.
Steps To ReproduceIn QA Testing client.

Create a Product named "Cost USD" related to an USD Price List. Enter a price of 10 USD,

Go to Landed Cost Type and create a new one for Spain org named "Cost USD" related to "Cost USD" product.

Make sure you have a conversion rate USD to EUR. Let's imagine that conversion rate is: USD to EUR 0.4

Go to landed cost window and create a new one. Currency USD

Go to Cost tab and enter two lines:
Line 1 related to "USD Cost" Product landed cost type. Amount 10. Currency USD
Line 2 related to an "Account" G/L item cost type. Amount 5. Currency EUR,

Go to Receipt tab a and select a receipt (EUR)

Process landed cost.

Realize that Accounting and Cost adjustment created are not correct:

Accounting = 10 USD * 0.4 = 4 EUR

Accounting = 5 EUR * 2.5 (conversion rate EUR to USD) = 12.5 EUR

This is not correct

Cost Adjustment is 22.50 USD (10 USD + 12.5 USD) this is not correct

See images attached.

Proposed SolutionCorrect Accounting:
Accounting = 10 USD * 0.4 = 4 EUR
Accounting = 5 EUR

Total 4+5 = 9 EUR
Cost Adjustment = 9 EUR

Additional Information
TagsNo tags attached.
Relationships
Attached Filespng issue_27988_1.png (65,294) 2014-10-27 14:54
https://issues.openbravo.com/file_download.php?file_id=7430&type=bug
png

png issue_27988_2.png (87,809) 2014-10-27 14:54
https://issues.openbravo.com/file_download.php?file_id=7431&type=bug
png

png issue_27988_3.png (99,736) 2014-10-27 14:54
https://issues.openbravo.com/file_download.php?file_id=7432&type=bug
png

png issue_27988_4.png (89,825) 2014-10-27 14:54
https://issues.openbravo.com/file_download.php?file_id=7433&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-10-27 14:50psanjuanNew Issue
2014-10-27 14:50psanjuanAssigned To => dmiguelez
2014-10-27 14:50psanjuanOBNetwork customer => No
2014-10-27 14:50psanjuanModules => Core
2014-10-27 14:50psanjuanTriggers an Emergency Pack => No
2014-10-27 14:52psanjuanAssigned Todmiguelez => umartirena
2014-10-27 14:54psanjuanFile Added: issue_27988_1.png
2014-10-27 14:54psanjuanFile Added: issue_27988_2.png
2014-10-27 14:54psanjuanFile Added: issue_27988_3.png
2014-10-27 14:54psanjuanFile Added: issue_27988_4.png
2014-10-29 18:39hgbotCheckin
2014-10-29 18:39hgbotNote Added: 0071255
2014-10-29 18:39hgbotStatusnew => resolved
2014-10-29 18:39hgbotResolutionopen => fixed
2014-10-29 18:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8b4b108ad325d62902be4222fb222c50ff17aee5 [^]
2014-10-29 18:39hgbotCheckin
2014-10-29 18:39hgbotNote Added: 0071256
2014-10-30 11:41hgbotCheckin
2014-10-30 11:41hgbotNote Added: 0071266
2014-10-30 11:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/8b4b108ad325d62902be4222fb222c50ff17aee5 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/495063c54f02ce7892abe53d67d10e27598ad424 [^]
2014-11-04 11:08psanjuanNote Added: 0071394
2014-11-04 11:08psanjuanStatusresolved => closed
2014-12-30 23:23hudsonbotCheckin
2014-12-30 23:23hudsonbotNote Added: 0073000
2014-12-30 23:23hudsonbotCheckin
2014-12-30 23:23hudsonbotNote Added: 0073001

Notes
(0071255)
hgbot   
2014-10-29 18:39   
Repository: erp/devel/pi
Changeset: 8b4b108ad325d62902be4222fb222c50ff17aee5
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Oct 29 10:53:10 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8b4b108ad325d62902be4222fb222c50ff17aee5 [^]

Fixes issue 27988: Currency field at landed cost header has been removed

Now, if there is a Landed Cost with Landed Cost lines with different currencies, the cost adjustment will be created with a line per each goods receipt line and each currency, instead of converting from Landed Cost Cost currency to the header one and grouping them, it will leave in the original currency.

---
M src-db/database/model/tables/M_LANDEDCOST.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/costing/LandedCostDistributionByAmount.java
M src/org/openbravo/costing/LandedCostProcess.java
M src/org/openbravo/erpCommon/ad_callouts/SL_LandedCost_InvoiceLine.java
M src/org/openbravo/erpCommon/ad_forms/DocLandedCost_data.xsql
---
(0071256)
hgbot   
2014-10-29 18:39   
Repository: erp/devel/pi
Changeset: aaadf192b66ccb55cf2c389e933ed06547289875
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Oct 29 13:29:18 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aaadf192b66ccb55cf2c389e933ed06547289875 [^]

Related to Issue 27988

Remove setCurrency to a Landed Cost header in CostingServer.
Fix callout of Landed Cost Cost of Invoice Line column to not to set Currency of Landed Cost Header.

---
M src/org/openbravo/costing/CostingServer.java
M src/org/openbravo/erpCommon/ad_callouts/SL_LandedCost_InvoiceLine.java
---
(0071266)
hgbot   
2014-10-30 11:41   
Repository: erp/devel/api-checks
Changeset: 495063c54f02ce7892abe53d67d10e27598ad424
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Oct 30 11:39:25 2014 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/495063c54f02ce7892abe53d67d10e27598ad424 [^]

Fixed Issue 27988: Remove Currency from LC (int-api 874)

---
M java/reference/java.japi.gz
---
(0071394)
psanjuan   
2014-11-04 11:08   
Verified. This is working, cost adjustments are now created properly in the currency of the product even in those cases where there are differences between estimated landed cost in a foreign currency and actual landed cost.
(0073000)
hudsonbot   
2014-12-30 23:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073001)
hudsonbot   
2014-12-30 23:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test