Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027920Retail ModulesWeb POSpublic2014-10-20 18:582015-08-20 14:15
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027920: If promotions field is not defined, a javascript error is raised when calculating taxes
DescriptionIn some instances, it is raised a javascript error when adding a new product to the receipt. The problem is when calculating taxes in the line:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/dc09f9595d0b/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js#l85 [^]

If the 'promotions' field is not defined, discountedGross will be null, and raise an error in the line:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/dc09f9595d0b/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js#l153 [^]
Steps To ReproduceN.A.
Proposed SolutionInitialize properly discontedGross when 'promotions' is not defined yet.
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0027778RR14Q4 closed marvintm Taxes are not being applied properly in Web POS with an specific configuration 
related to defect 0027928 closed marvintm error is returned when return line is done 
Attached Filespatch Issue27920.patch (1,298) 2014-10-20 19:24
https://issues.openbravo.com/file_download.php?file_id=7398&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-10-20 18:58adrianromeroNew Issue
2014-10-20 18:58adrianromeroAssigned To => adrianromero
2014-10-20 18:58adrianromeroOBNetwork customer => No
2014-10-20 18:58adrianromeroTriggers an Emergency Pack => No
2014-10-20 19:24adrianromeroFile Added: Issue27920.patch
2014-10-21 12:13hgbotCheckin
2014-10-21 12:13hgbotNote Added: 0071078
2014-10-21 12:13hgbotStatusnew => resolved
2014-10-21 12:13hgbotResolutionopen => fixed
2014-10-21 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9192786617b042b4d51974846a8756a4e4467b93 [^]
2014-10-21 12:23malsasuaRelationship addedrelated to 0027928
2014-10-21 12:46migueldejuanaReview Assigned To => migueldejuana
2014-10-21 12:46migueldejuanaNote Added: 0071082
2014-10-21 12:46migueldejuanaStatusresolved => closed
2014-10-21 12:54adrianromeroRelationship addedcaused by 0027778
2015-07-08 09:46hgbotCheckin
2015-07-08 09:46hgbotNote Added: 0078734
2015-07-08 09:46hgbotStatusclosed => resolved
2015-07-08 09:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9192786617b042b4d51974846a8756a4e4467b93 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a9b788ddc57285e209e1e6782da962efceb883b5 [^]
2015-08-20 14:15marvintmStatusresolved => closed

Notes
(0071078)
hgbot   
2014-10-21 12:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9192786617b042b4d51974846a8756a4e4467b93
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue Oct 21 12:13:30 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9192786617b042b4d51974846a8756a4e4467b93 [^]

fixed issue 27920:discountedGross is used only if it is not null

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0071082)
migueldejuana   
2014-10-21 12:46   
Tested and reviewed in 0be6bec9c7c8
(0078734)
hgbot   
2015-07-08 09:46   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a9b788ddc57285e209e1e6782da962efceb883b5
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue Oct 21 12:13:30 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a9b788ddc57285e209e1e6782da962efceb883b5 [^]

fixed issue 27920:discountedGross is used only if it is not null

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---