Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027912Openbravo ERPA. Platformpublic2014-10-20 12:542014-12-30 23:23
ReporterSandrahuguet 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q4Fixed in Version3.0PR15Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027912: DateTime fields not properly formated to local time zone in grids of parameter windows
Descriptionwhen defining a grid using parameter windows, if one of the fields contained is defined as datetime, the value displayed is not properly converted and it shows the UTC date, instead of the data in the client timezone.
Steps To ReproduceUsing the QA Testing role:

Go to Financial Account Window.

Select Spain Bank financial account

Create a Transaction Manually in Transaction Tab:

    Transaction Type: BP Withdrawal
    GL Item: Salaries
    Withdrawal Amount: 100.00
    Business Partner: Vendor A
    Transaction Date: Today

Process the Transaction

 Create a Bank Statement Header:

    Name: TestReconciliationWith002
    Transaction Date: 02/10/2014

Create a Bank Statement Line:

    Transaction Date: 02/10/2014
    Reference No.: 123456
    Business Partner: Vendor A
    GL Item: Salaries
    Amount Out: 100.00

Process the Bank Statement


     

Click on Match Statement Button.

Once the parameter window appears right click on row headers to show bslUpdated column.

Realize that value displayed does not match with bankstatement line updated field in bankstatement line tab.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038489pi closed caristu Wrong displayed value of a table reference inside a pick and execute when using hql query 
blocks defect 00279133.0PR14Q4 closed eduardo_Argal System throws error message when user try to match bank statement lines with OB transactions manually 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-10-20 12:54SandrahuguetNew Issue
2014-10-20 12:54SandrahuguetAssigned To => AugustoMauch
2014-10-20 12:54SandrahuguetModules => Core
2014-10-20 12:54SandrahuguetTriggers an Emergency Pack => No
2014-10-20 12:59sureshbabuRelationship addedblocks 0027913
2014-10-20 13:20AugustoMauchSummaryDateTime fields not properly formated to local time zone => DateTime fields not properly formated to local time zone in grid parameters
2014-10-20 13:20AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=6843#r6843
2014-10-20 13:53sureshbabuRelationship deletedblocks 0027913
2014-10-20 15:13sureshbabuRelationship addedblocks 0027913
2014-10-20 15:15AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6847#r6847
2014-10-20 15:31AugustoMauchNote Added: 0071047
2014-10-20 15:43AugustoMauchNote Edited: 0071047bug_revision_view_page.php?bugnote_id=0071047#r6849
2014-10-20 16:36AugustoMauchSummaryDateTime fields not properly formated to local time zone in grid parameters => DateTime fields not properly formated to local time zone in grids of parameter windows
2014-10-20 16:36AugustoMauchNote Edited: 0071047bug_revision_view_page.php?bugnote_id=0071047#r6853
2014-10-20 16:37AugustoMauchNote Edited: 0071047bug_revision_view_page.php?bugnote_id=0071047#r6854
2014-10-20 16:37AugustoMauchIssue Monitored: alostale
2014-10-20 16:37AugustoMauchReview Assigned To => alostale
2014-10-20 16:45hgbotCheckin
2014-10-20 16:45hgbotNote Added: 0071050
2014-10-20 16:45hgbotStatusnew => resolved
2014-10-20 16:45hgbotResolutionopen => fixed
2014-10-20 16:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9035351134407dbcbe0b02826eeebc910edf74b5 [^]
2014-10-20 18:24hgbotCheckin
2014-10-20 18:24hgbotNote Added: 0071061
2014-10-20 18:24hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/9035351134407dbcbe0b02826eeebc910edf74b5 [^] => http://code.openbravo.com/erp/devel/pi/rev/6c68dafcdfac6ce159a78ee7347ecba3fdd3a340 [^]
2014-10-21 17:38gorka_gilNote Deleted: 0071061
2014-10-24 10:52alostaleNote Added: 0071161
2014-10-24 10:52alostaleStatusresolved => closed
2014-10-24 10:52alostaleFixed in Version => 3.0PR15Q1
2014-12-30 23:23hudsonbotCheckin
2014-12-30 23:23hudsonbotNote Added: 0072951
2014-12-30 23:23hudsonbotCheckin
2014-12-30 23:23hudsonbotNote Added: 0072954
2018-05-29 10:29caristuRelationship addedrelated to 0038489

Notes
(0071047)
AugustoMauch   
2014-10-20 15:31   
(edited on: 2014-10-20 16:37)
Only happens when using datasources that extend ReadOnlyDataSourceService
(0071050)
hgbot   
2014-10-20 16:45   
Repository: erp/devel/pi
Changeset: 9035351134407dbcbe0b02826eeebc910edf74b5
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Oct 20 16:44:30 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9035351134407dbcbe0b02826eeebc910edf74b5 [^]

Fixes issue 27912: Time&DateTime fields are properly handled in P&E Windows

The values of Time and DateTime fields were not being properly handled, as they where not converted from the server timezone offset to UTC before being sent to the client. This happened
because the DataToJsonConverter.convertToJsonObjects method did not perform the conversion.

Now it does, when possible. For the conversion to be done properly, the Property associated with the column value must be passed to the convertPrimitiveValue method. This will be done a
s long as the tableId parameter is sent in the datasource request, and as long as the property name can be inferred from the column name.

The QueryListDataSource extends ReadOnlyDataSourceService, but the tableId is not passed, so this changeset does not fix this case, that will be address in a separate issue.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
---
(0071161)
alostale   
2014-10-24 10:52   
code reviewed

Tested with date time + absolute date time, both working fine.
(0072951)
hudsonbot   
2014-12-30 23:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0072954)
hudsonbot   
2014-12-30 23:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test