0027904: Weird behaviour in lines when executing preorderSave hook and it stops the synchronization

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0027904

Retail Modules

Web POS

public

2014-10-17 14:33

2015-01-15 19:27

Reporter

naiaramartinez

Assigned To

mario_castello

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

Orekaria

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0027904: Weird behaviour in lines when executing preorderSave hook and it stops the synchronization

Description

When the shyncronziation is stopped (using args.cancellation=true in PreOrderSave Hook), and trying to continue with the synchronization of the order... the lines that were in the order are not taken into account, and the price of those lines become 0.

Steps To Reproduce

PreorderSave hook is used to validate the data of the lines. Imagine, when selling 'gift cards and vouchers' before saving and creating the instance of the GC/Voucher, it is nice to have a validation to check if the ID is in used for another GC/Voucher or not.

In the case of the ID is in used for another GC/Voucher, the synchronization should be stopped, the user should change the ID of the voucher and user should be able to continue with the synchronization. But this behaviour is not working correctly.

Steps to reproduce:

Install 'gift cards and vouchers' module, and apply the patch is attached to the issue.

Login as 'The White Valley Group Admin'.
Go to Products and select 'Alpine skiing backpack 27 L'. Open it in form view and modify the following information:
- gift Card Type: Gift voucher
- Grouped Product: No

Login in the webPOs and create a new order. Add 'Alpine skiing backpack 27 L' to the order. In the popup write in ID field: 1
Pay and complete the order.

Now, open the develpers tool and uncomment the following code:
// gcids.push({
// gcid: '1'
// });

The previous code is adding the code 1 to the list of ids to check in the backend if it is already in use. Since we create a voucher with id 1, now that the code is uncommented, the preOrderSave won't do the synchronization with the backend.

Create a new order. Add 'Alpine skiing backpack 27 L' and in the ID write something different to 1 (in the previous code is already writing 1). Pay it and see that an error is shown because the id 1 is already in use.

Notice that 'Done' button is disabled (this could be another issue).
Then, click again in the line and notice that 'done' button is enabled again. Click in 'Done' button and notice that the price of 'Alpine skiing backpack 27 L', the tax amount, the total amount... all of them are 0. Using this hook, we should be able to fix the data (in this case the ID of the voucher) and be able to process the order, but there is a bug that is not allowing to continue with the process.

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to

defect

0027864

closed

Orekaria

Closing a Layaway adds a new blank receipt to the pile with no reason

Attached Files