Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027896Retail ModulesDiscounts and Promotionspublic2014-10-16 22:172014-10-29 18:37
Reporterjecharri 
Assigned Tomigueldejuana 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q1Fixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027896: Discretionary discounts are not disabled when you disable
DescriptionDiscretionary discounts are not disabled when you disable
Steps To Reproduce-Go to https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]

Verify that discount "disc_fixed_5_perc" is synchronized

-Go to ERP and disable
-Logout and login again and verify that discount is still there
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028015RR15Q1 closed migueldejuana Use/take into account the active flag for all master data when doing incremental refresh 
blocks defect 0028447 closed migueldejuana It is not possible disable a discount using the ending date 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-10-16 22:17jecharriNew Issue
2014-10-16 22:17jecharriAssigned To => marvintm
2014-10-16 22:17jecharriResolution time => 1413756000
2014-10-16 22:17jecharriTriggers an Emergency Pack => No
2014-10-22 11:22migueldejuanaAssigned Tomarvintm => migueldejuana
2014-10-23 12:00hgbotCheckin
2014-10-23 12:00hgbotNote Added: 0071125
2014-10-23 12:00hgbotStatusnew => resolved
2014-10-23 12:00hgbotResolutionopen => fixed
2014-10-23 12:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0cda464347ff355e5ce3692a7da445e4e9388093 [^]
2014-10-23 17:28hgbotCheckin
2014-10-23 17:28hgbotNote Added: 0071141
2014-10-23 17:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0cda464347ff355e5ce3692a7da445e4e9388093 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c86554444ee446ec2654eafbe7c40b66741d0501 [^]
2014-10-29 12:18mtaalRelationship addedrelated to 0028015
2014-10-29 14:43hgbotCheckin
2014-10-29 14:43hgbotNote Added: 0071246
2014-10-29 14:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c86554444ee446ec2654eafbe7c40b66741d0501 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/835d55ce42b88dc01974a24161ab6a7bdd9f38da [^]
2014-10-29 14:43hgbotCheckin
2014-10-29 14:43hgbotNote Added: 0071247
2014-10-29 14:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/835d55ce42b88dc01974a24161ab6a7bdd9f38da [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/677583da77239d20b19b8732fe1cf0f11cf1e3d3 [^]
2014-10-29 16:59hgbotCheckin
2014-10-29 16:59hgbotNote Added: 0071249
2014-10-29 16:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/677583da77239d20b19b8732fe1cf0f11cf1e3d3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e7cd55a73baa36175145b9cc108dfd74b9036c45 [^]
2014-10-29 18:37marvintmReview Assigned To => marvintm
2014-10-29 18:37marvintmStatusresolved => closed
2014-10-29 18:37marvintmFixed in Version => RR15Q1
2015-01-08 17:57migueldejuanaRelationship addedblocks 0028447

Notes
(0071125)
hgbot   
2014-10-23 12:00   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0cda464347ff355e5ce3692a7da445e4e9388093
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Oct 23 11:59:25 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0cda464347ff355e5ce3692a7da445e4e9388093 [^]

Fixed issue 0027896: Discretionary discounts are not disabled when you disable

Now, we add the ability refresh master data taking into account active value. If we disable active of a discount, when refreshing master data this discount will not appear.

---
M src/org/openbravo/mobile/core/process/JSONRowConverter.java
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0071141)
hgbot   
2014-10-23 17:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c86554444ee446ec2654eafbe7c40b66741d0501
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Oct 23 17:26:11 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c86554444ee446ec2654eafbe7c40b66741d0501 [^]

Fixed issue 0027896: Discretionary discounts are not disabled when you disable

---
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0071246)
hgbot   
2014-10-29 14:43   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 835d55ce42b88dc01974a24161ab6a7bdd9f38da
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 29 14:42:57 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/835d55ce42b88dc01974a24161ab6a7bdd9f38da [^]

Fixed issue 0027896: Discretionary discounts are not disabled when you disable

Now, we add the ability refresh master data taking into account active value. If we disable active of a discount, when refreshing master data this discount will not appear.

---
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0071247)
hgbot   
2014-10-29 14:43   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 677583da77239d20b19b8732fe1cf0f11cf1e3d3
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 29 14:42:18 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/677583da77239d20b19b8732fe1cf0f11cf1e3d3 [^]

Fixed issue 0027896: Discretionary discounts are not disabled when you disable

Now, we add the ability refresh master data taking into account active value. If we disable active of a discount, when refreshing master data this discount will not appear.

---
M src/org/openbravo/mobile/core/model/ClientModelComponent.java
M src/org/openbravo/mobile/core/process/JSONRowConverter.java
---
(0071249)
hgbot   
2014-10-29 16:59   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e7cd55a73baa36175145b9cc108dfd74b9036c45
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Oct 29 16:59:13 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e7cd55a73baa36175145b9cc108dfd74b9036c45 [^]

Fixed issue 0027896: Discretionary discounts are not disabled when you disable

Now, we add the ability refresh master data taking into account active value. If we disable active of a discount, when refreshing master data this discount will not appear.

---
M src/org/openbravo/mobile/core/model/ClientModelComponent.java
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---