Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027830Openbravo ERP07. Sales managementpublic2014-10-10 12:162014-12-30 23:24
Reportercaristu 
Assigned Toreinaldoguerra 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR15Q1Fixed in Version 
Merge Request Status
Review Assigned Topramakrishnan
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket31589
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027830: It is not possible to extend the AddPaymentOrderInvoicesTransformer class
DescriptionIn add payment button, Order Invoices grid the table is an hql query table. It's modularity is provided by a java class called AddPaymentOrderInvoicesTransformer.

Currently is not possible to extend the behavior for this class because almost all of it's methods are private, which makes them uninheritable. This methods should be protected to allow the class override.

Attached is the patch.
Steps To ReproduceIn descripion
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff AddPaymentOrderInvoicesTransformer.diff (4,182) 2014-10-10 12:26
https://issues.openbravo.com/file_download.php?file_id=7343&type=bug
? InheritanceExampleClass.java (287) 2014-11-04 00:39
https://issues.openbravo.com/file_download.php?file_id=7466&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-10-10 12:16caristuNew Issue
2014-10-10 12:16caristuAssigned To => dmiguelez
2014-10-10 12:16caristuOBNetwork customer => No
2014-10-10 12:16caristuModules => Core
2014-10-10 12:16caristuSupport ticket => 31589
2014-10-10 12:16caristuResolution time => 1419289200
2014-10-10 12:16caristuTriggers an Emergency Pack => No
2014-10-10 12:16caristuIssue Monitored: networkb
2014-10-10 12:16caristuAssigned Todmiguelez => AtulOpenbravo
2014-10-10 12:17caristuOBNetwork customerNo => Yes
2014-10-10 12:18caristuversion => pi
2014-10-10 12:26caristuDescription Updatedbug_revision_view_page.php?rev_id=6767#r6767
2014-10-10 12:26caristuFile Added: AddPaymentOrderInvoicesTransformer.diff
2014-10-17 01:00eintelauIssue Monitored: eintelau
2014-10-30 19:47reinaldoguerraAssigned ToAtulOpenbravo => reinaldoguerra
2014-10-30 19:47reinaldoguerraStatusnew => scheduled
2014-11-04 00:39reinaldoguerraNote Added: 0071385
2014-11-04 00:39reinaldoguerraFile Added: InheritanceExampleClass.java
2014-11-17 11:33hgbotCheckin
2014-11-17 11:33hgbotNote Added: 0071688
2014-11-17 11:33hgbotStatusscheduled => resolved
2014-11-17 11:33hgbotResolutionopen => fixed
2014-11-17 11:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/76051fc26377cbeb89ba8b4bff5eb28f97880656 [^]
2014-11-17 17:14pramakrishnanReview Assigned To => pramakrishnan
2014-11-17 17:14pramakrishnanNote Added: 0071716
2014-11-17 17:14pramakrishnanStatusresolved => closed
2014-12-30 23:24hudsonbotCheckin
2014-12-30 23:24hudsonbotNote Added: 0073061

Notes
(0071385)
reinaldoguerra   
2014-11-04 00:39   
Test plan used:

Attached is an example class which represents the extendable behavior of the AddPaymentOrderInvoicesTransformer class. In this case the method getSelectClause is extended.
(0071688)
hgbot   
2014-11-17 11:33   
Repository: erp/devel/pi
Changeset: 76051fc26377cbeb89ba8b4bff5eb28f97880656
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Thu Oct 30 13:07:36 2014 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/76051fc26377cbeb89ba8b4bff5eb28f97880656 [^]

Fixed bug 27830: Extending methods in class AddPaymentOrderInvoicesTransformer

Methods in class AddPaymentOrderInvoicesTransformer are changed to protected instead of private, making extendable the behavior of the mentioned class.
Now it is possible to create a subclass of AddPaymentOrderInvoicesTransformer class and get access to its methods.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
---
(0071716)
pramakrishnan   
2014-11-17 17:14   
Code Review + Testing - OK.
(0073061)
hudsonbot   
2014-12-30 23:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test