Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027826Retail ModulesWeb POSpublic2014-10-10 10:292014-12-05 16:28
Reportermtaal 
Assigned Tomarvintm 
PrioritynormalSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q1Fixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027826: When browser cache is cleared, new cashup id is created, link non-reconciled tickets to this new cashupid
DescriptionWhen the browser cache is cleared the cashup information in the client is also cleared. This includes the current cashup id.

There can already be tickets stored on the server with a cashup id which is not valid anymore. These are so-called 'orphaned' tickets.

The next valid cashup should find these orphaned tickets and link them to the latest valid cashup.

A special case is that multiple tickets and multiple cashups are created offline. Then when syncing first the tickets are synced and then the cashups. In this case the first cashup will see all the tickets and could assume part of them are orphaned while they in fact belong to a cashup which is synced next.
The system should take this into account and detect orphaned tickets taking into account all cashup ids of one sync (multiple offline cashups are synced in one webservice request).

See also the attached skype chat between Antonio and Martin
Steps To Reproduce- login into WebPOS
- create tickets without doing cashup
- clear the browser cache and remove local db
- login into WebPOS
- create new ticket
- do cashup

See that the previous tickets are not invoiced or reconciled.
Proposed Solution
When doing cash close detect which orders are orphaned and update their cashup id to the first/upcoming cashup which is being done in the cashup.

There should be a patch created for as well Q2.4 and Q3.1

The decision to really include it in Q2.4 or Q3.1 is done later.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0028008 closed marvintm Cash up does not create the reconciliation 
Attached Filestxt skype_chat_antonio_martin.txt (9,864) 2014-10-10 10:29
https://issues.openbravo.com/file_download.php?file_id=7342&type=bug
diff issue27826.diff (3,814) 2014-11-10 10:39
https://issues.openbravo.com/file_download.php?file_id=7493&type=bug
diff issue27826_forQ2.diff (3,745) 2014-11-10 15:36
https://issues.openbravo.com/file_download.php?file_id=7495&type=bug
diff issue27826_forQ2_2.diff (1,106) 2014-11-12 22:44
https://issues.openbravo.com/file_download.php?file_id=7508&type=bug
diff issue27826_forQ2_finaldiff.diff (4,826) 2014-12-05 16:28
https://issues.openbravo.com/file_download.php?file_id=7575&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-10-10 10:29mtaalNew Issue
2014-10-10 10:29mtaalAssigned To => marvintm
2014-10-10 10:29mtaalFile Added: skype_chat_antonio_martin.txt
2014-10-10 10:29mtaalTriggers an Emergency Pack => No
2014-11-10 10:39marvintmFile Added: issue27826.diff
2014-11-10 15:36marvintmFile Added: issue27826_forQ2.diff
2014-11-12 22:44mtaalFile Added: issue27826_forQ2_2.diff
2014-11-12 22:50mtaalNote Added: 0071618
2014-11-12 22:51mtaalRelationship addedblocks 0028008
2014-11-12 22:51mtaalRelationship deletedblocks 0028008
2014-11-12 22:52mtaalRelationship addedblocks 0028008
2014-11-12 23:26mtaalRelationship deletedblocks 0028008
2014-11-16 23:17mtaalStatusnew => scheduled
2014-11-16 23:17mtaalfix_in_branch => pi
2014-11-16 23:18mtaalStatusscheduled => resolved
2014-11-16 23:18mtaalResolutionopen => fixed
2014-11-17 11:48hgbotCheckin
2014-11-17 11:48hgbotNote Added: 0071689
2014-11-17 11:49mtaalNote Added: 0071690
2014-11-17 11:50mtaalRelationship addedblocks 0028008
2014-11-17 13:28marvintmReview Assigned To => marvintm
2014-11-17 13:28marvintmNote Added: 0071703
2014-11-17 13:28marvintmStatusresolved => closed
2014-12-05 16:28marvintmFile Added: issue27826_forQ2_finaldiff.diff

Notes
(0071618)
mtaal   
2014-11-12 22:50   
The fix process is included in this module:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.fixcashupdata [^]

The additional changeset (issue27826_forQ2_2.diff) is needed because the ordergrouping processor in the Q2 version disables the triggers while this is also done in the fix process.

The additional changeset moves the trigger disabling to the ProcessCashClose where it belongs.
(0071689)
hgbot   
2014-11-17 11:48   
Repository: erp/pmods/org.openbravo.retail.fixcashupdata
Changeset: 551d4bc17c7fc5e77cbce422850e15f94c003914
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Nov 17 11:47:24 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.fixcashupdata/rev/551d4bc17c7fc5e77cbce422850e15f94c003914 [^]

Related to issue 27826: When browser cache is cleared, new cashup id is created, link non-reconciled tickets to this new cashupid
Filter on the selected organization in the order query

---
M src/org/openbravo/retail/fixcashupdata/FixCashUpDataProcess.java
---
(0071690)
mtaal   
2014-11-17 11:49   
Code was checked by me, found one issue (order query was not filtering on selected organization). I pushed a change for this.

Will ask Antonio to only review that last change, issue can then be closed.
(0071703)
marvintm   
2014-11-17 13:28   
Final change in the process reviewed. Issue can be closed.