Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027809Openbravo ERP08. Project and service managementpublic2014-10-09 10:562014-12-30 23:26
Reporteregoitz 
Assigned Toreinaldoguerra 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Topramakrishnan
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027809: The Wrong sales invoice. Wrong amount in payment plan detail ALERT can not be properly deactivated.
DescriptionThe Wrong sales invoice. Wrong amount in payment plan detail ALERT can not be properly deactivated. If you deactivate it, it is generated on an update.database
Steps To Reproduce-Deactivate the alertrule
-If you execute an update.database the alert rule is generated again.
-Also new alerts are raised as new although previously they were ignored.
Proposed SolutionON the AlertsForWrongInvoices_data.xsql file change the medthod existsAlertRule to not take into account if it is active or not.

https://code.openbravo.com/erp/devel/pi/file/8296d4aee5c5/modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoices_data.xsql [^]


Check also if it is needed to remove the isactive condition on the method selectOldAlertRules.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027727 closed aferraz Performance problems on the "Wrong sales invoice. Wrong amount in payment plan detail" ALERT 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-10-09 10:56egoitzNew Issue
2014-10-09 10:56egoitzAssigned To => dmiguelez
2014-10-09 10:56egoitzModules => Core
2014-10-09 10:56egoitzResolution time => 1413756000
2014-10-09 10:56egoitzTriggers an Emergency Pack => No
2014-10-09 10:56egoitzRelationship addedrelated to 0027727
2014-10-09 11:00egoitzAssigned Todmiguelez => AtulOpenbravo
2014-11-05 03:26reinaldoguerraAssigned ToAtulOpenbravo => reinaldoguerra
2014-11-05 03:26reinaldoguerraStatusnew => scheduled
2014-11-06 02:24reinaldoguerraNote Added: 0071445
2014-12-01 10:35hgbotCheckin
2014-12-01 10:35hgbotNote Added: 0072175
2014-12-01 10:35hgbotStatusscheduled => resolved
2014-12-01 10:35hgbotResolutionopen => fixed
2014-12-01 10:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fd457423c9e6e20a264a3d166896783a4ece0769 [^]
2014-12-01 10:40pramakrishnanReview Assigned To => pramakrishnan
2014-12-01 10:40pramakrishnanNote Added: 0072176
2014-12-01 10:40pramakrishnanStatusresolved => closed
2014-12-01 11:21hgbotCheckin
2014-12-01 11:21hgbotNote Added: 0072179
2014-12-01 11:23pramakrishnanNote Added: 0072180
2014-12-01 11:23pramakrishnanStatusclosed => new
2014-12-01 11:23pramakrishnanResolutionfixed => open
2014-12-03 16:50hgbotCheckin
2014-12-03 16:50hgbotNote Added: 0072264
2014-12-03 16:50hgbotStatusnew => resolved
2014-12-03 16:50hgbotResolutionopen => fixed
2014-12-03 16:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/fd457423c9e6e20a264a3d166896783a4ece0769 [^] => http://code.openbravo.com/erp/devel/pi/rev/90e159b4e6e42dcb501a07a7758000abe376b7b6 [^]
2014-12-05 08:03pramakrishnanNote Added: 0072298
2014-12-05 08:03pramakrishnanStatusresolved => closed
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073155
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073156
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073167

Notes
(0071445)
reinaldoguerra   
2014-11-06 02:24   
Test plan used:
1- Login into Openbravo ERP
2- Go to alert window
3- Deactivate Wrong sales invoice alert
4- Go to alert management window and check that this alert is not listed.
5- Execute an update.database
6- Go to alert management window again and check that Wrong sales invoice alert remains not listed.
(0072175)
hgbot   
2014-12-01 10:35   
Repository: erp/devel/pi
Changeset: fd457423c9e6e20a264a3d166896783a4ece0769
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Wed Nov 05 18:56:41 2014 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/fd457423c9e6e20a264a3d166896783a4ece0769 [^]

Fixed bug 27809: The Wrong sales invoice alert can not be properly deactivated.

Method existsAlertRule on Alerts For Wrong Invoices module script xsql file was changed to not take into account if wrong invoice alert is active or not so when module script is executed and the mentioned alert is deactivated it is recognized as an existent rule and it is not inserted again as active.
Now it is possible to deactivate The Wrong sales invoice alert and conserves its status, no matter an update database is executed.

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoicesData.class
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoices_data.xsql
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoicesData.java
---
(0072176)
pramakrishnan   
2014-12-01 10:40   
Code Review + Testing - OK.
(0072179)
hgbot   
2014-12-01 11:21   
Repository: erp/devel/pi
Changeset: 7061822cce381e64a48def1f221f98aebfc650f9
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Mon Dec 01 15:50:26 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7061822cce381e64a48def1f221f98aebfc650f9 [^]

Backout Issue 27809: Backed out changeset fd457423c9e6

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoicesData.class
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoices_data.xsql
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoicesData.java
---
(0072180)
pramakrishnan   
2014-12-01 11:23   
Backed out the fix as it breaks CI
(0072264)
hgbot   
2014-12-03 16:50   
Repository: erp/devel/pi
Changeset: 90e159b4e6e42dcb501a07a7758000abe376b7b6
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Tue Dec 02 13:44:23 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/90e159b4e6e42dcb501a07a7758000abe376b7b6 [^]

Fixed bug 27809: The Wrong sales invoice alert can not be properly deactivated.

Method existsAlertRule on Alerts For Wrong Invoices module script xsql file was changed to not take into account if wrong invoice alert is active or not so when module script is executed and the mentioned alert is deactivated it is recognized as an existent rule and it is not inserted again as active.
Now it is possible to deactivate The Wrong sales invoice alert and conserves its status, no matter an update database is executed.

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoicesData.class
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoices_data.xsql
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongInvoicesData.java
---
(0072298)
pramakrishnan   
2014-12-05 08:03   
Code Review + Testing - OK.
(0073155)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073156)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073167)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test