Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027766Retail ModulesWeb POSpublic2014-10-03 17:592014-10-07 01:23
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in Version 
Merge Request Status
Review Assigned Toszapata
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027766: Improve performance, add index to OBPOS_APP_CASH_RECONCIL table to prevent full table scans
DescriptionAdd an index to the OBPOS_APP_CASH_RECONCIL table to prevent full table scans on high volumes.
Steps To ReproduceCheck table definition, check table scans at larger customers
Proposed SolutionThis index from this changeset can be added to solve this issue:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/73ababb3c269ba0b114533d173273e698f52cd9c#l1.7 [^]

Note should also be applied in q2.4 and Q3
Additional Information
TagsPerformance
Relationships
related to design defect 0027019RR15Q1 closed szapata In Q2 version cash ups and reconciliations are not being created properly 
Attached Filesdiff 27766_q24.diff (1,025) 2014-10-05 23:43
https://issues.openbravo.com/file_download.php?file_id=7304&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-10-03 17:59mtaalNew Issue
2014-10-03 17:59mtaalAssigned To => mtaal
2014-10-03 17:59mtaalTriggers an Emergency Pack => No
2014-10-03 18:01mtaalTag Attached: Performance
2014-10-05 23:11hgbotCheckin
2014-10-05 23:11hgbotNote Added: 0070718
2014-10-05 23:11hgbotStatusnew => resolved
2014-10-05 23:11hgbotResolutionopen => fixed
2014-10-05 23:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1fad5dae3227a231af4ef69258ab712c3c455f3f [^]
2014-10-05 23:41mtaalNote Added: 0070720
2014-10-05 23:41mtaalRelationship addedrelated to 0027019
2014-10-05 23:43mtaalFile Added: 27766_q24.diff
2014-10-05 23:43mtaalNote Edited: 0070720bug_revision_view_page.php?bugnote_id=0070720#r6738
2014-10-05 23:44mtaalNote Added: 0070721
2014-10-07 01:23szapataReview Assigned To => szapata
2014-10-07 01:23szapataStatusresolved => closed

Notes
(0070718)
hgbot   
2014-10-05 23:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1fad5dae3227a231af4ef69258ab712c3c455f3f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Oct 05 23:11:19 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1fad5dae3227a231af4ef69258ab712c3c455f3f [^]

Fixes issue 27766: Improve performance, add index to OBPOS_APP_CASH_RECONCIL
Added index on cashup id column to prevent full table scans on doing cashups.

---
M src-db/database/model/tables/OBPOS_APP_CASH_RECONCIL.xml
---
(0070720)
mtaal   
2014-10-05 23:41   
(edited on: 2014-10-05 23:43)
Note: previous commit, adds back an index which was accidentally removed when backing out from the 27019 issue here:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/922fba131f352df12fa84f7f94375930601fe6c4 [^]

So this index was added back above for Q4.

However, in q2.4 and q3 this index needs to be added, this is the index originally added in the 27019 issue:
<index name="OBPOS_APP_CASH_REC_PAYMNT_IDX" unique="false">
   <index-column name="OBPOS_APP_PAYMENT_ID"/>
</index>

This is the one added by the 27019 cashup developments
(0070721)
mtaal   
2014-10-05 23:44   
The attached file can also be applied to the q3 maintenance pack.