Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027753Openbravo ERP09. Financial managementpublic2014-10-03 12:172014-12-30 23:22
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027753: Tax Payment Unprocess when Generate Payment = Y - ORACLE
DescriptionIMPORTANT: This behavior is only reproducible in Oracle!

The Tax Payment generates a payment when processing the record as long as the Generate Payment = Y.
However, when unprocessing the tax payment, the previously created payment is kept.

Later on, if we process again the same tax payment, a new payment is created, which is totally wrong
Steps To Reproduce1. Follow tax payment guide and process record using option "generate payment"=Y: http://wiki.openbravo.com/wiki/Tax_Payment [^] [^]
2. Access Payment in/Payment out window and search for created payment. Write down the payment number
3. Navigate to GL Journal window from Tax Payment header and ensure that journal is unpost
4. Go back to tax payment and unprocess it
5. Go to the Payment in/Payment out window and search for the previously created payment. It's still there. WRONG
6. Go back to tax payment, ensure "generate payment"=Y and process it.
7. Go to the Payment in/Payment out window and realize the previous payment is there and the process has created a new one. WRONG
Proposed SolutionIdeally, when unprocessing the tax payment, the associated payment should be deleted.
If not possible (for example because the payment is already included into a transaction, reconcilation, it's posted, etc.), an error message should inform the user about this situation and stops the process. The user should be able to manually fix this situation (if possible) and try to unprocess the tax payment again.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00265623.0PR15Q1 closed vmromanos Improve error message when Unprocessing a Tax Payment with related Payment posted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-10-03 12:17vmromanosNew Issue
2014-10-03 12:17vmromanosAssigned To => dmiguelez
2014-10-03 12:17vmromanosOBNetwork customer => No
2014-10-03 12:17vmromanosModules => Core
2014-10-03 12:17vmromanosTriggers an Emergency Pack => No
2014-10-03 12:17vmromanosRelationship addedrelated to 0026562
2014-10-03 13:54vmromanosSummaryTax Payment Unprocess when Generate Payment = Y => Tax Payment Unprocess when Generate Payment = Y - ORACLE
2014-10-03 13:54vmromanosDescription Updatedbug_revision_view_page.php?rev_id=6730#r6730
2014-10-06 11:30vmromanosOBNetwork customerNo => Yes
2014-10-06 11:30vmromanosAssigned Todmiguelez => vmromanos
2014-10-06 11:30vmromanosStatusnew => scheduled
2014-10-06 11:30vmromanosfix_in_branch => pi
2014-10-06 12:13hgbotCheckin
2014-10-06 12:13hgbotNote Added: 0070736
2014-10-06 12:13hgbotStatusscheduled => resolved
2014-10-06 12:13hgbotResolutionopen => fixed
2014-10-06 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/401047aa8e05b51d4b8bcbd7ea261e71cb6e3f23 [^]
2014-10-15 19:01maiteNote Added: 0070978
2014-10-15 19:01maiteStatusresolved => closed
2014-12-30 23:22hudsonbotCheckin
2014-12-30 23:22hudsonbotNote Added: 0072901

Notes
(0070736)
hgbot   
2014-10-06 12:13   
Repository: erp/devel/pi
Changeset: 401047aa8e05b51d4b8bcbd7ea261e71cb6e3f23
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Oct 06 11:46:42 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/401047aa8e05b51d4b8bcbd7ea261e71cb6e3f23 [^]

Fixed bug 27753: Tax Payment Unprocess when Generate Payment = Y (ORACLE only)

The extension point when unprocessing a Tax Payment didn't work in Oracle, reason: a SQL query was expecting to receive always a GL Item, but when unprocessing a record, the GL Item is not sent to the extension point. This created an Oracle exception that wasn't properly captured.

The solution is to move the SQL query that requires the GL Item inside the processing flow only.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_TAX_PAYMENT.xml
---
(0070978)
maite   
2014-10-15 19:01   
verified
(0072901)
hudsonbot   
2014-12-30 23:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test