Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0027742Openbravo ERP09. Financial managementpublic2014-10-02 13:092014-12-30 23:26
shuehner 
eduardo_Argal 
normalmajorhave not tried
closedfixed 
5
 
3.0PR15Q1 
pramakrishnan
Core
No
0027742: The database view C_ORDER_LINETAX_VT is not used at all and has syntax concistency problem with pgsql 9.3
This view has same dbconsistency problems as described in issue 27741.

But also this c_order_linetax_vt view seems completely unused.

See following comments for more how that 'unused' was tested.
-
Delete that view completely from the ERP as it seems not to be used at all.

NOTE: This will be an api-change
No tags attached.
related to defect 00277413.0PR15Q1 closed eduardo_Argal The database view APRM_REC_DETAIL_V has syntax inconsistency on PostgreSQL 9.3 (and 9.4beta) 
Issue History
2014-10-02 13:09shuehnerNew Issue
2014-10-02 13:09shuehnerAssigned To => dmiguelez
2014-10-02 13:09shuehnerModules => Core
2014-10-02 13:09shuehnerTriggers an Emergency Pack => No
2014-10-02 13:11shuehnerTarget Version => 3.0PR15Q1
2014-10-02 13:26shuehnerNote Added: 0070660
2014-10-02 13:31shuehnerRelationship addedrelated to 0027741
2014-11-26 18:18shuehnerAssigned Todmiguelez => eduardo_Argal
2014-11-26 18:51eduardo_ArgalStatusnew => scheduled
2014-11-26 18:51eduardo_Argalfix_in_branch => pi
2014-11-27 16:38hgbotCheckin
2014-11-27 16:38hgbotNote Added: 0072075
2014-11-27 16:38hgbotStatusscheduled => resolved
2014-11-27 16:38hgbotResolutionopen => fixed
2014-11-27 16:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e352011a1215d4e395ee469b99e7667fc1ad46c2 [^]
2014-12-11 06:57pramakrishnanReview Assigned To => pramakrishnan
2014-12-11 06:57pramakrishnanNote Added: 0072412
2014-12-11 06:57pramakrishnanStatusresolved => closed
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073152

Notes
(0070660)
shuehner   
2014-10-02 13:26   
Testing done to find usage of this view:
1.) in a pi clone: grep -Iir C_ORDER_LINETAX_VT .
    No occurrence found besides view definition itself.
    Note: Not mapped at all in AD, so there cannot be any user via DAL.
2.) Search for view name in all gpscode hg-repos (130 repos) containing many modules by gps which are likely to not be in CR)
    No occurrence found (ignoring pi branch which can be ignored)
3.) Grepping same way in most modules published in CR in status QAA.
    Number of checked modules: 772, downloaded at 2014-08-04
    No occurrence found.

Based on those checks i think we can fairly assume that it is very unlikely that the view is used by modules.
(0072075)
hgbot   
2014-11-27 16:38   
Repository: erp/devel/pi
Changeset: e352011a1215d4e395ee469b99e7667fc1ad46c2
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Thu Nov 27 16:37:56 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e352011a1215d4e395ee469b99e7667fc1ad46c2 [^]

Fixes bug 27742: The database view C_ORDER_LINETAX_VT is not used

---
R src-db/database/model/views/C_ORDER_LINETAX_VT.xml
---
(0072412)
pramakrishnan   
2014-12-11 06:57   
Verified
(0073152)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test