Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027709Openbravo ERP01. General setuppublic2014-09-29 15:532014-12-30 23:22
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1Fixed in Version3.0PR15Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket30875
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027709: Inactive records are taken into account for Role access
DescriptionInactive records are taken into account for Role access
Steps To ReproduceAs group admin role:
   Create a new role
   Set it as manual
   Set an organization in the Org Access tab
   Set Sales Order window in the Window Access tab:
      Editable Field: Y
      Active: Y
   Set Header tab in the Tab Access tab:
      Editable Field: Y
      Active: Y
   Set Organization field in the Field Access tab:
      Editable Field: N
      Active: N
   Set Openbravo in User Assignment tab
Log in with that Role:
   Open the Sales Order window (ignore the error message)
   Create a new record in the Sales Order window and check the Organization field is Read Only
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? issue27709.export (4,136) 2014-09-30 11:24
https://issues.openbravo.com/file_download.php?file_id=7284&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-09-29 15:53ngarciaNew Issue
2014-09-29 15:53ngarciaAssigned To => jonalegriaesarte
2014-09-29 15:53ngarciaOBNetwork customer => Yes
2014-09-29 15:53ngarciaModules => Core
2014-09-29 15:53ngarciaSupport ticket => 30875
2014-09-29 15:53ngarciaResolution time => 1412200800
2014-09-29 15:53ngarciaTriggers an Emergency Pack => No
2014-09-29 15:55ngarciaSeveritymajor => minor
2014-09-29 15:55ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6682#r6682
2014-09-29 15:58ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6683#r6683
2014-09-29 16:00ngarciaIssue Monitored: networkb
2014-09-29 16:22jonalegriaesarteAssigned Tojonalegriaesarte => AtulOpenbravo
2014-09-30 09:23jonalegriaesarteAssigned ToAtulOpenbravo => AugustoMauch
2014-09-30 11:14AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6689#r6689
2014-09-30 11:24AugustoMauchFile Added: issue27709.export
2014-09-30 11:24AugustoMauchNote Added: 0070542
2014-09-30 17:19AugustoMauchStatusnew => scheduled
2014-09-30 17:19AugustoMauchfix_in_branch => pi
2014-10-02 11:48ngarciaTarget Version => 3.0PR15Q1
2014-10-02 11:48ngarciafix_in_branchpi =>
2014-10-06 10:26AugustoMauchIssue Monitored: alostale
2014-10-06 10:26AugustoMauchReview Assigned To => alostale
2014-10-06 10:29hgbotCheckin
2014-10-06 10:29hgbotNote Added: 0070728
2014-10-06 10:29hgbotStatusscheduled => resolved
2014-10-06 10:29hgbotResolutionopen => fixed
2014-10-06 10:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/30ffca2dd8adb2956f5a1c0a384588da7c6c97a9 [^]
2014-10-08 09:20alostaleNote Added: 0070796
2014-10-08 09:20alostaleStatusresolved => closed
2014-10-08 09:20alostaleFixed in Version => 3.0PR15Q1
2014-12-30 23:22hudsonbotCheckin
2014-12-30 23:22hudsonbotNote Added: 0072899

Notes
(0070542)
AugustoMauch   
2014-09-30 11:24   
A fix has been attached. It will be pushed one the behavioural change is approved by DME.
(0070728)
hgbot   
2014-10-06 10:29   
Repository: erp/devel/pi
Changeset: 30ffca2dd8adb2956f5a1c0a384588da7c6c97a9
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Sep 30 11:20:31 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/30ffca2dd8adb2956f5a1c0a384588da7c6c97a9 [^]

Fixes bug 27709: Inactive Window/Tab/Field Access records are not considered

The problem was that even if a WIndow/Tab/Field access record was inactive, it was being taken into account by the WindowSettionsActionHandler class. Now this no longer happen.

This fix comes with a behavioural change in the way the Is Active field of these tabs is handled. Before this fix the flag was ignored, now is taken into account.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java
---
(0070796)
alostale   
2014-10-08 09:20   
code reviewed

tested: inactive records are not taken into account at any level: window, tab and field
(0072899)
hudsonbot   
2014-12-30 23:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test