0027700: build.apply subfolder is not deleted in install.source

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0027700

Openbravo ERP

A. Platform

public

2014-09-29 10:12

2022-02-01 08:05

Reporter

shuehner

Assigned To

Triage Platform Base

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0027700: build.apply subfolder is not deleted in install.source

Description

The build.apply folder (used for compiling subset of code needed for ApplyModulesTask) is not deleted on install.source.

That leads to following problem:
If one .class file is generated wrongly ever for some reason (i.e. exists with uptodate timestamp but 0 bytes).

Then every following install.source will also fail instead of cleanly reinstalling.

Note: build.apply is normally cleanup up after ApplyModules. So error truncating that file must have happened during execution of that task.

Note: to be decided if to delete build.apply only in install.source (i.e. cleanSubfolder of main build.xml) or in all compile.complete (i.e. src/build.xml clean task).

Note: as build.apply is always deleted after use normally no bad effect of doing every compile.complete and will give 'easier' fixing of the compilation problem described here.

Steps To Reproduce

Observed in ci.

Probably following steps could reproduce it.
edit src/build.xml and comment out following line inside 'apply.module' task..
<delete includeEmptyDirs="true" dir="${build.apply.module}" />
Needed to keep build.apply around after compile.
ant install.source
truncate -s0 ./build.apply/classes/org/openbravo/erpCommon/modules/ApplyModuleTask.class
That is to simulate that file being broken.

ant install.source again
Should work but will fail always as it will not recompile the ApplyModuleTask.java file (as .class exists and is recent enough (file timestamp newer then java).

Proposed Solution

add line to delete build.apply (with content), ignoring if non-existent
to i.e. cleanSubFolders task.

Additional Information