Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027636Openbravo ERPA. Platformpublic2014-09-18 12:442014-09-26 11:44
Reportercaristu 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR14Q4Fixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket30627
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027636: Absolute Date Time fields are not handling properly DST changes of the timezone
DescriptionAbsolute Date Time and Absolute Time fields are not handling properly the clock changes in the timezone
Steps To Reproduce1) Create a new column of type Absolute Date Time and create its corresponding field.
2) Having the client in GMT+2, try to set the following date time: 26-10-2014 01:00:00. Notice that the data changes when saving the record to 26-10-2014 02:00:00. This is happening because the DST change in 2014 for GMT+2 is on 26-10-2014.
3) The same behavior occurs for Absolute Time fields.
Proposed SolutionIt should be taken into account if the timezone changes when converting the dates: http://wiki.openbravo.com/wiki/Projects/Absolute_DateTime_Reference/Technical_Documentation#Logic_related_explanation [^]
Additional Information
TagsNo tags attached.
Relationships
related to defect 00275103.0PR14Q4 closed AugustoMauch Absolute Time is not displaying the absolute time when the timezone changes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-09-18 12:44caristuNew Issue
2014-09-18 12:44caristuAssigned To => AugustoMauch
2014-09-18 12:44caristuOBNetwork customer => Yes
2014-09-18 12:44caristuModules => Core
2014-09-18 12:44caristuSupport ticket => 30627
2014-09-18 12:44caristuResolution time => 1411768800
2014-09-18 12:44caristuTriggers an Emergency Pack => No
2014-09-18 12:44caristuIssue Monitored: networkb
2014-09-18 12:56caristuRelationship addedrelated to 0027510
2014-09-18 13:04caristuversion => pi
2014-09-18 13:04caristuTarget Version => 3.0PR14Q4
2014-09-22 14:32inigosanchezAssigned ToAugustoMauch => inigosanchez
2014-09-23 09:54inigosanchezAssigned Toinigosanchez => shankarb
2014-09-24 19:14AugustoMauchAssigned Toshankarb => AugustoMauch
2014-09-24 19:46AugustoMauchIssue Monitored: shankarb
2014-09-24 19:46AugustoMauchReview Assigned To => shankarb
2014-09-24 19:47AugustoMauchNote Added: 0070323
2014-09-24 19:49hgbotCheckin
2014-09-24 19:49hgbotNote Added: 0070324
2014-09-24 19:49hgbotStatusnew => resolved
2014-09-24 19:49hgbotResolutionopen => fixed
2014-09-24 19:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/509bb26b8f7edc38293b7c97bef0371fb9bd2b8e [^]
2014-09-25 11:30hudsonbotCheckin
2014-09-25 11:30hudsonbotNote Added: 0070362
2014-09-26 11:44shankarbNote Added: 0070432
2014-09-26 11:44shankarbStatusresolved => closed
2014-09-26 11:44shankarbFixed in Version => 3.0PR14Q4

Notes
(0070323)
AugustoMauch   
2014-09-24 19:47   
Not a risky fix, because the correction is only applied when the timezone offset of the date changes, and that will only happen for a very reduced number of hours in a year.
(0070324)
hgbot   
2014-09-24 19:49   
Repository: erp/devel/pi
Changeset: 509bb26b8f7edc38293b7c97bef0371fb9bd2b8e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Sep 24 19:43:54 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/509bb26b8f7edc38293b7c97bef0371fb9bd2b8e [^]

Fixes issue 27636: Absolute Date Time field works properly with offset change

The problem was that if the date selected in an absolute datetime field was very close to a timezone offset change, the date was automatically changed. The original entered date was modified in the OB.Utilities.Date.addTimezoneOffset function. Now, if inside this function the date timezone offset is modified, the proper correction is applied.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js
---
(0070362)
hudsonbot   
2014-09-25 11:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63604e8e17b7 [^]
Maturity status: Test
(0070432)
shankarb   
2014-09-26 11:44   
Code reviewed and verified in pi changeset 653cc6909012.