Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027614Openbravo ERP09. Financial managementpublic2014-09-16 13:222014-10-01 10:59
Reporterumartirena 
Assigned ToSandrahuguet 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toeduardo_Argal
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027614: API Break on Reconciliation Project (try-api 673)
DescriptionLook at:

* API Break due to following columns have been marked as mandatory and not null in Fin_Finacc_Transaction table:
 - statementdate
 - dateacct
 - trxtype
* Also due to a new constraint in Fin_Finacc_Transaction table:
Constraint: FIN_TRANS_AMOUNTS_CHK defined as: (PAYMENTAMT <> 0) OR (DEPOSITAMT <> 0)
* The size of table AD_COLUMN Column ENTITY_ALIAS has changed from 60 to 2000
* Not Allowed insertions in AD_PROCESS_PARA table. ID: 993E5D1AE89649648DFE15C27360CD52 is a false positive. Action param now is created in application dictionary previously is hardcoded.

Risk api-changes:

* statementdate: There should not be any transaction without Transaction Date. Before this project is was not possible to add transactions with this field empty from the application.
* dateacct: The Accounting Date field it was possible to leave empty, but it should not be a common case, because this would mean a transaction not used in accounting, and this is an error and should be fixed.
If statementdate or dateacct a buildvalidation fails and to solve this it is very helpful to visit http://wiki.openbravo.com/wiki/Update_Transaction_Refactor [^]
* trxtype: The Transaction Type field it should not be a problem because there is a modulescript that inserts a value there in case is needed.
* (PAYMENTAMT <> 0) OR (DEPOSITAMT <> 0): there should not be any record with both amounts Zero, the application does not allow it. But we found that retail allowed to insert transactions with both amounts Zero. To fix this transactions we provide a new modulescript.
* Size of entity_alias in ad_column, it should not be a problem because the size is bigger.

Steps To ReproduceLook at: http://ci.openbravo.com/view/try/job/try-api/673/consoleFull [^]

 [checkAPI] 29166 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29170 ERROR - Errors in API model validation
 [checkAPI] 29173 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29178 ERROR - Check Constraint addition: table: FIN_FINACC_TRANSACTION - Constraint: FIN_TRANS_AMOUNTS_CHK defined as: (PAYMENTAMT <> 0) OR (DEPOSITAMT <> 0)
 [checkAPI] 29181 ERROR - Column change from not required to required: column: FIN_FINACC_TRANSACTION.DATEACCT
 [checkAPI] 29185 ERROR - Column change from not required to required: column: FIN_FINACC_TRANSACTION.TRXTYPE
 [checkAPI] 29189 ERROR - Column change from not required to required: column: FIN_FINACC_TRANSACTION.STATEMENTDATE
 [checkAPI] 29192 ERROR -
 [checkAPI]
 [checkAPI] 29195 WARN -
 [checkAPI]
 [checkAPI] 29199 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29202 WARN - Warnings in API model validation
 [checkAPI] 29205 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29208 WARN - Column size changed from 60 to 2000: column: AD_COLUMN.ENTITY_ALIAS
 [checkAPI] 29213 WARN -
 [checkAPI]
 [checkAPI] 29218 ERROR -
 [checkAPI]
 [checkAPI] 29222 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29225 ERROR - Errors in API data validation
 [checkAPI] 29228 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29232 ERROR - Changed column value AD_COLUMN.ISMANDATORY -ID:7DC34559B416B45BE040007F0100784A from [N] to [Y]
 [checkAPI] 29237 ERROR - Changed column value AD_COLUMN.ISMANDATORY -ID:828EE0AE801C5FA1E040007F010067C7 from [N] to [Y]
 [checkAPI] 29242 ERROR - Changed column value AD_COLUMN.ISMANDATORY -ID:828EE0AE801D5FA1E040007F010067C7 from [N] to [Y]
 [checkAPI] 29247 ERROR - Not Allowed insertions in AD_PROCESS_PARA table. ID: 993E5D1AE89649648DFE15C27360CD52
 [checkAPI] 29252 ERROR -
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027694 closed Sandrahuguet Constraint: FIN_TRANS_AMOUNTS_CHK should not be managed in the buildvalidation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-09-16 13:22umartirenaNew Issue
2014-09-16 13:22umartirenaAssigned To => dmiguelez
2014-09-16 13:22umartirenaModules => Core
2014-09-16 13:22umartirenaTriggers an Emergency Pack => No
2014-09-19 13:04dmitry_mezentsevNote Added: 0070207
2014-09-19 13:48dmitry_mezentsevAssigned Todmiguelez => umartirena
2014-09-23 10:17hgbotCheckin
2014-09-23 10:17hgbotNote Added: 0070268
2014-09-23 10:17hgbotStatusnew => resolved
2014-09-23 10:17hgbotResolutionopen => fixed
2014-09-23 10:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/c1857251731f87e51018ec81ba0208377579d15b [^]
2014-09-23 10:49SandrahuguetAssigned Toumartirena => Sandrahuguet
2014-09-23 10:50SandrahuguetReview Assigned To => eduardo_Argal
2014-09-24 09:37SandrahuguetStatusresolved => new
2014-09-24 09:37SandrahuguetResolutionfixed => open
2014-09-24 09:38SandrahuguetNote Added: 0070299
2014-09-24 10:01SandrahuguetSummaryAPI Break on Reconciliation Project (try-api 648) => API Break on Reconciliation Project (try-api 673)
2014-09-24 10:01SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=6611#r6611
2014-09-24 10:01SandrahuguetSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6613#r6613
2014-09-24 10:06SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=6614#r6614
2014-09-24 10:07SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=6615#r6615
2014-09-24 10:08SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=6616#r6616
2014-09-24 11:06SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=6625#r6625
2014-09-24 11:07SandrahuguetStatusnew => scheduled
2014-09-24 11:07Sandrahuguetfix_in_branch => pi
2014-09-24 11:07SandrahuguetStatusscheduled => resolved
2014-09-24 11:07SandrahuguetResolutionopen => fixed
2014-09-26 12:05SandrahuguetRelationship addedrelated to 0027694
2014-10-01 10:58eduardo_ArgalNote Added: 0070605
2014-10-01 10:58eduardo_ArgalStatusresolved => closed

Notes
(0070207)
dmitry_mezentsev   
2014-09-19 13:04   
Approved.
Additional action. Add a link to the build validation to the wiki document so that user has explanations about actions to do.
(0070268)
hgbot   
2014-09-23 10:17   
Repository: erp/devel/api-checks
Changeset: c1857251731f87e51018ec81ba0208377579d15b
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Sep 23 10:12:48 2014 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/c1857251731f87e51018ec81ba0208377579d15b [^]

Fixed issue 27614: API Break on Reconciliation Project (try-api 648)

---
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS_PARA.xml
M model/src-db/database/model/tables/AD_COLUMN.xml
M model/src-db/database/model/tables/FIN_FINACC_TRANSACTION.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0070299)
Sandrahuguet   
2014-09-24 09:38   
Reopened to update the description
(0070605)
eduardo_Argal   
2014-10-01 10:58   
Code Reviewed and tested. These API changes were agreed and approved.