Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027583Openbravo ERP07. Sales managementpublic2014-09-11 11:252015-08-24 17:38
Reporterjonalegriaesarte 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket30914
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027583: Create order in sales quotation, not setting firm option fails if the list price is 0
DescriptionCreate order in sales quotation, not setting firm option fails if the list price is 0
Steps To Reproduce- Create a sales quotation
- Add a line. Set list price to 0
- Book it
- Create order. Do not set firm check
Error
java.lang.Exception: / by zero
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-09-11 11:25jonalegriaesarteNew Issue
2014-09-11 11:25jonalegriaesarteAssigned To => dmiguelez
2014-09-11 11:25jonalegriaesarteOBNetwork customer => No
2014-09-11 11:25jonalegriaesarteModules => Core
2014-09-11 11:25jonalegriaesarteSupport ticket => 30914
2014-09-11 11:25jonalegriaesarteResolution time => 1416524400
2014-09-11 11:25jonalegriaesarteTriggers an Emergency Pack => No
2014-09-29 10:51eduardo_ArgalTarget Version3.0PR14Q4 => 3.0PR15Q1
2014-12-22 17:59SandrahuguetTarget Version3.0PR15Q1 => 3.0PR15Q2
2015-03-30 18:21eduardo_ArgalTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-04-14 12:48Triage FinanceAssigned Todmiguelez => Triage Finance
2015-06-08 17:57vmromanosTarget Version3.0PR15Q3 =>
2015-08-04 12:30egoitzOBNetwork customerNo => Yes
2015-08-04 12:30egoitzResolution time1416524400 => 1442786400
2015-08-18 13:55AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-08-18 21:24AtulOpenbravoNote Added: 0079413
2015-08-18 21:48AtulOpenbravoStatusnew => scheduled
2015-08-21 14:19hgbotCheckin
2015-08-21 14:19hgbotNote Added: 0079582
2015-08-21 14:19hgbotStatusscheduled => resolved
2015-08-21 14:19hgbotResolutionopen => fixed
2015-08-21 14:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/206df69435e62bd13e5692e72729934ff1b6d8da [^]
2015-08-21 14:19dmiguelezReview Assigned To => dmiguelez
2015-08-21 14:19dmiguelezNote Added: 0079583
2015-08-21 14:19dmiguelezStatusresolved => closed
2015-08-24 17:38hudsonbotCheckin
2015-08-24 17:38hudsonbotNote Added: 0079642

Notes
(0079413)
AtulOpenbravo   
2015-08-18 21:24   
Test Plan
- Navigate to Product window. Set List price = 0 for any of the product in Sales Price List. For eg:- Price List = Tarifa de ventas, Product = Vino Blanco 0,75L
- Create a sales quotation any of the business partner and select price list as above.
- Add a line with above product. Check that Net List Price is set as zero.
- Book it.
- Use Create order button, do not check firm quote check box.
- Quotation is converted into order successfully.
(0079582)
hgbot   
2015-08-21 14:19   
Repository: erp/devel/pi
Changeset: 206df69435e62bd13e5692e72729934ff1b6d8da
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Aug 19 01:19:59 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/206df69435e62bd13e5692e72729934ff1b6d8da [^]

Fixes Issue 27583:Create order in sales quotation, not setting firm option
fails if the list price is 0

Before divide operation, divisor bdPriceList is checked to be a non zero
value.

---
M src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
---
(0079583)
dmiguelez   
2015-08-21 14:19   
Code Review + Testing Ok
(0079642)
hudsonbot   
2015-08-24 17:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5da132f0eb35 [^]
Maturity status: Test