Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027568Retail ModulesDiscounts and Promotionspublic2014-09-09 19:232014-10-31 03:46
Reporterjecharri 
Assigned Tomigueldejuana 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toszapata
OBNetwork customerOBPS
Support ticket30902
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027568: Add pack button in the ERP is not taking into account cash VAT new functionality
DescriptionAdd pack button in the ERP is not taking into account cash VAT new functionality
Steps To Reproduce-Configure and organization to use cash VAT
http://wiki.openbravo.com/wiki/Cash_VAT_Management/User_Documentation [^]

-After that configure a product with tax category and tax rate (only one tax rate in that category)
-Check the tax rate as cash vat tax
-Define a pack that adds 5 units of above product

-Create and order
-Press in "Add pack"
-verify that you will receive nullpointer exception because it is not able to get the tax because is doing the request to get the query without p_forcedcashvat parameter of function c_gettax.
Proposed Solution-Manage the nullpointer exception
-include the parameter in the function depending if it is necessary or not
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-09-09 19:23jecharriNew Issue
2014-09-09 19:23jecharriAssigned To => marvintm
2014-09-09 19:23jecharriOBNetwork customer => Yes
2014-09-09 19:23jecharriSupport ticket => 30902
2014-09-09 19:23jecharriResolution time => 1413064800
2014-09-09 19:23jecharriTriggers an Emergency Pack => No
2014-09-09 19:23jecharriProposed Solution updated
2014-10-10 09:18hgbotCheckin
2014-10-10 09:18hgbotNote Added: 0070857
2014-10-10 09:18hgbotStatusnew => resolved
2014-10-10 09:18hgbotResolutionopen => fixed
2014-10-10 09:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/97eec3d5f5cae631946f7fdf6ec7e84a5bbb78f0 [^]
2014-10-10 09:21migueldejuanaNote Added: 0070858
2014-10-20 16:35migueldejuanaAssigned Tomarvintm => migueldejuana
2014-10-20 16:35migueldejuanaStatusresolved => new
2014-10-20 16:35migueldejuanaResolutionfixed => open
2014-10-20 16:36migueldejuanaStatusnew => scheduled
2014-10-20 16:36migueldejuanafix_in_branch => pi
2014-10-20 16:36migueldejuanaStatusscheduled => resolved
2014-10-20 16:36migueldejuanaResolutionopen => fixed
2014-10-31 03:46szapataReview Assigned To => szapata
2014-10-31 03:46szapataStatusresolved => closed

Notes
(0070857)
hgbot   
2014-10-10 09:18   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 97eec3d5f5cae631946f7fdf6ec7e84a5bbb78f0
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Oct 10 09:17:58 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/97eec3d5f5cae631946f7fdf6ec7e84a5bbb78f0 [^]

Fixed issue 0027568: Add pack button in the ERP is not taking into account cash VAT new functionality

It happens when exists a configuration error. In the fix we only handle NPE.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/discounts/AddPack.java
---
(0070858)
migueldejuana   
2014-10-10 09:21   
Review cash VAT configuration to avoid this problem. Be sure that the Organization have cash VAT checked. Also in the Tax rate used, review if cash VAT is checked and in Accounting, fill Tax Due Transitory and Tax Credit Transitory.