Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027557Retail ModulesWeb POSpublic2014-09-08 17:492015-03-16 17:01
Reportermarvintm 
Assigned ToOsmany 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q2 
Merge Request Status
Review Assigned Tomalsasua
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027557: When the Sessions module is installed, it shouldn't be possible to create orders in a new business date if cash up is not done
DescriptionWhen the sessions module is installed, the orders have a business date and are associated automatically to a till through their cash up.

Currently, it is possible to create orders with different business dates which will then go to the same till (which itself has a business date). This is wrong.
Steps To Reproduce- Open the store on day 1/1.
- Log in the Web POS. Count the cash. This will open the till on day 1/1.
- Create orders. These will have business date 1/1.
- Close the store. Force the closing of the open till.
- Open the store on day 2/1.
- Log in the Web POS. Create orders. These will have business date 2/1.
- Do the cash up. Verify that the till has business date 1/1, but contains orders for both 1/1 and 2/1. This is wrong.
Proposed SolutionDifferent approaches can be followed. One possibility would be to detect that a cash up for the previous business date has not been done but the business date has changed, and in that case force a cash up.
Other possibility would be to show a big warning explaining the situation.
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0028933RR16Q1 closed Retail QA: RR15Q2: Add tests for Mobile applications 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-09-08 17:49marvintmNew Issue
2014-09-08 17:49marvintmAssigned To => marvintm
2014-09-08 17:49marvintmTriggers an Emergency Pack => No
2015-01-29 16:42OsmanyAssigned Tomarvintm => Osmany
2015-02-04 22:41hgbotCheckin
2015-02-04 22:41hgbotNote Added: 0074217
2015-02-04 22:41hgbotStatusnew => resolved
2015-02-04 22:41hgbotResolutionopen => fixed
2015-02-04 22:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/341d8ff674df3c7e7e879186c60e4185bf8c5ae4 [^]
2015-02-04 22:41hgbotCheckin
2015-02-04 22:41hgbotNote Added: 0074218
2015-02-04 22:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/341d8ff674df3c7e7e879186c60e4185bf8c5ae4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/738dfb25435988946cc1ff106c37cae0857b1cf5 [^]
2015-02-05 01:06hgbotCheckin
2015-02-05 01:06hgbotNote Added: 0074220
2015-02-05 01:06hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/738dfb25435988946cc1ff106c37cae0857b1cf5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/f46d3551c3d98a44324f75df653f30c8a2936e0c [^]
2015-02-26 17:37dmitry_mezentsevNote Added: 0074985
2015-03-09 10:53malsasuaNote Added: 0075298
2015-03-09 10:53malsasuaStatusresolved => new
2015-03-09 10:53malsasuaResolutionfixed => open
2015-03-09 22:45hgbotCheckin
2015-03-09 22:45hgbotNote Added: 0075354
2015-03-09 22:45hgbotStatusnew => resolved
2015-03-09 22:45hgbotResolutionopen => fixed
2015-03-09 22:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/f46d3551c3d98a44324f75df653f30c8a2936e0c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/6f1d88e72f766cef122b54cc8bf150068e768ffc [^]
2015-03-10 16:57hgbotCheckin
2015-03-10 16:57hgbotNote Added: 0075413
2015-03-10 20:40hgbotCheckin
2015-03-10 20:40hgbotNote Added: 0075421
2015-03-10 20:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/6f1d88e72f766cef122b54cc8bf150068e768ffc [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/d1f5f5bf22de377e865a2801bbe79356e0653cf8 [^]
2015-03-16 10:27OrekariaRelationship addedblocks 0028933
2015-03-16 12:10adrianromeroNote Added: 0075617
2015-03-16 12:10adrianromeroStatusresolved => new
2015-03-16 12:10adrianromeroResolutionfixed => open
2015-03-16 15:06OsmanyNote Added: 0075627
2015-03-16 17:00malsasuaStatusnew => scheduled
2015-03-16 17:01malsasuaStatusscheduled => resolved
2015-03-16 17:01malsasuaResolutionopen => fixed
2015-03-16 17:01malsasuaReview Assigned To => malsasua
2015-03-16 17:01malsasuaNote Added: 0075637
2015-03-16 17:01malsasuaStatusresolved => closed
2015-03-16 17:01malsasuaFixed in Version => RR15Q2

Notes
(0074217)
hgbot   
2015-02-04 22:41   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 341d8ff674df3c7e7e879186c60e4185bf8c5ae4
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Wed Feb 04 15:29:15 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/341d8ff674df3c7e7e879186c60e4185bf8c5ae4 [^]

Fixed issue 27557: When the Sessions module is installed, it shouldn't be possible to create orders in a new business date if cash up is not done.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.sessions/js/components/BusinessDateWindowView.js
---
(0074218)
hgbot   
2015-02-04 22:41   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 738dfb25435988946cc1ff106c37cae0857b1cf5
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Wed Feb 04 15:39:44 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/738dfb25435988946cc1ff106c37cae0857b1cf5 [^]

Fixed issue 27557: When the Sessions module is installed, it shouldn't be possible to create orders in a new business date if cash up is not done.

---
M web/org.openbravo.retail.sessions/js/components/BusinessDateWindowView.js
---
(0074220)
hgbot   
2015-02-05 01:06   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: f46d3551c3d98a44324f75df653f30c8a2936e0c
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Wed Feb 04 18:04:50 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/f46d3551c3d98a44324f75df653f30c8a2936e0c [^]

Fixed issue 27557: When the Sessions module is installed, it shouldn't be possible to create orders in a new business date if cash up is not done.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0074985)
dmitry_mezentsev   
2015-02-26 17:37   
Not closed for 22 days!!!
(0075298)
malsasua   
2015-03-09 10:53   
there is a flow that the error is reproducible:
. open store in backoffice: date day1
. login terminal
. do receipts
. logout terminal
. close store in backoffice
. open store in backoffice: date day2
. login terminal
no error message is displayed.

Also, the message "You have the cash up pending to be done. Else it no complete the cash up, serious errors will occur." should be more detailed
(0075354)
hgbot   
2015-03-09 22:45   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 6f1d88e72f766cef122b54cc8bf150068e768ffc
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Mon Mar 09 15:44:34 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/6f1d88e72f766cef122b54cc8bf150068e768ffc [^]

Fixed issue 27557: Adding validation, when the store is closed from backoffice and change the message.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0075413)
hgbot   
2015-03-10 16:57   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 27109c7c01d1e5a64e876e0eb6627d6a2d0324a8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 10 16:56:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/27109c7c01d1e5a64e876e0eb6627d6a2d0324a8 [^]

Related to issue 27557: When the Sessions module is installed, it shouldn't be possible to create orders in a new business date if cash up is not done
The data returned from the backend is a standard js object and not a model so therefore get can not be called on it, the properties should be
directly accessed.

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0075421)
hgbot   
2015-03-10 20:40   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: d1f5f5bf22de377e865a2801bbe79356e0653cf8
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Tue Mar 10 13:40:07 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/d1f5f5bf22de377e865a2801bbe79356e0653cf8 [^]

Fixed issue 27557: Change validation, when the store is closed from backoffice.

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0075617)
adrianromero   
2015-03-16 12:10   
With the current implementation it is possible to force to create new orders when there is a new business date and the cashup has not been done. If this is the intended behaviour the issue can be closed.

How to force the creation of new orders:

* Create several orders in a terminal that has a business date ej: 1/3/2015 and logout.
* Go to the server close the till, and close the store.
* Open the store for a new business date. ej: 2/3/2015
* Login in Web POS
** A message appears saying that the business date has changed. Accept.
** A new message appears saying that there are pending orders to cashup. Accept
* The cash up windows appears.
* Cancel
* Create a new order. No warning appears and a new order with a new business date can be created without executing the cashup.
(0075627)
Osmany   
2015-03-16 15:06   
This is expected behaviour. We know this flow is posible if the user cancel the cashup.
(0075637)
malsasua   
2015-03-16 17:01   
verified