Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027470Retail ModulesWeb POSpublic2014-08-26 09:382014-09-03 09:41
Reporteraaroncalero 
Assigned Toaaroncalero 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027470: It would be nice to add a hook after OBPOS_PrePaymentHook but before OBPOS_CheckPaymentApproval
DescriptionIt would be nice to add a hook after OBPOS_PrePaymentHook but before OBPOS_CheckPaymentApproval to ensure certain order when using the OBPOS_PrePaymentHook hook
Steps To ReproduceIt would be nice to add a hook after OBPOS_PrePaymentHook but before OBPOS_CheckPaymentApproval to ensure certain order when using the OBPOS_PrePaymentHook hook
Proposed SolutionAdd a new hook in the callback of OBPOS_PrePaymentHook and let the callback of the new hook continue the approval process. See attached diff.
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0027349RR14Q4 closed Orekaria [API Deprecation] The HookManager does not have to depend on the OB.MobileApp.model object 
Attached Filesdiff pointofsale-model.diff (1,073) 2014-08-26 09:38
https://issues.openbravo.com/file_download.php?file_id=7160&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-08-26 09:38aaroncaleroNew Issue
2014-08-26 09:38aaroncaleroAssigned To => aaroncalero
2014-08-26 09:38aaroncaleroFile Added: pointofsale-model.diff
2014-08-26 09:38aaroncaleroTriggers an Emergency Pack => No
2014-08-26 12:24hgbotCheckin
2014-08-26 12:24hgbotNote Added: 0069753
2014-08-26 12:24hgbotStatusnew => resolved
2014-08-26 12:24hgbotResolutionopen => fixed
2014-08-26 12:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5a45539852d439450ed7396dd0364a89b0a902e3 [^]
2014-08-26 18:44OrekariaNote Added: 0069770
2014-08-26 18:44OrekariaStatusresolved => new
2014-08-26 18:44OrekariaResolutionfixed => open
2014-08-27 08:37hgbotCheckin
2014-08-27 08:37hgbotNote Added: 0069788
2014-08-27 08:37hgbotStatusnew => resolved
2014-08-27 08:37hgbotResolutionopen => fixed
2014-08-27 08:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5a45539852d439450ed7396dd0364a89b0a902e3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/35932e76a4b1bb725be566d795fa1d4ba48c0954 [^]
2014-08-27 13:25OrekariaRelationship addeddepends on 0027349
2014-09-01 09:23aaroncaleroStatusresolved => new
2014-09-01 09:23aaroncaleroResolutionfixed => open
2014-09-01 09:25aaroncaleroReview Assigned To => mtaal
2014-09-01 09:26aaroncaleroStatusnew => scheduled
2014-09-01 09:26aaroncalerofix_in_branch => pi
2014-09-01 09:26aaroncaleroStatusscheduled => resolved
2014-09-01 09:26aaroncaleroResolutionopen => fixed
2014-09-03 09:41mtaalNote Added: 0069931
2014-09-03 09:41mtaalStatusresolved => closed

Notes
(0069753)
hgbot   
2014-08-26 12:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5a45539852d439450ed7396dd0364a89b0a902e3
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Aug 26 12:16:30 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5a45539852d439450ed7396dd0364a89b0a902e3 [^]

Fixes issue 0027470: It would be nice to add a hook after OBPOS_PrePaymentHook

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0069770)
Orekaria   
2014-08-26 18:44   
Please, use the new namespace: https://issues.openbravo.com/view.php?id=27349 [^]
(0069788)
hgbot   
2014-08-27 08:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 35932e76a4b1bb725be566d795fa1d4ba48c0954
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Aug 27 08:26:17 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/35932e76a4b1bb725be566d795fa1d4ba48c0954 [^]

Fixes issue 27470: Use correct namespace for HookManager

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0069931)
mtaal   
2014-09-03 09:41   
Reviewed