0027454: Tax Exempt module does not work with q4 version, sql replacement seems to simple

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0027454

Retail Modules

Tax Exempt

public

2014-08-24 22:26

2015-02-09 16:23

Reporter

mtaal

Assigned To

marvintm

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

scheduled

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0027454: Tax Exempt module does not work with q4 version, sql replacement seems to simple

Description

I found 2 problems.
First:
I changed a line to this, this seems to work, the original line in the modeule is this:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/file/d46b6b9cc1fc/web/org.openbravo.retail.taxexempt/js/taxExemptButton.js#l80 [^]
I changed it to this:
  if (componentHolder && componentHolder.name === 'defaultEdit' && componentHolder.components[0] && componentHolder.components[0].name === 'msgedit' && componentHolder.components[0].components[0] && componentHolder.components[0].components[0].components && componentHolder.components[0].components[0].components.push) {

But this must be validated.

Second:
This code:
  OB.UTIL.HookManager.registerHook('OBPOS_FindTaxRate', function (args, callbacks) {
    if (args.context.get('bp').get('taxExempt')) {
      args.line.set('taxExempt', true);
    } else if (args.line.get('taxExempt')) {
      args.sql = "select * from c_tax where istaxexempt = 'true' order by validfrom desc limit 1";
    }
    OB.UTIL.HookManager.callbackExecutor(args, callbacks);
    return;
  });

Fails because the args does not have a property line. This got solved in this push:
http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ad8bc428c9f8318c2953ecd4d441551c507414a5 [^]

A bigger problems seems to be that the sql replacement proposed above does not seem to be correct, the sql query which gets replaced is really big and the replacement does not seem to cover all cases, it seems better to add the istaxexempt=true to the query.

So this issue is 2 things:
- validate that the first topic has been solved correctly
- check the sql replacement

Steps To Reproduce

Install taxexempt module with the q4 version and run it.

Proposed Solution

Additional Information