Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0027439Openbravo ERP09. Financial managementpublic2014-08-23 16:382015-08-20 23:16
shuehner 
AtulOpenbravo 
normalminorhave not tried
closedfixed 
5
 
 
vmromanos
Core
No
0027439: pl-function c_getwithholding has uuid error (maybe harmless)
That function has one variable defined as varchar2(32) but used to stored numeric values.

running pl-function without any witholding data defined does suprisingly work

as
withholding:=0
return withholding

seems to work in both oracle & postgres even with that variable defined as varchar.

But it is clearly wrong datatype and possibly broken when using all pl-body doing more calculations using that variable.

NOTE: Technically regression introduced with 2.50 project when changing pk's from 2.50 -> 3.0 as then that datatype of that variable was also accidently changed.

Read that pl-function body and compare variable definition with usage.
No tags attached.
Issue History
2014-08-23 16:38shuehnerNew Issue
2014-08-23 16:38shuehnerAssigned To => dmiguelez
2014-08-23 16:38shuehnerModules => Core
2014-08-23 16:38shuehnerTriggers an Emergency Pack => No
2014-08-23 16:39shuehnerNote Added: 0069650
2014-08-23 16:39shuehnerSummarypl-function c_getwithholding has uuid error (but harmless) => pl-function c_getwithholding has uuid error (maybe harmless)
2014-09-03 13:51eduardo_ArgalAssigned Todmiguelez => eduardo_Argal
2015-07-14 09:07AtulOpenbravoAssigned Toeduardo_Argal => AtulOpenbravo
2015-07-14 09:07AtulOpenbravoStatusnew => scheduled
2015-07-15 18:17hgbotCheckin
2015-07-15 18:17hgbotNote Added: 0078834
2015-07-15 18:17hgbotStatusscheduled => resolved
2015-07-15 18:17hgbotResolutionopen => fixed
2015-07-15 18:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d74714cd50ade5882908c11238d4125c2e7cf21f [^]
2015-07-15 18:22vmromanosReview Assigned To => vmromanos
2015-07-15 18:22vmromanosNote Added: 0078835
2015-07-15 18:22vmromanosStatusresolved => closed
2015-08-20 23:16hudsonbotCheckin
2015-08-20 23:16hudsonbotNote Added: 0079494

Notes
(0069650)
shuehner   
2014-08-23 16:39   
Note found using plpgsql-check warning
(0078834)
hgbot   
2015-07-15 18:17   
Repository: erp/devel/pi
Changeset: d74714cd50ade5882908c11238d4125c2e7cf21f
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jul 14 12:46:42 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/d74714cd50ade5882908c11238d4125c2e7cf21f [^]

Fixes Issue 27439:pl-function c_getwithholding has wrong datatype for variable

Withholding variable was wrongly defined as varchar during merge r2.5x into
trunk.

---
M src-db/database/model/functions/C_GETWITHHOLDING.xml
---
(0078835)
vmromanos   
2015-07-15 18:22   
Code review OK
(0079494)
hudsonbot   
2015-08-20 23:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test